Adds support for Preonic rev 3 #3449
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Curiosity is getting the best of me: vs.qmk_firmware/keyboards/preonic/preonic.h Line 43 in f34857c Any reason the matrix names can't be the same? Not a complaint, just an observation. |
|
No reason! Just forgot to change that one over :) been trying to move everything towards "1x2u" since it's a better descriptor. |
|
Ha, I think I spotted something similar in the planck_rev6 branch a while back, and I was wondering if it was gonna stay like that. |
drashna
reviewed
Jul 20, 2018
| @@ -31,6 +31,16 @@ typedef uint32_t matrix_row_t; | |||
| #error "MATRIX_COLS: invalid value" | |||
| #endif | |||
|
|
|||
| #if (MATRIX_ROWS <= 8) | |||
There was a problem hiding this comment.
@That-Canadian I think this will fix the issue with the split boards I was having
sigprof
added a commit
to sigprof/qmk_firmware
that referenced
this pull request
Aug 27, 2020
The matrix_col_t type was added in commit 0284431 (part of qmk#3449), but then the code which used that type was removed in qmk#6140, and no other users were added since that time. The presence of that type, however, limits MATRIX_ROWS to 32, which probably does not matter for a real keyboard, but prevents doing things like making a firmware to test all existing pins on a board like Teensy++ 2.0 (which has 46 GPIOs).
14 tasks
tzarc
pushed a commit
that referenced
this pull request
Aug 31, 2020
The matrix_col_t type was added in commit 0284431 (part of #3449), but then the code which used that type was removed in #6140, and no other users were added since that time. The presence of that type, however, limits MATRIX_ROWS to 32, which probably does not matter for a real keyboard, but prevents doing things like making a firmware to test all existing pins on a board like Teensy++ 2.0 (which has 46 GPIOs).
noroadsleft
pushed a commit
that referenced
this pull request
Sep 4, 2020
The matrix_col_t type was added in commit 0284431 (part of #3449), but then the code which used that type was removed in #6140, and no other users were added since that time. The presence of that type, however, limits MATRIX_ROWS to 32, which probably does not matter for a real keyboard, but prevents doing things like making a firmware to test all existing pins on a board like Teensy++ 2.0 (which has 46 GPIOs).
noroadsleft
pushed a commit
that referenced
this pull request
Sep 12, 2020
The matrix_col_t type was added in commit 0284431 (part of #3449), but then the code which used that type was removed in #6140, and no other users were added since that time. The presence of that type, however, limits MATRIX_ROWS to 32, which probably does not matter for a real keyboard, but prevents doing things like making a firmware to test all existing pins on a board like Teensy++ 2.0 (which has 46 GPIOs).
chris-beedie
pushed a commit
to chris-beedie/qmk_firmware
that referenced
this pull request
Sep 20, 2020
The matrix_col_t type was added in commit 0284431 (part of qmk#3449), but then the code which used that type was removed in qmk#6140, and no other users were added since that time. The presence of that type, however, limits MATRIX_ROWS to 32, which probably does not matter for a real keyboard, but prevents doing things like making a firmware to test all existing pins on a board like Teensy++ 2.0 (which has 46 GPIOs).
skullydazed
pushed a commit
that referenced
this pull request
Oct 18, 2020
The matrix_col_t type was added in commit 0284431 (part of #3449), but then the code which used that type was removed in #6140, and no other users were added since that time. The presence of that type, however, limits MATRIX_ROWS to 32, which probably does not matter for a real keyboard, but prevents doing things like making a firmware to test all existing pins on a board like Teensy++ 2.0 (which has 46 GPIOs).
noroadsleft
pushed a commit
that referenced
this pull request
Oct 23, 2020
The matrix_col_t type was added in commit 0284431 (part of #3449), but then the code which used that type was removed in #6140, and no other users were added since that time. The presence of that type, however, limits MATRIX_ROWS to 32, which probably does not matter for a real keyboard, but prevents doing things like making a firmware to test all existing pins on a board like Teensy++ 2.0 (which has 46 GPIOs).
skullydazed
pushed a commit
that referenced
this pull request
Oct 28, 2020
The matrix_col_t type was added in commit 0284431 (part of #3449), but then the code which used that type was removed in #6140, and no other users were added since that time. The presence of that type, however, limits MATRIX_ROWS to 32, which probably does not matter for a real keyboard, but prevents doing things like making a firmware to test all existing pins on a board like Teensy++ 2.0 (which has 46 GPIOs).
noroadsleft
pushed a commit
that referenced
this pull request
Oct 30, 2020
The matrix_col_t type was added in commit 0284431 (part of #3449), but then the code which used that type was removed in #6140, and no other users were added since that time. The presence of that type, however, limits MATRIX_ROWS to 32, which probably does not matter for a real keyboard, but prevents doing things like making a firmware to test all existing pins on a board like Teensy++ 2.0 (which has 46 GPIOs).
jMavarez
pushed a commit
to jMavarez/qmk_firmware
that referenced
this pull request
Oct 14, 2021
The matrix_col_t type was added in commit 0284431 (part of qmk#3449), but then the code which used that type was removed in qmk#6140, and no other users were added since that time. The presence of that type, however, limits MATRIX_ROWS to 32, which probably does not matter for a real keyboard, but prevents doing things like making a firmware to test all existing pins on a board like Teensy++ 2.0 (which has 46 GPIOs).
BorisTestov
pushed a commit
to BorisTestov/qmk_firmware
that referenced
this pull request
May 23, 2024
The matrix_col_t type was added in commit 203ba57 (part of qmk#3449), but then the code which used that type was removed in qmk#6140, and no other users were added since that time. The presence of that type, however, limits MATRIX_ROWS to 32, which probably does not matter for a real keyboard, but prevents doing things like making a firmware to test all existing pins on a board like Teensy++ 2.0 (which has 46 GPIOs).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also adds
matrix_col_twhich is dependent on the value ofMATRIX_ROWS- I think this has been missing because not many boards try to take advantage of fancy row/col setups, or if they do, they increase the cols without making the rows go above 8.