Fix the make all-keyboards command #422
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unfortunately the supported targets, like "quick", "all", "clean", and so on has to be repeated two extra times, but this is the best I can do with my makefile skills.
|
|
||
| all-keyboards-all: $(addsuffix -all,$(KEYBOARDS)) | ||
| all-keyboards-quick: $(addsuffix -quick,$(KEYBOARDS)) | ||
| all-keyboards-clean: $(addsuffix -clean,$(KEYBOARDS)) |
There was a problem hiding this comment.
If I remember my make-fu right, this should work:
all-keyboards-%: $(addsuffix -$*,${KEYBOARDS})There was a problem hiding this comment.
That is what I thought too, and I tried many variations of this yesterday, and now again, this is what I get
$ make all-keyboards-quick
make: *** No rule to make target 'all-keyboards-quick'. Stop.
If I do this instead though
all-keyboards-%:
echo $(addsuffix -$*,${KEYBOARDS})
It prints out the correct rule names, so the prerequisites pattern is right. I also tried adding the debug flag to make, and it didn't help me debug the problem either. But maybe someone with better makefile programming skills could?
|
Thanks for looking into those - let's merge this for now, and any improvements can be built upon it :) |
|
Mm. I know I can make this simple, will dive into make at some point and open a PR. Thanks for testing, @fredizzimo! And apologies for the noise. |
ryaninvents
pushed a commit
to ryaninvents/qmk_firmware
that referenced
this pull request
Aug 12, 2016
Unfortunately the supported targets, like "quick", "all", "clean", and so on has to be repeated two extra times, but this is the best I can do with my makefile skills.
roxk
added a commit
to oursky/qmk_firmware
that referenced
this pull request
Mar 10, 2022
jiaxin96
pushed a commit
to Oh-My-Mechanical-Keyboard/qmk_firmware
that referenced
this pull request
Oct 18, 2023
* Update info.JSON to match QMK repo modification * Disabling extrakeys and mousekeys in vial rules.mk
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unfortunately the supported targets, like "quick", "all", "clean",and so on has to be repeated two extra times, but this is the best I can do with my makefile skills.