Overhaul Unicode Common functionality #4325

drashna · 2018-11-02T17:38:14Z

Move input mode initialization to a proper function and call it from matrix_init_quantum
Move all the keycode processing to unicode common file
Add keycodes for unicode input methods
Add optional audio feedback to keycodes
Remove UC_OSX_RALT input method
Make keycodes used by UC_OSX and UC_WINC configurable
Add optional ability to cycle through input modes (configurable)

Massive thanks to:
Co-Authored-By: [email protected]

docs/feature_unicode.md

quantum/process_keycode/process_ucis.c

quantum/process_keycode/process_unicode_common.c

quantum/process_keycode/process_unicode_common.h

quantum/process_keycode/process_unicode_common.c

drashna · 2018-11-02T19:59:33Z

good lord, the number of commits!

Yeah, this PR is getting squashed. :D

quantum/process_keycode/process_unicode_common.c

quantum/quantum_keycodes.h

vomindoraan · 2018-11-03T14:23:33Z

Additional suggestions are here: drashna#13.

vomindoraan

LGTM 👍 Would be great if this could be merged soon, as this paves the way for further improvements to Unicode support.

vomindoraan · 2018-11-03T21:02:10Z

@drashna Hahaha, I saw that 😄 I was actually intending to add it in #4217 since I didn't want to bloat this PR any further (though I guess it kind of did end up bloated).

vomindoraan · 2018-11-03T21:28:39Z

On that note: drashna#14

docs/feature_unicode.md

quantum/quantum_keycodes.h

quantum/process_keycode/process_unicode_common.c

docs/feature_unicode.md

vomindoraan · 2018-11-25T18:20:54Z

Bumparoni

@drashna Could you resolve the conflict?

quantum/process_keycode/process_ucis.c

drashna · 2018-11-25T20:13:56Z

@vomindoraan after much deliberation, I finally agree that the configurable OSX key is definitely better and am/have worked that into this PR.

And I think I'll work the cycle button in too.

vomindoraan · 2018-11-25T20:16:41Z

@drashna There's no need to expand the scope of this PR further. The sooner it is merged, the sooner the other PRs implementing those feature can be merged as well. So please don't do that.

I just merged this PR into #4217. Cycling (#4221) isn't done yet: I need to update the docs.

* case alignment * process_record_unicode_common → process_unicode_common * Move song arrays into function where they're used, align preprocessor directives * Swap the order of UC_WIN and UC_BSD * Update Unicode docs * Reorder Unicode mode stuff to match the order of input mode constants * Fix capitalization in doc subtitle * Readd BSD and OSX_RALT songs * Reword BSD note in docs * Readd BSD keycode description * Reword explanation of input on different platforms

Co-Authored-By: vomindoraan ([email protected])

Co-Authored-By: drashna <[email protected]>

* Standardize the Unicode EEPROM code * Remove unicode init from process_record_* functions * Add unicode init to where it belongs: matrix_init_quantum * Move Unicode proccessing to unicode common * Add audio feedback to input mode keys to drive konstantin up a wall * Tap_code cleanup * Update keycodes * Update unicode documentation * Update unicode keycodes for consistency/easier merge * Add Audio Feedback section * Remove Functions from feature page And link to the file instead. Link to specific lines later on. * Fix white spaces Co-Authored-By: drashna <[email protected]> * Fix spacing Co-Authored-By: drashna <[email protected]> * Because I missed it! Co-Authored-By: drashna <[email protected]> * Fix spacing Co-Authored-By: drashna <[email protected]> * SPAAAAAAAAAACing Co-Authored-By: drashna <[email protected]> * white spaces Co-Authored-By: drashna <[email protected]> * Add BSD for future compatibility * Thought I fixed that! Co-Authored-By: drashna <[email protected]> * non-breaking Co-Authored-By: drashna <[email protected]> * Considered that Co-Authored-By: drashna <[email protected]> * Yuuup Co-Authored-By: drashna <[email protected]> * consistency Co-Authored-By: drashna <[email protected]> * white spaces .... copied from elsewhere Co-Authored-By: drashna <[email protected]> * white spaces Co-Authored-By: drashna <[email protected]> * white spaces Co-Authored-By: drashna <[email protected]> * Update keycode defines * Fix Linux Song * Update all of the songs * Cleanup * Move and update check to ensure only one unicode method is enabled * Update quantum/quantum_keycodes.h * Update documentation * Wordsmithing and cleanup * Format unicode_common (#13) * case alignment * process_record_unicode_common → process_unicode_common * Move song arrays into function where they're used, align preprocessor directives * Swap the order of UC_WIN and UC_BSD * Update Unicode docs * Reorder Unicode mode stuff to match the order of input mode constants * Fix capitalization in doc subtitle * Readd BSD and OSX_RALT songs * Reword BSD note in docs * Readd BSD keycode description * Reword explanation of input on different platforms * Steal vomindoraan's input mode documentation Co-Authored-By: vomindoraan ([email protected]) * Willingly give Drashna the rest of my Unicode doc improvements * Wordsmithing Co-Authored-By: drashna <[email protected]> * Rearrange process_unicode_common functions * Make Unicode input mode constants (UC_*) an enum * Simplify unicode_input_start/finish code * Make the key used for WinCompose configurable * Remove UC_OSX_RALT in favor of setting the key with UNICODE_OSX_KEY * Update Unicode input mode doc * Add descriptions and rearrange definitions in process_unicode_common.h * Add registry command to Unicode docs + misc updates * Reword an explanation in Unicode docs * Add TODO comment * Remove trailing whitespace

* Standardize the Unicode EEPROM code * Remove unicode init from process_record_* functions * Add unicode init to where it belongs: matrix_init_quantum * Move Unicode proccessing to unicode common * Add audio feedback to input mode keys to drive konstantin up a wall * Tap_code cleanup * Update keycodes * Update unicode documentation * Update unicode keycodes for consistency/easier merge * Add Audio Feedback section * Remove Functions from feature page And link to the file instead. Link to specific lines later on. * Fix white spaces Co-Authored-By: drashna <[email protected]> * Fix spacing Co-Authored-By: drashna <[email protected]> * Because I missed it! Co-Authored-By: drashna <[email protected]> * Fix spacing Co-Authored-By: drashna <[email protected]> * SPAAAAAAAAAACing Co-Authored-By: drashna <[email protected]> * white spaces Co-Authored-By: drashna <[email protected]> * Add BSD for future compatibility * Thought I fixed that! Co-Authored-By: drashna <[email protected]> * non-breaking Co-Authored-By: drashna <[email protected]> * Considered that Co-Authored-By: drashna <[email protected]> * Yuuup Co-Authored-By: drashna <[email protected]> * consistency Co-Authored-By: drashna <[email protected]> * white spaces .... copied from elsewhere Co-Authored-By: drashna <[email protected]> * white spaces Co-Authored-By: drashna <[email protected]> * white spaces Co-Authored-By: drashna <[email protected]> * Update keycode defines * Fix Linux Song * Update all of the songs * Cleanup * Move and update check to ensure only one unicode method is enabled * Update quantum/quantum_keycodes.h * Update documentation * Wordsmithing and cleanup * Format unicode_common (#13) * case alignment * process_record_unicode_common → process_unicode_common * Move song arrays into function where they're used, align preprocessor directives * Swap the order of UC_WIN and UC_BSD * Update Unicode docs * Reorder Unicode mode stuff to match the order of input mode constants * Fix capitalization in doc subtitle * Readd BSD and OSX_RALT songs * Reword BSD note in docs * Readd BSD keycode description * Reword explanation of input on different platforms * Steal vomindoraan's input mode documentation Co-Authored-By: vomindoraan ([email protected]) * Willingly give Drashna the rest of my Unicode doc improvements * Wordsmithing Co-Authored-By: drashna <[email protected]> * Rearrange process_unicode_common functions * Make Unicode input mode constants (UC_*) an enum * Simplify unicode_input_start/finish code * Make the key used for WinCompose configurable * Remove UC_OSX_RALT in favor of setting the key with UNICODE_OSX_KEY * Update Unicode input mode doc * Add descriptions and rearrange definitions in process_unicode_common.h * Add registry command to Unicode docs + misc updates * Reword an explanation in Unicode docs * Add TODO comment * Add cycle_unicode_input_mode and UNICODE_SELECTED_MODES macro * Add an option for making cycle changes persistent * Add debug prints to functions that change input_mode * Use cycle_unicode_input_mode in whitefox/konstantin * Add persist_unicode_input_mode function * Add offset to cycle to allow stepping in reverse * Add keycodes: UNICODE_MODE_FORWARD, UNICODE_MODE_REVERSE Aliases: UC_MOD, UC_RMOD (respectively) * REVERT ME: Undo changes to whitefox/konstantin to avoid conflicts * Fix wrong constant name * Revert "REVERT ME: Undo changes to whitefox/konstantin to avoid conflicts" This reverts commit 42676bf. * Change dprintf text * Give selected modes priority over EEPROM when !UNICODE_CYCLE_PERSIST * Remove trailing whitespace

* Standardize the Unicode EEPROM code * Remove unicode init from process_record_* functions * Add unicode init to where it belongs: matrix_init_quantum * Move Unicode proccessing to unicode common * Add audio feedback to input mode keys to drive konstantin up a wall * Tap_code cleanup * Update keycodes * Update unicode documentation * Update unicode keycodes for consistency/easier merge * Add Audio Feedback section * Remove Functions from feature page And link to the file instead. Link to specific lines later on. * Fix spacing Co-Authored-By: drashna <[email protected]> * Because I missed it! Co-Authored-By: drashna <[email protected]> * Fix spacing Co-Authored-By: drashna <[email protected]> * SPAAAAAAAAAACing Co-Authored-By: drashna <[email protected]> * Add BSD for future compatibility * Thought I fixed that! Co-Authored-By: drashna <[email protected]> * non-breaking Co-Authored-By: drashna <[email protected]> * Considered that Co-Authored-By: drashna <[email protected]> * Yuuup Co-Authored-By: drashna <[email protected]> * consistency Co-Authored-By: drashna <[email protected]> * white spaces .... copied from elsewhere Co-Authored-By: drashna <[email protected]> * white spaces Co-Authored-By: drashna <[email protected]> * white spaces Co-Authored-By: drashna <[email protected]> * Update keycode defines * Fix Linux Song * Update all of the songs * Cleanup * Move and update check to ensure only one unicode method is enabled * Update quantum/quantum_keycodes.h * Update documentation * Wordsmithing and cleanup * Format unicode_common (#13) * case alignment * process_record_unicode_common → process_unicode_common * Move song arrays into function where they're used, align preprocessor directives * Swap the order of UC_WIN and UC_BSD * Update Unicode docs * Reorder Unicode mode stuff to match the order of input mode constants * Fix capitalization in doc subtitle * Readd BSD and OSX_RALT songs * Reword BSD note in docs * Readd BSD keycode description * Reword explanation of input on different platforms * Steal vomindoraan's input mode documentation Co-Authored-By: vomindoraan ([email protected]) * Willingly give Drashna the rest of my Unicode doc improvements * Wordsmithing Co-Authored-By: drashna <[email protected]> * remove merge artifacts * Unicode common cleanup (#17) * Standardize the Unicode EEPROM code * Remove unicode init from process_record_* functions * Add unicode init to where it belongs: matrix_init_quantum * Move Unicode proccessing to unicode common * Add audio feedback to input mode keys to drive konstantin up a wall * Tap_code cleanup * Update keycodes * Update unicode documentation * Update unicode keycodes for consistency/easier merge * Add Audio Feedback section * Remove Functions from feature page And link to the file instead. Link to specific lines later on. * Fix white spaces Co-Authored-By: drashna <[email protected]> * Fix spacing Co-Authored-By: drashna <[email protected]> * Because I missed it! Co-Authored-By: drashna <[email protected]> * Fix spacing Co-Authored-By: drashna <[email protected]> * SPAAAAAAAAAACing Co-Authored-By: drashna <[email protected]> * white spaces Co-Authored-By: drashna <[email protected]> * Add BSD for future compatibility * Thought I fixed that! Co-Authored-By: drashna <[email protected]> * non-breaking Co-Authored-By: drashna <[email protected]> * Considered that Co-Authored-By: drashna <[email protected]> * Yuuup Co-Authored-By: drashna <[email protected]> * consistency Co-Authored-By: drashna <[email protected]> * white spaces .... copied from elsewhere Co-Authored-By: drashna <[email protected]> * white spaces Co-Authored-By: drashna <[email protected]> * white spaces Co-Authored-By: drashna <[email protected]> * Update keycode defines * Fix Linux Song * Update all of the songs * Cleanup * Move and update check to ensure only one unicode method is enabled * Update quantum/quantum_keycodes.h * Update documentation * Wordsmithing and cleanup * Format unicode_common (#13) * case alignment * process_record_unicode_common → process_unicode_common * Move song arrays into function where they're used, align preprocessor directives * Swap the order of UC_WIN and UC_BSD * Update Unicode docs * Reorder Unicode mode stuff to match the order of input mode constants * Fix capitalization in doc subtitle * Readd BSD and OSX_RALT songs * Reword BSD note in docs * Readd BSD keycode description * Reword explanation of input on different platforms * Steal vomindoraan's input mode documentation Co-Authored-By: vomindoraan ([email protected]) * Willingly give Drashna the rest of my Unicode doc improvements * Wordsmithing Co-Authored-By: drashna <[email protected]> * Rearrange process_unicode_common functions * Make Unicode input mode constants (UC_*) an enum * Simplify unicode_input_start/finish code * Make the key used for WinCompose configurable * Remove UC_OSX_RALT in favor of setting the key with UNICODE_OSX_KEY * Update Unicode input mode doc * Add descriptions and rearrange definitions in process_unicode_common.h * Add registry command to Unicode docs + misc updates * Reword an explanation in Unicode docs * Add TODO comment * Remove trailing whitespace * Improve Cycling documentation * Add Unicode Input method Cycling support (#19) * Standardize the Unicode EEPROM code * Remove unicode init from process_record_* functions * Add unicode init to where it belongs: matrix_init_quantum * Move Unicode proccessing to unicode common * Add audio feedback to input mode keys to drive konstantin up a wall * Tap_code cleanup * Update keycodes * Update unicode documentation * Update unicode keycodes for consistency/easier merge * Add Audio Feedback section * Remove Functions from feature page And link to the file instead. Link to specific lines later on. * Fix white spaces Co-Authored-By: drashna <[email protected]> * Fix spacing Co-Authored-By: drashna <[email protected]> * Because I missed it! Co-Authored-By: drashna <[email protected]> * Fix spacing Co-Authored-By: drashna <[email protected]> * SPAAAAAAAAAACing Co-Authored-By: drashna <[email protected]> * white spaces Co-Authored-By: drashna <[email protected]> * Add BSD for future compatibility * Thought I fixed that! Co-Authored-By: drashna <[email protected]> * non-breaking Co-Authored-By: drashna <[email protected]> * Considered that Co-Authored-By: drashna <[email protected]> * Yuuup Co-Authored-By: drashna <[email protected]> * consistency Co-Authored-By: drashna <[email protected]> * white spaces .... copied from elsewhere Co-Authored-By: drashna <[email protected]> * white spaces Co-Authored-By: drashna <[email protected]> * white spaces Co-Authored-By: drashna <[email protected]> * Update keycode defines * Fix Linux Song * Update all of the songs * Cleanup * Move and update check to ensure only one unicode method is enabled * Update quantum/quantum_keycodes.h * Update documentation * Wordsmithing and cleanup * Format unicode_common (#13) * case alignment * process_record_unicode_common → process_unicode_common * Move song arrays into function where they're used, align preprocessor directives * Swap the order of UC_WIN and UC_BSD * Update Unicode docs * Reorder Unicode mode stuff to match the order of input mode constants * Fix capitalization in doc subtitle * Readd BSD and OSX_RALT songs * Reword BSD note in docs * Readd BSD keycode description * Reword explanation of input on different platforms * Steal vomindoraan's input mode documentation Co-Authored-By: vomindoraan ([email protected]) * Willingly give Drashna the rest of my Unicode doc improvements * Wordsmithing Co-Authored-By: drashna <[email protected]> * Rearrange process_unicode_common functions * Make Unicode input mode constants (UC_*) an enum * Simplify unicode_input_start/finish code * Make the key used for WinCompose configurable * Remove UC_OSX_RALT in favor of setting the key with UNICODE_OSX_KEY * Update Unicode input mode doc * Add descriptions and rearrange definitions in process_unicode_common.h * Add registry command to Unicode docs + misc updates * Reword an explanation in Unicode docs * Add TODO comment * Add cycle_unicode_input_mode and UNICODE_SELECTED_MODES macro * Add an option for making cycle changes persistent * Add debug prints to functions that change input_mode * Use cycle_unicode_input_mode in whitefox/konstantin * Add persist_unicode_input_mode function * Add offset to cycle to allow stepping in reverse * Add keycodes: UNICODE_MODE_FORWARD, UNICODE_MODE_REVERSE Aliases: UC_MOD, UC_RMOD (respectively) * REVERT ME: Undo changes to whitefox/konstantin to avoid conflicts * Fix wrong constant name * Revert "REVERT ME: Undo changes to whitefox/konstantin to avoid conflicts" This reverts commit 42676bf. * Change dprintf text * Give selected modes priority over EEPROM when !UNICODE_CYCLE_PERSIST * Remove trailing whitespace * Cleanup of RALT code and unicode compilation stuff * Remove else for unicode handling

* Standardize the Unicode EEPROM code * Remove unicode init from process_record_* functions * Add unicode init to where it belongs: matrix_init_quantum * Move Unicode proccessing to unicode common * Add audio feedback to input mode keys to drive konstantin up a wall * Tap_code cleanup * Update keycodes * Update unicode documentation * Update unicode keycodes for consistency/easier merge * Add Audio Feedback section * Remove Functions from feature page And link to the file instead. Link to specific lines later on. * Fix spacing Co-Authored-By: drashna <[email protected]> * Because I missed it! Co-Authored-By: drashna <[email protected]> * Fix spacing Co-Authored-By: drashna <[email protected]> * SPAAAAAAAAAACing Co-Authored-By: drashna <[email protected]> * Add BSD for future compatibility * Thought I fixed that! Co-Authored-By: drashna <[email protected]> * non-breaking Co-Authored-By: drashna <[email protected]> * Considered that Co-Authored-By: drashna <[email protected]> * Yuuup Co-Authored-By: drashna <[email protected]> * consistency Co-Authored-By: drashna <[email protected]> * white spaces .... copied from elsewhere Co-Authored-By: drashna <[email protected]> * white spaces Co-Authored-By: drashna <[email protected]> * white spaces Co-Authored-By: drashna <[email protected]> * Update keycode defines * Fix Linux Song * Update all of the songs * Cleanup * Move and update check to ensure only one unicode method is enabled * Update quantum/quantum_keycodes.h * Update documentation * Wordsmithing and cleanup * Format unicode_common (qmk#13) * case alignment * process_record_unicode_common → process_unicode_common * Move song arrays into function where they're used, align preprocessor directives * Swap the order of UC_WIN and UC_BSD * Update Unicode docs * Reorder Unicode mode stuff to match the order of input mode constants * Fix capitalization in doc subtitle * Readd BSD and OSX_RALT songs * Reword BSD note in docs * Readd BSD keycode description * Reword explanation of input on different platforms * Steal vomindoraan's input mode documentation Co-Authored-By: vomindoraan ([email protected]) * Willingly give Drashna the rest of my Unicode doc improvements * Wordsmithing Co-Authored-By: drashna <[email protected]> * remove merge artifacts * Unicode common cleanup (qmk#17) * Standardize the Unicode EEPROM code * Remove unicode init from process_record_* functions * Add unicode init to where it belongs: matrix_init_quantum * Move Unicode proccessing to unicode common * Add audio feedback to input mode keys to drive konstantin up a wall * Tap_code cleanup * Update keycodes * Update unicode documentation * Update unicode keycodes for consistency/easier merge * Add Audio Feedback section * Remove Functions from feature page And link to the file instead. Link to specific lines later on. * Fix white spaces Co-Authored-By: drashna <[email protected]> * Fix spacing Co-Authored-By: drashna <[email protected]> * Because I missed it! Co-Authored-By: drashna <[email protected]> * Fix spacing Co-Authored-By: drashna <[email protected]> * SPAAAAAAAAAACing Co-Authored-By: drashna <[email protected]> * white spaces Co-Authored-By: drashna <[email protected]> * Add BSD for future compatibility * Thought I fixed that! Co-Authored-By: drashna <[email protected]> * non-breaking Co-Authored-By: drashna <[email protected]> * Considered that Co-Authored-By: drashna <[email protected]> * Yuuup Co-Authored-By: drashna <[email protected]> * consistency Co-Authored-By: drashna <[email protected]> * white spaces .... copied from elsewhere Co-Authored-By: drashna <[email protected]> * white spaces Co-Authored-By: drashna <[email protected]> * white spaces Co-Authored-By: drashna <[email protected]> * Update keycode defines * Fix Linux Song * Update all of the songs * Cleanup * Move and update check to ensure only one unicode method is enabled * Update quantum/quantum_keycodes.h * Update documentation * Wordsmithing and cleanup * Format unicode_common (qmk#13) * case alignment * process_record_unicode_common → process_unicode_common * Move song arrays into function where they're used, align preprocessor directives * Swap the order of UC_WIN and UC_BSD * Update Unicode docs * Reorder Unicode mode stuff to match the order of input mode constants * Fix capitalization in doc subtitle * Readd BSD and OSX_RALT songs * Reword BSD note in docs * Readd BSD keycode description * Reword explanation of input on different platforms * Steal vomindoraan's input mode documentation Co-Authored-By: vomindoraan ([email protected]) * Willingly give Drashna the rest of my Unicode doc improvements * Wordsmithing Co-Authored-By: drashna <[email protected]> * Rearrange process_unicode_common functions * Make Unicode input mode constants (UC_*) an enum * Simplify unicode_input_start/finish code * Make the key used for WinCompose configurable * Remove UC_OSX_RALT in favor of setting the key with UNICODE_OSX_KEY * Update Unicode input mode doc * Add descriptions and rearrange definitions in process_unicode_common.h * Add registry command to Unicode docs + misc updates * Reword an explanation in Unicode docs * Add TODO comment * Remove trailing whitespace * Improve Cycling documentation * Add Unicode Input method Cycling support (qmk#19) * Standardize the Unicode EEPROM code * Remove unicode init from process_record_* functions * Add unicode init to where it belongs: matrix_init_quantum * Move Unicode proccessing to unicode common * Add audio feedback to input mode keys to drive konstantin up a wall * Tap_code cleanup * Update keycodes * Update unicode documentation * Update unicode keycodes for consistency/easier merge * Add Audio Feedback section * Remove Functions from feature page And link to the file instead. Link to specific lines later on. * Fix white spaces Co-Authored-By: drashna <[email protected]> * Fix spacing Co-Authored-By: drashna <[email protected]> * Because I missed it! Co-Authored-By: drashna <[email protected]> * Fix spacing Co-Authored-By: drashna <[email protected]> * SPAAAAAAAAAACing Co-Authored-By: drashna <[email protected]> * white spaces Co-Authored-By: drashna <[email protected]> * Add BSD for future compatibility * Thought I fixed that! Co-Authored-By: drashna <[email protected]> * non-breaking Co-Authored-By: drashna <[email protected]> * Considered that Co-Authored-By: drashna <[email protected]> * Yuuup Co-Authored-By: drashna <[email protected]> * consistency Co-Authored-By: drashna <[email protected]> * white spaces .... copied from elsewhere Co-Authored-By: drashna <[email protected]> * white spaces Co-Authored-By: drashna <[email protected]> * white spaces Co-Authored-By: drashna <[email protected]> * Update keycode defines * Fix Linux Song * Update all of the songs * Cleanup * Move and update check to ensure only one unicode method is enabled * Update quantum/quantum_keycodes.h * Update documentation * Wordsmithing and cleanup * Format unicode_common (qmk#13) * case alignment * process_record_unicode_common → process_unicode_common * Move song arrays into function where they're used, align preprocessor directives * Swap the order of UC_WIN and UC_BSD * Update Unicode docs * Reorder Unicode mode stuff to match the order of input mode constants * Fix capitalization in doc subtitle * Readd BSD and OSX_RALT songs * Reword BSD note in docs * Readd BSD keycode description * Reword explanation of input on different platforms * Steal vomindoraan's input mode documentation Co-Authored-By: vomindoraan ([email protected]) * Willingly give Drashna the rest of my Unicode doc improvements * Wordsmithing Co-Authored-By: drashna <[email protected]> * Rearrange process_unicode_common functions * Make Unicode input mode constants (UC_*) an enum * Simplify unicode_input_start/finish code * Make the key used for WinCompose configurable * Remove UC_OSX_RALT in favor of setting the key with UNICODE_OSX_KEY * Update Unicode input mode doc * Add descriptions and rearrange definitions in process_unicode_common.h * Add registry command to Unicode docs + misc updates * Reword an explanation in Unicode docs * Add TODO comment * Add cycle_unicode_input_mode and UNICODE_SELECTED_MODES macro * Add an option for making cycle changes persistent * Add debug prints to functions that change input_mode * Use cycle_unicode_input_mode in whitefox/konstantin * Add persist_unicode_input_mode function * Add offset to cycle to allow stepping in reverse * Add keycodes: UNICODE_MODE_FORWARD, UNICODE_MODE_REVERSE Aliases: UC_MOD, UC_RMOD (respectively) * REVERT ME: Undo changes to whitefox/konstantin to avoid conflicts * Fix wrong constant name * Revert "REVERT ME: Undo changes to whitefox/konstantin to avoid conflicts" This reverts commit 42676bf. * Change dprintf text * Give selected modes priority over EEPROM when !UNICODE_CYCLE_PERSIST * Remove trailing whitespace * Cleanup of RALT code and unicode compilation stuff * Remove else for unicode handling

drashna added core documentation enhancement optimization labels Nov 2, 2018

drashna requested review from fredizzimo, jackhumbert, mechmerlin and skullydazed November 2, 2018 17:38

vomindoraan suggested changes Nov 2, 2018

View reviewed changes

quantum/process_keycode/process_unicode_common.c Outdated Show resolved Hide resolved

quantum/process_keycode/process_unicode_common.c Outdated Show resolved Hide resolved

vomindoraan reviewed Nov 2, 2018

View reviewed changes

quantum/process_keycode/process_unicode_common.c Outdated Show resolved Hide resolved

vomindoraan suggested changes Nov 2, 2018

View reviewed changes

quantum/process_keycode/process_unicode_common.c Outdated Show resolved Hide resolved

vomindoraan reviewed Nov 2, 2018

View reviewed changes

quantum/quantum_keycodes.h Outdated Show resolved Hide resolved

drashna force-pushed the make_unicode_init branch from 122b418 to 455c143 Compare November 3, 2018 00:47

vomindoraan mentioned this pull request Nov 3, 2018

Format unicode_common drashna/qmk_firmware#13

Merged

vomindoraan approved these changes Nov 3, 2018

View reviewed changes

This was referenced Nov 3, 2018

Refactor process_unicode_common code + make keys used for UC_WINC and UC_OSX configurable #4217

Closed

Allow easy switching/cycling between Unicode input modes #4221

Closed

jackhumbert approved these changes Nov 3, 2018

View reviewed changes

vomindoraan reviewed Nov 3, 2018

View reviewed changes

docs/feature_unicode.md Outdated Show resolved Hide resolved

vomindoraan suggested changes Nov 5, 2018

View reviewed changes

drashna force-pushed the make_unicode_init branch from 18830a8 to 0f006dc Compare November 8, 2018 16:25

vomindoraan suggested changes Nov 25, 2018

View reviewed changes

quantum/process_keycode/process_ucis.c Outdated Show resolved Hide resolved

drashna and others added 15 commits December 5, 2018 18:41

Cleanup

8e0ec8f

Move and update check to ensure only one unicode method is enabled

de8b38e

Update quantum/quantum_keycodes.h

6f1c31f

Update documentation

65cfcf9

Wordsmithing and cleanup

662d3ff

Steal vomindoraan's input mode documentation

735fdfd

Co-Authored-By: vomindoraan ([email protected])

Willingly give Drashna the rest of my Unicode doc improvements

3ad9833

Wordsmithing

917bf83

Co-Authored-By: drashna <[email protected]>

remove merge artifacts

41e6877

Improve Cycling documentation

5cfd48d

Cleanup of RALT code and unicode compilation stuff

fadc218

Remove else for unicode handling

0f52426

drashna force-pushed the make_unicode_init branch from e233a7f to 0f52426 Compare December 6, 2018 02:42

vomindoraan approved these changes Dec 18, 2018

View reviewed changes

mechmerlin approved these changes Dec 19, 2018

View reviewed changes

mechmerlin merged commit fdeec29 into qmk:master Dec 19, 2018

drashna deleted the make_unicode_init branch December 19, 2018 16:42

vomindoraan mentioned this pull request Jan 4, 2019

Improve consistency in UNICODEMAP code and docs, update docs/understanding_qmk #4774

Merged

13 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Overhaul Unicode Common functionality #4325

Overhaul Unicode Common functionality #4325

drashna commented Nov 2, 2018 •

edited

Loading

drashna commented Nov 2, 2018

vomindoraan commented Nov 3, 2018

vomindoraan left a comment

vomindoraan commented Nov 3, 2018

vomindoraan commented Nov 3, 2018

vomindoraan commented Nov 25, 2018

drashna commented Nov 25, 2018

vomindoraan commented Nov 25, 2018

Overhaul Unicode Common functionality #4325

Overhaul Unicode Common functionality #4325

Conversation

drashna commented Nov 2, 2018 • edited Loading

drashna commented Nov 2, 2018

vomindoraan commented Nov 3, 2018

vomindoraan left a comment

Choose a reason for hiding this comment

vomindoraan commented Nov 3, 2018

vomindoraan commented Nov 3, 2018

vomindoraan commented Nov 25, 2018

drashna commented Nov 25, 2018

vomindoraan commented Nov 25, 2018

drashna commented Nov 2, 2018 •

edited

Loading