Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Final HS60v2 changes. #4790

Merged
merged 5 commits into from
Jan 7, 2019
Merged

Final HS60v2 changes. #4790

merged 5 commits into from
Jan 7, 2019

Conversation

yiancar
Copy link
Contributor

@yiancar yiancar commented Jan 6, 2019

NOTE: This PR includes the STM32 eeprom PR (#4765). please merge them in order or delete the oldest one and only merge this one.

Description

  • HS60v2 keymap updates.
  • Switched to wilba.tech RGB code. (@Wilba6582 has already seen the changes made to his files and agrees)
  • Enable VIA compatibility.
  • Enabled dynamic keymaps.
  • Fixed STM32 EEPROM code

Types of changes

  • Core
  • Bugfix
  • New Feature
  • Enhancement/Optimization
  • Keyboard (addition or update)
  • Keymap/Layout/Userspace (addition or update)
  • Documentation

Issues Fixed or Closed by this PR

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document. (https://docs.qmk.fm/#/contributing)
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

- RGB controls work
- Dynamic keymap still broken due to eeprom
- Via works
- Update EEPROM emulation library to handle 8bit data like AVR.
- This library also allows for multiple page pairs resulting in greater EEPROM size flexibility
@wilba
Copy link
Contributor

wilba commented Jan 6, 2019

👍

keyboards/hs60/v2/config.h Outdated Show resolved Hide resolved
keyboards/hs60/v2/config.h Show resolved Hide resolved
NO_USB_STARTUP_CHECK = no # Disable initialization only when usb is plugged in
#SERIAL_LINK_ENABLE = yes

RAW_ENABLE = yes
DYNAMIC_KEYMAP_ENABLE = yes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this board sold either thru the GB or the associated retailers with VIA? I'm inclined to not have dynamic keymaps enabled by default if it is not in fact, the default.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes after agreeing with @Wilba6582 and @olivia VIA will be the the default configuration method. The next release version (before the units reach the customers) of VIA will include the support.

Copy link
Contributor

@mechmerlin mechmerlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good my yiancar!

@mechmerlin mechmerlin merged commit 2bfac35 into qmk:master Jan 7, 2019
@yiancar yiancar deleted the HS60_WILBA branch January 7, 2019 01:26
Shinichi-Ohki added a commit to Shinichi-Ohki/qmk_firmware that referenced this pull request Jan 10, 2019
* 'master' of https://github.com/qmk/qmk_firmware: (63 commits)
  Keymap: ave-63's iris layout (qmk#4812)
  Update bakingpy 4x12 keymap and add test mode for debugging/development (qmk#4810)
  Fix Mac mute keycode (qmk#4809)
  Add KBD75 keymap (qmk#4808)
  Fix pinout of split hand and LED, remove flip half option
  Tidy up Mod-Tap shortcuts (qmk#4806)
  Add missing parentheses to some important macros (qmk#4775)
  Keyboard: Downbubble refactor and Configurator fix (qmk#4798)
  Alternate keymap for Alpha keyboard, enjoy! (qmk#4797)
  Keymap: Added Model F-inspired layout for YMD[K]96 (qmk#4777)
  Improve consistency in UNICODEMAP code and docs, update docs/understanding_qmk (qmk#4774)
  Update to arm_atsam wait and timer routines
  Add Downbubble to Handwired repository (qmk#4794)
  Final HS60v2 changes. (qmk#4790)
  Keyboard: Fractal layout macro and readme cleanup (qmk#4789)
  Keymap: added my espectro keymap (qmk#4791)
  Keyboard: Numbrero: Configurator fix and code tidy (qmk#4787)
  Keyboard: Tradestation code tidy and readme refactor (qmk#4784)
  Keyboard: update readme with ps2avr flashing instructions (qmk#4776)
  add Pinky keyboard (qmk#4748)
  ...
rseymour pushed a commit to rseymour/qmk_firmware that referenced this pull request Mar 13, 2019
* initial commit, this now mostly works

- RGB controls work
- Dynamic keymap still broken due to eeprom
- Via works

* STM32 eeprom update

- Update EEPROM emulation library to handle 8bit data like AVR.
- This library also allows for multiple page pairs resulting in greater EEPROM size flexibility

* hs60 changes

* HS60 hhkb added

* Update keyboards/hs60/v2/config.h

Co-Authored-By: yiancar <[email protected]>
djthread pushed a commit to djthread/qmk_firmware that referenced this pull request Mar 17, 2019
* initial commit, this now mostly works

- RGB controls work
- Dynamic keymap still broken due to eeprom
- Via works

* STM32 eeprom update

- Update EEPROM emulation library to handle 8bit data like AVR.
- This library also allows for multiple page pairs resulting in greater EEPROM size flexibility

* hs60 changes

* HS60 hhkb added

* Update keyboards/hs60/v2/config.h

Co-Authored-By: yiancar <[email protected]>
dlhextall pushed a commit to dlhextall/qmk_firmware that referenced this pull request May 24, 2019
* initial commit, this now mostly works

- RGB controls work
- Dynamic keymap still broken due to eeprom
- Via works

* STM32 eeprom update

- Update EEPROM emulation library to handle 8bit data like AVR.
- This library also allows for multiple page pairs resulting in greater EEPROM size flexibility

* hs60 changes

* HS60 hhkb added

* Update keyboards/hs60/v2/config.h

Co-Authored-By: yiancar <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants