Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix build_keyboard.mk: LIB_SRC insert position #5731

Merged
merged 1 commit into from
May 3, 2019
Merged

Fix build_keyboard.mk: LIB_SRC insert position #5731

merged 1 commit into from
May 3, 2019

Conversation

mtei
Copy link
Contributor

@mtei mtei commented Apr 28, 2019 •
edited
Loading

Description

The insertion point for $(patsubst %.c,%.clib,$(LIB_SRC)) must be after all normal SRC += .. . I modified it to be so.

Because LIB_SRC and SRC are assumed to be used in pairs. Similarly, QUANTUM_LIB_SRC and QUANTUM_SRC are also assumed to be used in pairs.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@mtei
Fix LIB_SRC insert position
d6832f3 
The insertion point for `$(patsubst %.c,%.clib,$(LIB_SRC))` must be after all normal `SRC += ..` . I modified it to be so.

Because LIB_SRC and SRC are assumed to be used in pairs. Similarly, QUANTUM_LIB_SRC and QUANTUM_SRC are assumed to be used in pairs.
@mtei mtei mentioned this pull request Apr 29, 2019
Merged
12 tasks
noroadsleft
noroadsleft approved these changes Apr 29, 2019
View reviewed changes
Copy link
Member

@noroadsleft noroadsleft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. 👍

mechmerlin
mechmerlin approved these changes May 3, 2019
View reviewed changes
Copy link
Contributor

@mechmerlin mechmerlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@mechmerlin mechmerlin merged commit 29f6845 into qmk:master May 3, 2019
drashna pushed a commit to zsa/qmk_firmware that referenced this pull request May 3, 2019
@mtei @drashna
Fix LIB_SRC insert position (qmk#5731)
19c6b7f 
The insertion point for `$(patsubst %.c,%.clib,$(LIB_SRC))` must be after all normal `SRC += ..` . I modified it to be so.

Because LIB_SRC and SRC are assumed to be used in pairs. Similarly, QUANTUM_LIB_SRC and QUANTUM_SRC are assumed to be used in pairs.
fdidron added a commit to zsa/qmk_firmware that referenced this pull request May 6, 2019
@fdidron
Merge pull request #41 from zsa/fix/lib_src_insert_point
7a136f7 
Fix LIB_SRC insert position (qmk#5731)
foosinn pushed a commit to foosinn/qmk_firmware that referenced this pull request May 6, 2019
@mtei @foosinn
Fix LIB_SRC insert position (qmk#5731)
8166f1c 
The insertion point for `$(patsubst %.c,%.clib,$(LIB_SRC))` must be after all normal `SRC += ..` . I modified it to be so.

Because LIB_SRC and SRC are assumed to be used in pairs. Similarly, QUANTUM_LIB_SRC and QUANTUM_SRC are assumed to be used in pairs.
KauyonKais pushed a commit to KauyonKais/qmk_firmware that referenced this pull request May 8, 2019
@mtei
Fix LIB_SRC insert position (qmk#5731)
b0553c6 
The insertion point for `$(patsubst %.c,%.clib,$(LIB_SRC))` must be after all normal `SRC += ..` . I modified it to be so.

Because LIB_SRC and SRC are assumed to be used in pairs. Similarly, QUANTUM_LIB_SRC and QUANTUM_SRC are assumed to be used in pairs.
KauyonKais pushed a commit to KauyonKais/qmk_firmware that referenced this pull request May 8, 2019
@mtei @KauyonKais
Fix LIB_SRC insert position (qmk#5731)
d6d7c26 
The insertion point for `$(patsubst %.c,%.clib,$(LIB_SRC))` must be after all normal `SRC += ..` . I modified it to be so.

Because LIB_SRC and SRC are assumed to be used in pairs. Similarly, QUANTUM_LIB_SRC and QUANTUM_SRC are assumed to be used in pairs.
@mtei mtei deleted the fix-LIB_SRC-position branch May 11, 2019 06:36
Timbus pushed a commit to Timbus/qmk_firmware that referenced this pull request Jun 23, 2019
@mtei @Timbus
Fix LIB_SRC insert position (qmk#5731)
e01d9ef 
The insertion point for `$(patsubst %.c,%.clib,$(LIB_SRC))` must be after all normal `SRC += ..` . I modified it to be so.

Because LIB_SRC and SRC are assumed to be used in pairs. Similarly, QUANTUM_LIB_SRC and QUANTUM_SRC are assumed to be used in pairs.
ridingqwerty pushed a commit to ridingqwerty/qmk_firmware that referenced this pull request Jan 10, 2020
@mtei @mechmerlin
Fix LIB_SRC insert position (qmk#5731)
c0309c0 
The insertion point for `$(patsubst %.c,%.clib,$(LIB_SRC))` must be after all normal `SRC += ..` . I modified it to be so.

Because LIB_SRC and SRC are assumed to be used in pairs. Similarly, QUANTUM_LIB_SRC and QUANTUM_SRC are assumed to be used in pairs.
JeffreyPalmer pushed a commit to JeffreyPalmer/qmk_firmware that referenced this pull request Feb 27, 2020
@mtei @JeffreyPalmer
Fix LIB_SRC insert position (qmk#5731)
fa198c6 
The insertion point for `$(patsubst %.c,%.clib,$(LIB_SRC))` must be after all normal `SRC += ..` . I modified it to be so.

Because LIB_SRC and SRC are assumed to be used in pairs. Similarly, QUANTUM_LIB_SRC and QUANTUM_SRC are assumed to be used in pairs.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drashna drashna drashna approved these changes

@noroadsleft noroadsleft noroadsleft approved these changes

@mechmerlin mechmerlin mechmerlin approved these changes

@fredizzimo fredizzimo Awaiting requested review from fredizzimo

@algernon algernon Awaiting requested review from algernon

@ezuk ezuk Awaiting requested review from ezuk

@jackhumbert jackhumbert Awaiting requested review from jackhumbert

@skullydazed skullydazed Awaiting requested review from skullydazed

@yanfali yanfali Awaiting requested review from yanfali

Assignees
No one assigned
Labels
awaiting review bug core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mtei @drashna @noroadsleft @mechmerlin