[keymap] Romain's Preonic layout #7067
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RomainGehrig
changed the title
fauxpark
requested changes
Oct 18, 2019
Co-Authored-By: fauxpark <[email protected]>
|
I implemented the changes suggested. Thanks for your review @fauxpark ! |
fauxpark
approved these changes
Oct 18, 2019
noroadsleft
reviewed
Oct 18, 2019
drashna
reviewed
Oct 19, 2019
|
A question for the knowledgeable(s): should I keep the I first tried to remove it before seeing that – oh surprise – the lower layer became the default layer and I fixed it by making the enum values start at 1 but I don't know if it was the right thing to do. |
Yes. |
noroadsleft
requested changes
Oct 20, 2019
Co-Authored-By: noroadsleft <[email protected]>
|
OK, it's done. I think it's as lean as I can make it, thanks for the reviews @fauxpark, @drashna & @noroadsleft ! If you see anything that can be further improved, just let me know. (And also if you have ideas for the key 2nd row from the top, 1st column from the right) |
ripxorip
pushed a commit
to ripxorip/qmk_firmware
that referenced
this pull request
Dec 3, 2019
* Add customized preonic layout * Add a README detailing a bit the differences from the default preonic layout * Apply suggestions from code review Co-Authored-By: fauxpark <[email protected]> * Remove unnecessary end-of-line backslashes * Import fix for startup sound (thanks @drashna) * Remove unnecessary layers and keycodes * Bring back the _QWERTY layer code Co-Authored-By: noroadsleft <[email protected]>
HokieGeek
pushed a commit
to HokieGeek/qmk_firmware
that referenced
this pull request
Feb 21, 2020
* Add customized preonic layout * Add a README detailing a bit the differences from the default preonic layout * Apply suggestions from code review Co-Authored-By: fauxpark <[email protected]> * Remove unnecessary end-of-line backslashes * Import fix for startup sound (thanks @drashna) * Remove unnecessary layers and keycodes * Bring back the _QWERTY layer code Co-Authored-By: noroadsleft <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add the keymap I use daily. There are more info about this mapping in the README.
Types of Changes
Issues Fixed or Closed by This PR
Checklist