Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Xiaomi MK02 #7825

Merged
merged 9 commits into from
Jan 12, 2020
Merged

Xiaomi MK02 #7825

merged 9 commits into from
Jan 12, 2020

Conversation

xyzz
Copy link
Contributor

@xyzz xyzz commented Jan 7, 2020

Description

Add Xiaomi mk02.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@xyzz xyzz changed the title Xiaomi Xiaomi MK02 Jan 7, 2020
@ReVanTis
Copy link

ReVanTis commented Jan 8, 2020

This is amazing work.
USB Type-C with Cherry switches and it supports QMK now?
I'm seriously considering getting one now.

drashna
drashna requested changes Jan 8, 2020
View reviewed changes
keyboards/xiaomi/mk02/config.h Outdated Show resolved Hide resolved
@mechmerlin
Copy link
Contributor

I'm always excited when someone manages to put QMK on a readily available OEM product such as this. Great job! I'm tempted to buy one now, which leads me to my qualm with the PR.

Can you actually provide a direct link to where this is on ali express in the readme or some other stores that are not as difficult to navigate?

noroadsleft
noroadsleft requested changes Jan 9, 2020
View reviewed changes
keyboards/xiaomi/mk02/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/xiaomi/mk02/mk02.h Outdated Show resolved Hide resolved
@xyzz
Copy link
Contributor Author

xyzz commented Jan 9, 2020

@mechmerlin it used to be sold at item.mi.com but now the URL 404s so it might have been discontinued - https://item.mi.com/product/7865.html. It's also listed on aliexpress (a bunch of listings from random sellers) and banggood (https://www.banggood.com/XiaoMi-Yuemi-Pro-MK02-Aluminum-Alloy-87-Keys-NKRO-Cherry-MX-Switch-Detachable-USB-Wired-Mechanical-Keyboard-p-1260387.html) but I'm not sure if these are official which is why I didn't link to them.

@xyzz
Copy link
Contributor Author

xyzz commented Jan 10, 2020

Updated & I've also changed README to point out how to properly flash manually using dfu-util.

@drashna
Copy link
Member

drashna commented Jan 12, 2020

Thanks!

@drashna drashna merged commit 21d6cb1 into qmk:master Jan 12, 2020
nesth pushed a commit to nesth/qmk_firmware that referenced this pull request Jan 12, 2020
Merge branch 'master' of https://github.com/qmk/qmk_firmware
58ce1c3 
* 'master' of https://github.com/qmk/qmk_firmware: (71 commits)
  [Keyboard] Reviung41: Configurator layout support (qmk#7852)
  [Keyboard] IDB 60: Configurator bugfix (qmk#7851)
  [Keyboard] Add Xiaomi MK02 (qmk#7825)
  Add user keymaps for KBD67MKII/Lily58 (qmk#7671)
  [Keyboard] KPRepublic BM60 RGB (qmk#7842)
  Add Lily58 serial to LIB_SRC to avoid LTO issue (qmk#7868)
  Adi's DZ65RGB layout (qmk#7845)
  yapf and style
  Make the udev rules easier to read and manage
  Fix Pro Micro's and its bootloader's name
  CLI: Rework ModemManager check and add udev check
  [Keyboard] NK65 Refactor (qmk#7862)
  [Keymap] Updated keymaps (qmk#7834)
  [Keymap] Add additional dynamic macro key to dshields keymaps. (qmk#7853)
  added ymdk ymd09 keyboard (qmk#7831)
  [Keymap] Update my iris keymap for LTO and rgbled split (qmk#7849)
  [Keyboard] Changes to support latest release of VIA, moved files to "idb" folder in "keymaps" in preparation of adding more boards, made changes to LAYOUT_ macros (qmk#7798)
  Fix a couple of USB VIDs for the API (qmk#7848)
  Add per-key IGNORE_MOD_TAP_INTERRUPT feature (qmk#7838)
  Refactor f103,f072,f042 based keyboards to use new MCU selection defaults (qmk#7705)
  ...
HokieGeek pushed a commit to HokieGeek/qmk_firmware that referenced this pull request Feb 21, 2020
@xyzz @HokieGeek
[Keyboard] Add Xiaomi MK02 (qmk#7825)
2c16b3f 
* [Keyboard] Added xiaomi/mk02

* keyboards/xiaomi/mk02: cleanup

* keyboards/xiaomi/mk02: add linker script

* update readme

* update

* remove via (crashes during startup)

* LAYOUT => LAYOUT_tkl_ansi

* Change vid/pid

* Add a warning to the readme
kylekuj pushed a commit to kylekuj/qmk_firmware that referenced this pull request Apr 21, 2020
@xyzz @kujawakk
[Keyboard] Add Xiaomi MK02 (qmk#7825)
0bb9805 
* [Keyboard] Added xiaomi/mk02

* keyboards/xiaomi/mk02: cleanup

* keyboards/xiaomi/mk02: add linker script

* update readme

* update

* remove via (crashes during startup)

* LAYOUT => LAYOUT_tkl_ansi

* Change vid/pid

* Add a warning to the readme
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drashna drashna drashna approved these changes

@noroadsleft noroadsleft noroadsleft approved these changes

Assignees
No one assigned
Labels
keyboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@xyzz @ReVanTis @mechmerlin @drashna @noroadsleft