Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweak my TAPPING_TERM and be more futureproof #8143

Merged
merged 2 commits into from
Feb 11, 2020
Merged

Tweak my TAPPING_TERM and be more futureproof #8143

merged 2 commits into from
Feb 11, 2020

Conversation

bcat
Copy link
Contributor

@bcat bcat commented Feb 11, 2020

Description

I'm reducing my TAPPING_TERM back to the default (200 ms) to try and combat spurious Esc keypresses on an Esc (tap)/Ctrl (hold) key. It turns out my real issue before was the Lily58 keyboard sets it to super short (100 ms) by default. :) I'm also explicitly #undefing some symbols I redefine in keymap configs so I don't cause problems if the keyboards start defining those things in the future (e.g., #7754).

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

None

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@drashna drashna added the keymap label Feb 11, 2020
@drashna drashna requested a review from a team February 11, 2020 02:11
@zvecr
Copy link
Member

zvecr commented Feb 11, 2020

Thanks!

@zvecr zvecr merged commit 1fed214 into qmk:master Feb 11, 2020
@bcat bcat deleted the bcat_keebs branch February 11, 2020 18:24
HokieGeek pushed a commit to HokieGeek/qmk_firmware that referenced this pull request Feb 21, 2020
* Explicitly undef things I override in keymaps

* Reduce TAPPING_TERM back to default
c0psrul3 pushed a commit to c0psrul3/qmk_firmware that referenced this pull request Mar 23, 2020
* Explicitly undef things I override in keymaps

* Reduce TAPPING_TERM back to default
kylekuj pushed a commit to kylekuj/qmk_firmware that referenced this pull request Apr 21, 2020
* Explicitly undef things I override in keymaps

* Reduce TAPPING_TERM back to default
jakeisnt pushed a commit to jakeisnt/qmk_firmware that referenced this pull request Aug 20, 2020
* Explicitly undef things I override in keymaps

* Reduce TAPPING_TERM back to default
BorisTestov pushed a commit to BorisTestov/qmk_firmware that referenced this pull request May 23, 2024
* Explicitly undef things I override in keymaps

* Reduce TAPPING_TERM back to default
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants