Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce Helix keyboard build variation #8669

Merged
merged 16 commits into from
Oct 25, 2020

Conversation

MakotoKurauchi
Copy link
Contributor

Description

There are many build variation for the current Helix keyboard. It was a little too much, so I chose patterns that users often use and reduced the unnecessary ones.

This change does not change the build results.

All compile option patterns (click)
  • build helix/pico (HelixPico) with helix current codes

    $ make helix/pico:KEY_MAP
    $ make helix/pico/back:KEY_MAP
    $ make helix/pico/under:KEY_MAP
    
  • build helix/rev2 (Helix or Helix beta) with helix current codes
    Allways OLED enable.

    $ make helix:KEY_MAP
    $ make helix/rev2/back:KEY_MAP
    $ make helix/rev2/under:KEY_MAP
    
  • build helix/pico (HelixPico) with split_common codes
    RGBlight as backlight enable.

    $ make helix/pico/split_common:KEY_MAP
    
  • build helix/rev2 (Helix) with split_common codes
    OLED and RGBlight as backlight enable.

    $ make helix/rev2/split_common:KEY_MAP
    
Comparison of old and new (click)
build name in the previous version build name in the new version
helix/rev1 helix/rev1
helix/pico helix/pico
helix/pico/back helix/pico/back
helix/pico/under helix/pico/under
helix/pico/sc --
helix/pico/sc/back helix/pico/split_common
helix/pico/sc/under --
helix/rev2 (=helix) --
helix/rev2/back --
helix/rev2/back/oled --
helix/rev2/oled helix/rev2 (=helix)
helix/rev2/oled/back helix/rev2/back
helix/rev2/oled/under helix/rev2/under
helix/rev2/sc --
helix/rev2/sc/back --
helix/rev2/sc/oled --
helix/rev2/sc/oledback helix/rev2/split_common
helix/rev2/sc/oledunder --
helix/rev2/sc/under --
helix/rev2/under --
helix/rev2/under/oled --

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

mtei and others added 7 commits April 2, 2020 19:46
| name in the previous version | name in the new version |
| ---------------------------- | ------------------------|
| helix/rev1                   | helix/rev1              |
| helix/pico                   | helix/pico              |
| helix/pico/back              | helix/pico/back         |
| helix/pico/under             | helix/pico/under        |
| helix/pico/sc                | --                      |
| helix/pico/sc/back           | helix/pico/split_common |
| helix/pico/sc/under          | --                      |
| helix/rev2 (=helix)          | --                      |
| helix/rev2/back              | --                      |
| helix/rev2/back/oled         | --                      |
| helix/rev2/oled              | helix/rev2 (=helix)    |
| helix/rev2/oled/back         | helix/rev2/back         |
| helix/rev2/oled/under        | helix/rev2/under        |
| helix/rev2/sc                | --                      |
| helix/rev2/sc/back           | --                      |
| helix/rev2/sc/oled           | --                      |
| helix/rev2/sc/oledback       | helix/rev2/split_common |
| helix/rev2/sc/oledunder      | --                      |
| helix/rev2/sc/under          | --                      |
| helix/rev2/under             | --                      |
| helix/rev2/under/oled        | --                      |
… post-processing

**Compilation result does not change**
This reverts commit 6229ed41f2ff8bac52015150837eaa51d9815e13.
Reduce Helix keyboard build variation
@mtei mtei requested a review from a team April 4, 2020 06:37
@mtei mtei added the keyboard label Apr 4, 2020
@mtei mtei requested a review from a team April 4, 2020 07:15
@drashna drashna requested a review from a team April 24, 2020 23:12
Copy link
Member

@zvecr zvecr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given there are no metrics on if these targets are actually being used by end users, and recent stances on other PRs, removing build targets seems like it would require the breaking change process.

Edit: there was a +1 on Discord, so I have added the label while we discus.

@zvecr zvecr added the breaking_change Changes that need to wait for a version increment label Apr 25, 2020
@mtei
Copy link
Contributor

mtei commented Apr 25, 2020

It's only recently that build variations have increased. The purpose of this PR is to sift through the build variants that were added too much in #7718 and only scrape out the useful ones.

(I'll explain more about the history later if require.)

Does this require the breaking change process? I don't think so.

before #6952 881f27b #6952 Oct 17 2019 2d14d12 #7718 Mar 10 2020 this PR
---- Six months before this PR. Three weeks before this PR. ----
helix/rev1 helix/rev1 helix/rev1 helix/rev1
helix/pico helix/pico helix/pico helix/pico
helix/pico/back helix/pico/back helix/pico/back
helix/pico/under helix/pico/under helix/pico/under
helix/pico/sc --
helix/pico/sc/back helix/pico/split_common helix/pico/sc
helix/pico/sc/under --
helix/rev2 (=helix) helix/rev2 (=helix) helix/rev2 (=helix) --
helix/rev2/back helix/rev2/back --
helix/rev2/back/oled helix/rev2/back/oled ( --> helix/rev2/back)
helix/rev2/oled helix/rev2/oled helix/rev2 (=helix)
helix/rev2/oled/back helix/rev2/oled/back helix/rev2/back
helix/rev2/oled/under helix/rev2/oled/under helix/rev2/under
helix/rev2/sc --
helix/rev2/sc/back --
helix/rev2/sc/oled --
helix/rev2/sc/oledback helix/rev2/split_common helix/rev2/sc
helix/rev2/sc/oledunder --
helix/rev2/sc/under --
helix/rev2/under helix/rev2/under --
helix/rev2/under/oled helix/rev2/under/oled ( --> helix/rev2/under)

@zvecr
Copy link
Member

zvecr commented Apr 25, 2020

The what and why of this PR is not where the issue lies, that part is fairly obvious from the diffs.

The issue is that if a end user was previously building with helix/pico/sc, there is no indication that they now have to build with helix/pico/split_common instead. CLI build alias was an idea that could work round this issue in the short term, however it has not been implemented yet.

We have a fair few PRs in this state now, this one should not be treated any differently.

@mtei
Copy link
Contributor

mtei commented Apr 25, 2020

Are you saying that the renaming of pico/sc to pico/split_common is a bad idea? Is it better to stop renaming pico/sc? If so, I will stop the name change.
(and rev2/split_common, rev2/sc)

Or does it mean it's not good that the target that existed is no longer there? (For example, rev2/oled/back has been changed to rev2/back.)

@mtei
Copy link
Contributor

mtei commented Apr 26, 2020

Don't overlook that there are only three weeks between the merging of the last version (#7718) and the opening of this PR. This PR is effectively a bug fix for the previous version.

The readme.md explains that helix/rev2/sc and helix/pico/sc are (experimental use of split_common). Users would normally avoid using this target.

@noroadsleft
Copy link
Member

Checking if I understand correctly what this PR does if merged:

  • helix/rev1 = unchanged
  • helix/pico/sc, helix/pico/sc/back and helix/pico/sc/under are now together under helix/pico/sc, and the user changes the make command based on what options they want (LED backlight or LED underglow).
    • The non-split_common helix/pico variants are unchanged
  • helix/rev2 - OLED enabled becomes default for both split_common and non-split_common variants. Further build targets configure whether LED backlight or LED underglow is enabled, similarly to helix/pico

Do I have this right?

@mtei
Copy link
Contributor

mtei commented May 7, 2020

  • helix/rev1 = unchanged

Yes.

  • helix/pico/sc, helix/pico/sc/back and helix/pico/sc/under are now together under helix/pico/sc, and the user changes the make command based on what options they want (LED backlight or LED underglow).

The split_common helix/pico/sc variants are experimental targets that were added at the time of #7718. Since it's experimental, MakotoKurauchi and I have yet to recommend it to the average user. That's why we reduced the variations.

We reduced the variation of split_common helix/rev2/sc for the same reason.

It is clearly stated in the documentation that helix/XX/sc is an experimental set of targets.

  • The non-split_common helix/pico variants are unchanged

Yes.

  • helix/rev2 - OLED enabled becomes default for both split_common and non-split_common variants. Further build targets configure whether LED backlight or LED underglow is enabled, similarly to helix/pico

Yes. MakotoKurauchi's shop sells the Helix kit with OLED included as standard. That's why we've made OLED enable the default.

@noroadsleft
Copy link
Member

Thanks, @mtei. I've spent quite some time (many months) mostly working on Configurator, so I don't remember my way around makefiles anymore. :/

@Erovia
Copy link
Member

Erovia commented Jun 21, 2020

@MakotoKurauchi, @mtei what do you think about retargeting this PR to the develop branch and getting it merged there first?

@MakotoKurauchi MakotoKurauchi changed the base branch from master to develop October 24, 2020 09:10
@github-actions github-actions bot added the CI label Oct 24, 2020
@mtei mtei merged commit f584ac7 into qmk:develop Oct 25, 2020
skullydazed pushed a commit that referenced this pull request Oct 28, 2020
* modify helix config. 'helix/rev2' always OLED on

* reduce helix build variation pattern

* helix/rev2/keymaps/xulkal/rules.mk: Explicitly disable helix standard post-processing

**Compilation result does not change**

* helix readmes update

* add temporary test script

* test end. -- Revert "add temporary test script"

This reverts commit 6229ed41f2ff8bac52015150837eaa51d9815e13.

* rename rev2/split_common/rules.mk -> rev2/sc/rules.mk

* rename pico/split_common/rules.mk -> pico/sc/rules.mk

* update keymaps/default/reademe.md

* add 'helix/pico/qmk_conf' and 'helix/rev2/qmk_conf' target

* add ChangeLog for Helix: PR 8669

* fix helix/pico/qmk_conf compile error

Co-authored-by: mtei <[email protected]>
noroadsleft pushed a commit that referenced this pull request Oct 30, 2020
* modify helix config. 'helix/rev2' always OLED on

* reduce helix build variation pattern

* helix/rev2/keymaps/xulkal/rules.mk: Explicitly disable helix standard post-processing

**Compilation result does not change**

* helix readmes update

* add temporary test script

* test end. -- Revert "add temporary test script"

This reverts commit 6229ed41f2ff8bac52015150837eaa51d9815e13.

* rename rev2/split_common/rules.mk -> rev2/sc/rules.mk

* rename pico/split_common/rules.mk -> pico/sc/rules.mk

* update keymaps/default/reademe.md

* add 'helix/pico/qmk_conf' and 'helix/rev2/qmk_conf' target

* add ChangeLog for Helix: PR 8669

* fix helix/pico/qmk_conf compile error

Co-authored-by: mtei <[email protected]>
noroadsleft added a commit that referenced this pull request Nov 28, 2020
* Branch point for 2020 November 28 Breaking Change                                                

* Remove matrix_col_t to allow MATRIX_ROWS > 32 (#10183)                                           

* Add support for soft serial to ATmega32U2 (#10204)                                               

* Change MIDI velocity implementation to allow direct control of velocity value (#9940)            

* Add ability to build a subset of all keyboards based on platform.                                

* Actually use eeprom_driver_init().                                                               

* Make bootloader_jump weak for ChibiOS. (#10417)                                                  

* Joystick 16-bit support (#10439)                                                                 

* Per-encoder resolutions (#10259)                                                                 

* Share button state from mousekey to pointing_device (#10179)                                     

* Add hotfix for chibios keyboards not wake (#10088)                                               

* Add advanced/efficient RGB Matrix Indicators (#8564)                                             

* Naming change.                                                                                   

* Support for STM32 GPIOF,G,H,I,J,K (#10206)                                                       

* Add milc as a dependency and remove the installed milc (#10563)                                  

* ChibiOS upgrade: early init conversions (#10214)                                                 

* ChibiOS upgrade: configuration file migrator (#9952)                                             

* Haptic and solenoid cleanup (#9700)                                                              

* XD75 cleanup (#10524)                                                                            

* OLED display update interval support (#10388)                                                    

* Add definition based on currently-selected serial driver. (#10716)                               

* New feature: Retro Tapping per key (#10622)                                                      

* Allow for modification of output RGB values when using rgblight/rgb_matrix. (#10638)             

* Add housekeeping task callbacks so that keyboards/keymaps are capable of executing code for each main loop iteration. (#10530)

* Rescale both ChibiOS and AVR backlighting.                                                       

* Reduce Helix keyboard build variation (#8669)                                                    

* Minor change to behavior allowing display updates to continue between task ticks (#10750)        

* Some GPIO manipulations in matrix.c change to atomic. (#10491)                                   

* qmk cformat (#10767)                                                                             

* [Keyboard] Update the Speedo firmware for v3.0 (#10657)                                          

* Maartenwut/Maarten namechange to evyd13/Evy (#10274)                                             

* [quantum] combine repeated lines of code (#10837)                                                

* Add step sequencer feature (#9703)                                                               

* aeboards/ext65 refactor (#10820)                                                                 

* Refactor xelus/dawn60 for Rev2 later (#10584)                                                    

* add DEBUG_MATRIX_SCAN_RATE_ENABLE to common_features.mk (#10824)                                 

* [Core] Added `add_oneshot_mods` & `del_oneshot_mods` (#10549)                                    

* update chibios os usb for the otg driver (#8893)                                                 

* Remove HD44780 References, Part 4 (#10735)                                                       

* [Keyboard] Add Valor FRL TKL (+refactor) (#10512)                                                

* Fix cursor position bug in oled_write_raw functions (#10800)                                     

* Fixup version.h writing when using SKIP_VERSION=yes (#10972)                                     

* Allow for certain code in the codebase assuming length of string. (#10974)                       

* Add AT90USB support for serial.c (#10706)                                                        

* Auto shift: support repeats and early registration (#9826)                                       

* Rename ledmatrix.h to match .c file (#7949)                                                      

* Split RGB_MATRIX_ENABLE into _ENABLE and _DRIVER (#10231)                                        

* Split LED_MATRIX_ENABLE into _ENABLE and _DRIVER (#10840)                                        

* Merge point for 2020 Nov 28 Breaking Change
mtei added a commit to mtei/qmk_configurator that referenced this pull request Dec 3, 2020
Could not compile 'helix/rev2' and 'helix/pico' on qmk configurator. As a workaround, we added the following targets.

* helix_pico_qmk_conf_default.json
* helix_rev2_qmk_conf_default.json

The following targets cannot be compiled on qmk configurator, so they are deleted.

* helix_pico_default.json
* helix_pico_back_default.json
* helix_pico_under_default.json
* helix_rev2_default.json
* helix_rev2_back_default.json
* helix_rev2_under_default.json
* helix_rev2_sc_default.json

The following targets have been removed in qmk/qmk_firmware#8669.

* helix_rev2_back_oled_default.json
* helix_rev2_oled_back_default.json
* helix_rev2_oled_default.json
* helix_rev2_oled_under_default.json
* helix_rev2_sc_back_default.json
* helix_rev2_sc_oled_default.json
* helix_rev2_sc_oledback_default.json
* helix_rev2_sc_oledunder_default.json
* helix_rev2_sc_under_default.json
* helix_rev2_under_oled_default.json
noroadsleft pushed a commit to qmk/qmk_configurator that referenced this pull request Dec 8, 2020
Could not compile 'helix/rev2' and 'helix/pico' on qmk configurator. As a workaround, we added the following targets.

* helix_pico_qmk_conf_default.json
* helix_rev2_qmk_conf_default.json

The following targets cannot be compiled on qmk configurator, so they are deleted.

* helix_pico_default.json
* helix_pico_back_default.json
* helix_pico_under_default.json
* helix_rev2_default.json
* helix_rev2_back_default.json
* helix_rev2_under_default.json
* helix_rev2_sc_default.json

The following targets have been removed in qmk/qmk_firmware#8669.

* helix_rev2_back_oled_default.json
* helix_rev2_oled_back_default.json
* helix_rev2_oled_default.json
* helix_rev2_oled_under_default.json
* helix_rev2_sc_back_default.json
* helix_rev2_sc_oled_default.json
* helix_rev2_sc_oledback_default.json
* helix_rev2_sc_oledunder_default.json
* helix_rev2_sc_under_default.json
* helix_rev2_under_oled_default.json
xgnxs pushed a commit to xgnxs/qmk_firmware that referenced this pull request Jan 9, 2021
* Branch point for 2020 November 28 Breaking Change                                                

* Remove matrix_col_t to allow MATRIX_ROWS > 32 (qmk#10183)                                           

* Add support for soft serial to ATmega32U2 (qmk#10204)                                               

* Change MIDI velocity implementation to allow direct control of velocity value (qmk#9940)            

* Add ability to build a subset of all keyboards based on platform.                                

* Actually use eeprom_driver_init().                                                               

* Make bootloader_jump weak for ChibiOS. (qmk#10417)                                                  

* Joystick 16-bit support (qmk#10439)                                                                 

* Per-encoder resolutions (qmk#10259)                                                                 

* Share button state from mousekey to pointing_device (qmk#10179)                                     

* Add hotfix for chibios keyboards not wake (qmk#10088)                                               

* Add advanced/efficient RGB Matrix Indicators (qmk#8564)                                             

* Naming change.                                                                                   

* Support for STM32 GPIOF,G,H,I,J,K (qmk#10206)                                                       

* Add milc as a dependency and remove the installed milc (qmk#10563)                                  

* ChibiOS upgrade: early init conversions (qmk#10214)                                                 

* ChibiOS upgrade: configuration file migrator (qmk#9952)                                             

* Haptic and solenoid cleanup (qmk#9700)                                                              

* XD75 cleanup (qmk#10524)                                                                            

* OLED display update interval support (qmk#10388)                                                    

* Add definition based on currently-selected serial driver. (qmk#10716)                               

* New feature: Retro Tapping per key (qmk#10622)                                                      

* Allow for modification of output RGB values when using rgblight/rgb_matrix. (qmk#10638)             

* Add housekeeping task callbacks so that keyboards/keymaps are capable of executing code for each main loop iteration. (qmk#10530)

* Rescale both ChibiOS and AVR backlighting.                                                       

* Reduce Helix keyboard build variation (qmk#8669)                                                    

* Minor change to behavior allowing display updates to continue between task ticks (qmk#10750)        

* Some GPIO manipulations in matrix.c change to atomic. (qmk#10491)                                   

* qmk cformat (qmk#10767)                                                                             

* [Keyboard] Update the Speedo firmware for v3.0 (qmk#10657)                                          

* Maartenwut/Maarten namechange to evyd13/Evy (qmk#10274)                                             

* [quantum] combine repeated lines of code (qmk#10837)                                                

* Add step sequencer feature (qmk#9703)                                                               

* aeboards/ext65 refactor (qmk#10820)                                                                 

* Refactor xelus/dawn60 for Rev2 later (qmk#10584)                                                    

* add DEBUG_MATRIX_SCAN_RATE_ENABLE to common_features.mk (qmk#10824)                                 

* [Core] Added `add_oneshot_mods` & `del_oneshot_mods` (qmk#10549)                                    

* update chibios os usb for the otg driver (qmk#8893)                                                 

* Remove HD44780 References, Part 4 (qmk#10735)                                                       

* [Keyboard] Add Valor FRL TKL (+refactor) (qmk#10512)                                                

* Fix cursor position bug in oled_write_raw functions (qmk#10800)                                     

* Fixup version.h writing when using SKIP_VERSION=yes (qmk#10972)                                     

* Allow for certain code in the codebase assuming length of string. (qmk#10974)                       

* Add AT90USB support for serial.c (qmk#10706)                                                        

* Auto shift: support repeats and early registration (qmk#9826)                                       

* Rename ledmatrix.h to match .c file (qmk#7949)                                                      

* Split RGB_MATRIX_ENABLE into _ENABLE and _DRIVER (qmk#10231)                                        

* Split LED_MATRIX_ENABLE into _ENABLE and _DRIVER (qmk#10840)                                        

* Merge point for 2020 Nov 28 Breaking Change
drashna pushed a commit to zsa/qmk_firmware that referenced this pull request Jan 13, 2021
* Branch point for 2020 November 28 Breaking Change

* Remove matrix_col_t to allow MATRIX_ROWS > 32 (qmk#10183)

* Add support for soft serial to ATmega32U2 (qmk#10204)

* Change MIDI velocity implementation to allow direct control of velocity value (qmk#9940)

* Add ability to build a subset of all keyboards based on platform.

* Actually use eeprom_driver_init().

* Make bootloader_jump weak for ChibiOS. (qmk#10417)

* Joystick 16-bit support (qmk#10439)

* Per-encoder resolutions (qmk#10259)

* Share button state from mousekey to pointing_device (qmk#10179)

* Add hotfix for chibios keyboards not wake (qmk#10088)

* Add advanced/efficient RGB Matrix Indicators (qmk#8564)

* Naming change.

* Support for STM32 GPIOF,G,H,I,J,K (qmk#10206)

* Add milc as a dependency and remove the installed milc (qmk#10563)

* ChibiOS upgrade: early init conversions (qmk#10214)

* ChibiOS upgrade: configuration file migrator (qmk#9952)

* Haptic and solenoid cleanup (qmk#9700)

* XD75 cleanup (qmk#10524)

* OLED display update interval support (qmk#10388)

* Add definition based on currently-selected serial driver. (qmk#10716)

* New feature: Retro Tapping per key (qmk#10622)

* Allow for modification of output RGB values when using rgblight/rgb_matrix. (qmk#10638)

* Add housekeeping task callbacks so that keyboards/keymaps are capable of executing code for each main loop iteration. (qmk#10530)

* Rescale both ChibiOS and AVR backlighting.

* Reduce Helix keyboard build variation (qmk#8669)

* Minor change to behavior allowing display updates to continue between task ticks (qmk#10750)

* Some GPIO manipulations in matrix.c change to atomic. (qmk#10491)

* qmk cformat (qmk#10767)

* [Keyboard] Update the Speedo firmware for v3.0 (qmk#10657)

* Maartenwut/Maarten namechange to evyd13/Evy (qmk#10274)

* [quantum] combine repeated lines of code (qmk#10837)

* Add step sequencer feature (qmk#9703)

* aeboards/ext65 refactor (qmk#10820)

* Refactor xelus/dawn60 for Rev2 later (qmk#10584)

* add DEBUG_MATRIX_SCAN_RATE_ENABLE to common_features.mk (qmk#10824)

* [Core] Added `add_oneshot_mods` & `del_oneshot_mods` (qmk#10549)

* update chibios os usb for the otg driver (qmk#8893)

* Remove HD44780 References, Part 4 (qmk#10735)

* [Keyboard] Add Valor FRL TKL (+refactor) (qmk#10512)

* Fix cursor position bug in oled_write_raw functions (qmk#10800)

* Fixup version.h writing when using SKIP_VERSION=yes (qmk#10972)

* Allow for certain code in the codebase assuming length of string. (qmk#10974)

* Add AT90USB support for serial.c (qmk#10706)

* Auto shift: support repeats and early registration (qmk#9826)

* Rename ledmatrix.h to match .c file (qmk#7949)

* Split RGB_MATRIX_ENABLE into _ENABLE and _DRIVER (qmk#10231)

* Split LED_MATRIX_ENABLE into _ENABLE and _DRIVER (qmk#10840)

* Merge point for 2020 Nov 28 Breaking Change
BorisTestov pushed a commit to BorisTestov/qmk_firmware that referenced this pull request May 23, 2024
* Branch point for 2020 November 28 Breaking Change                                                

* Remove matrix_col_t to allow MATRIX_ROWS > 32 (qmk#10183)                                           

* Add support for soft serial to ATmega32U2 (qmk#10204)                                               

* Change MIDI velocity implementation to allow direct control of velocity value (qmk#9940)            

* Add ability to build a subset of all keyboards based on platform.                                

* Actually use eeprom_driver_init().                                                               

* Make bootloader_jump weak for ChibiOS. (qmk#10417)                                                  

* Joystick 16-bit support (qmk#10439)                                                                 

* Per-encoder resolutions (qmk#10259)                                                                 

* Share button state from mousekey to pointing_device (qmk#10179)                                     

* Add hotfix for chibios keyboards not wake (qmk#10088)                                               

* Add advanced/efficient RGB Matrix Indicators (qmk#8564)                                             

* Naming change.                                                                                   

* Support for STM32 GPIOF,G,H,I,J,K (qmk#10206)                                                       

* Add milc as a dependency and remove the installed milc (qmk#10563)                                  

* ChibiOS upgrade: early init conversions (qmk#10214)                                                 

* ChibiOS upgrade: configuration file migrator (qmk#9952)                                             

* Haptic and solenoid cleanup (qmk#9700)                                                              

* XD75 cleanup (qmk#10524)                                                                            

* OLED display update interval support (qmk#10388)                                                    

* Add definition based on currently-selected serial driver. (qmk#10716)                               

* New feature: Retro Tapping per key (qmk#10622)                                                      

* Allow for modification of output RGB values when using rgblight/rgb_matrix. (qmk#10638)             

* Add housekeeping task callbacks so that keyboards/keymaps are capable of executing code for each main loop iteration. (qmk#10530)

* Rescale both ChibiOS and AVR backlighting.                                                       

* Reduce Helix keyboard build variation (qmk#8669)                                                    

* Minor change to behavior allowing display updates to continue between task ticks (qmk#10750)        

* Some GPIO manipulations in matrix.c change to atomic. (qmk#10491)                                   

* qmk cformat (qmk#10767)                                                                             

* [Keyboard] Update the Speedo firmware for v3.0 (qmk#10657)                                          

* Maartenwut/Maarten namechange to evyd13/Evy (qmk#10274)                                             

* [quantum] combine repeated lines of code (qmk#10837)                                                

* Add step sequencer feature (qmk#9703)                                                               

* aeboards/ext65 refactor (qmk#10820)                                                                 

* Refactor xelus/dawn60 for Rev2 later (qmk#10584)                                                    

* add DEBUG_MATRIX_SCAN_RATE_ENABLE to common_features.mk (qmk#10824)                                 

* [Core] Added `add_oneshot_mods` & `del_oneshot_mods` (qmk#10549)                                    

* update chibios os usb for the otg driver (qmk#8893)                                                 

* Remove HD44780 References, Part 4 (qmk#10735)                                                       

* [Keyboard] Add Valor FRL TKL (+refactor) (qmk#10512)                                                

* Fix cursor position bug in oled_write_raw functions (qmk#10800)                                     

* Fixup version.h writing when using SKIP_VERSION=yes (qmk#10972)                                     

* Allow for certain code in the codebase assuming length of string. (qmk#10974)                       

* Add AT90USB support for serial.c (qmk#10706)                                                        

* Auto shift: support repeats and early registration (qmk#9826)                                       

* Rename ledmatrix.h to match .c file (qmk#7949)                                                      

* Split RGB_MATRIX_ENABLE into _ENABLE and _DRIVER (qmk#10231)                                        

* Split LED_MATRIX_ENABLE into _ENABLE and _DRIVER (qmk#10840)                                        

* Merge point for 2020 Nov 28 Breaking Change
BorisTestov pushed a commit to BorisTestov/qmk_firmware that referenced this pull request May 23, 2024
* modify helix config. 'helix/rev2' always OLED on

* reduce helix build variation pattern

* helix/rev2/keymaps/xulkal/rules.mk: Explicitly disable helix standard post-processing

**Compilation result does not change**

* helix readmes update

* add temporary test script

* test end. -- Revert "add temporary test script"

This reverts commit 6229ed41f2ff8bac52015150837eaa51d9815e13.

* rename rev2/split_common/rules.mk -> rev2/sc/rules.mk

* rename pico/split_common/rules.mk -> pico/sc/rules.mk

* update keymaps/default/reademe.md

* add 'helix/pico/qmk_conf' and 'helix/rev2/qmk_conf' target

* add ChangeLog for Helix: PR 8669

* fix helix/pico/qmk_conf compile error

Co-authored-by: mtei <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking_change Changes that need to wait for a version increment documentation keyboard keymap
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants