Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a <FEATURE>_SUPPORTED flag #9058

Merged
merged 6 commits into from
Jan 30, 2021
Merged

Add a <FEATURE>_SUPPORTED flag #9058

merged 6 commits into from
Jan 30, 2021

Conversation

skullydazed
Copy link
Member

This PR will allow a keyboard to exclude hardware it does not support.

Description

Currently we use <FEATURE>_ENABLED in rules.mk to turn support for a feature on and off. We also check the status of that variable to determine whether or that feature is in use. This presents a problem when community layouts and/or userspace use rules.mk to turn this feature on, as described in Example 2 on #8422.

This addresses that problem by allowing keyboards to set <FEATURE>_SUPPORTED variables. When set to no that feature will be disabled after all rules.mk processing has completed.

Types of Changes

  • Core
  • Enhancement/optimization
  • Documentation

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@mtei
Copy link
Contributor

mtei commented May 11, 2020

It seems to be more maintainable to use foreach as follows.

# sample Makefile

## test data
AA_SUPPORTED = yes
BB_SUPPORTED = yes
CC_SUPPORTED = no

AA_FEATURE = yes # comment
BB_FEATURE = yes # comment
CC_FEATURE = yes # comment
## end of test data

# feature list
FEATURE_NAMES :=
FEATURE_NAMES += AA
FEATURE_NAMES += BB
FEATURE_NAMES += CC

# ???_SUPPORTED apply
$(foreach AFEATURE,$(FEATURE_NAMES),\
 $(if $(filter $($(AFEATURE)_SUPPORTED),no),$(eval $(AFEATURE)_FEATURE=no)))

all:
	@echo AA_FEATURE=$(AA_FEATURE)
	@echo BB_FEATURE=$(BB_FEATURE)
	@echo CC_FEATURE=$(CC_FEATURE)

@vomindoraan
Copy link
Contributor

vomindoraan commented May 12, 2020

In #2046 (comment) you wrote:

We think most of the use cases for this feature are addressed by #9058. The big open question right now is what use cases are not addressed by that PR.

The main use case for that PR, at least for me, is being able to have a set of default <FEATURE>_ENABLE flags in my userspace rules.mk, which I can then override on a per-keymap basis (just like how the config.h hierarchy works) — while at the same time having the ability to conditionally include source files from my userspace if certain feature flags are set.

These two requirements are at odds with each other with the current architecture of having just rules.mk files. This is because the former requires userspace rules to be processed before keymap rules, and the latter requires them to be processed afterwards. It's therefore not currently possible to do what I described, so the common idiom that everyone uses is to keep the conditional includes in the userspace rules.mk, and copy-paste most or all of the feature flags between keymap rules.mk files — not ideal.

This is why adding a new class of makefiles to the build pipeline makes sense to me. These new makefiles would be set to run after all rules.mk are processed (a suitable name would be post_rules.mk, for analogy with post_config.h), and userspace rules would be moved to run before keymap rules so it's consistent with how config.h files behave. This is the ideal scenario.

I apologize if any of the above is stating the obvious, I just wanted to collect all of my thoughts on this matter in one place, for my own sake as well as for posterity.


Now, on to the solution proposed in this PR. While it does not address the issue described above, I do believe that it could be a step in the right direction. On its own, though, it has a problem, in that it isn't entirely in line with what was described in #8422 (comment):

Features should degrade gracefully if a keymap uses a feature a keyboard can't support.

If I have RGBLIGHT_ENABLE = yes in my userspace (or keymap), and I conditionally include a source file based on this flag, even if the keyboard sets RGBLIGHT_SUPPORTED = no, the source file will still be included (and likely error out during compilation). Having post_rules.mk alongside this change would avoid the issue, as the condition would only be checked after all of the feature flags had been resolved. ¬SUPPORTED would override ENABLED, and so the source file wouldn't be included.

However, in such a case, RGBLIGHT_ENABLE = no in the keymap rules.mk file would also work, and it would also override the userspace RGBLIGHT_ENABLE = yes (since userspace rules would be processed before keymap rules in the pipeline, as per my above description). So <FEATURE>_SUPPORTED may not be required at all, at least not for this use case.

@@ -290,6 +290,9 @@ ifneq ("$(wildcard $(USER_PATH)/config.h)","")
CONFIG_H += $(USER_PATH)/config.h
endif

# Disable features that a keyboard doesn't support
-include disable_features.mk
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should probably be moved to before the userspace code here, so that the changes are applied before the userspace checks.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've been thinking about this but I don't see why. Can you expand on your thinking here?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As mentioned earlier, this currently doesn't disable the feature before the userspace rules.mk file is processed. This is problematic because that file will see the feature as enabled, even though the keyboard has flagged it as not supported.

Consider the following code in a userspace rules.mk file:

ifeq ($(strip $(BACKLIGHT_ENABLE)), yes)
    SRC += my_backlight.c
endif

If BACKLIGHT_ENABLE = yes is set in this user's community layout and/or userspace, my_backlight.c will be included and compiled even if the keyboard declares BACKLIGHT_SUPPORTED = no.

Drashna's suggestion of moving this line before the userspace code fixes this problem.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could that be solved by incorporating this into your logic?

ifneq ($(strip $(BACKLIGHT_SUPPORTED)), no)

Copy link
Contributor

@vomindoraan vomindoraan May 12, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it works when the check is changed to:

ifneq ($(strip $(BACKLIGHT_SUPPORTED)), no)
    ifeq ($(strip $(BACKLIGHT_ENABLE)), yes)
        SRC += my_backlight.c
    endif
endif
# ifeq (,$(filter no,$(BACKLIGHT_SUPPORTED) $(BACKLIGHT_ENABLE))) would work too

Is this something that you think would be worth doing for all similar checks moving forward? Or is the idea that <FEATURE>_SUPPORTED should automatically (and correctly) work with existing code that relies on just <FEATURE>_ENABLED?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure I'm ready to make that call yet, right now I'm gathering data. This does seem like a potential solution for at least some use cases.

Copy link
Contributor

@vomindoraan vomindoraan May 13, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see #9070 (comment) for another potential solution.

@drashna
Copy link
Member

drashna commented May 12, 2020

To be honest, I'm hard pressed to find a situation WRT keymaps and userspace that isn't served by the current configuration.

But part of that, is that I feel that hardware settings should NOT be set in the userspace, for any reason. It's generic configuration, and the workflow for it isn't really equipped/set up to handle that.

You use RGBLIGHT_ENABLE as an example here... and ... that was my first goto for examples for documentation. Setting it in the userspace rules ... well, just doesn't make sense to me. On any level. That should be set on the keyboard, and keymap/layout level.

Speaking of which... I think we absolutely do need the "Supported" setting. We ... technically already have it, in LAYOUT_HAS_RGB. I think that this PR should handle most of the cases that have complex checks needed. albeit with the above suggestion applied. I tested that out, and after the move... as long as you don't set it via MAKE arguments in the command line, it gracefully handles the deactivation of features, so that they are not compiled for. (without the change, it does error out in my userspace).

@skullydazed
Copy link
Member Author

skullydazed commented May 12, 2020

It seems to be more maintainable to use foreach as follows.

@mtei I agree that what you have is easier to maintain, but I can't get it to work. I have pushed my code to this branch and am testing with make clueboard/66_hotswap/gen1:default. I have pre-configured keyboards/clueboard/66_hotswap/gen1/rules.mk with AUDIO_SUPPORTED = no.

Using the series of if statements that works as I expect. Using the foreach you describe does not, I see lines like this in my compile output:

Compiling: quantum/process_keycode/process_audio.c                                                  [OK]
Compiling: quantum/process_keycode/process_clicky.c                                                 [OK]
Compiling: quantum/audio/audio_chibios.c                                                            [OK]
Compiling: quantum/audio/voices.c                                                                   [OK]
Compiling: quantum/audio/luts.c                                                                     [OK]

Edit- @drashna spotted the mistake and now this is working perfectly.

disable_features.mk Outdated Show resolved Hide resolved
@vomindoraan
Copy link
Contributor

vomindoraan commented May 12, 2020

But part of that, is that I feel that hardware settings should NOT be set in the userspace, for any reason. It's generic configuration, and the workflow for it isn't really equipped/set up to handle that.

You use RGBLIGHT_ENABLE as an example here... and ... that was my first goto for examples for documentation. Setting it in the userspace rules ... well, just doesn't make sense to me. On any level. That should be set on the keyboard, and keymap/layout level.

You're right about hardware settings. RGBLIGHT_ENABLE was the first thing that came to mind and I must admit I didn't think twice about it. I agree that hardware-specific settings shouldn't be in userspace rules.

But what about TAP_DANCE_ENABLE, COMMAND_ENABLE, UNICODE_ENABLE and other generic features that you might want to have enabled by default for all of your keymaps (or disabled, in the case of something like SPACE_CADET_ENABLE) — except for a few keymaps, where you want to do the opposite because, e.g., the board is running out of space? This is the actual use case.

At the moment, you have no way of disabling features in the keymap rules if you've enabled them in the userspace, and so you have to copy the flags into each keymap rules.mk file. If you want to change the default for a setting, or add a new one, you have to go through all of the files to make the change.

The proposed post_keymap.mk/post_rules.mk change would fix that. It would also have the benefit of reducing perceived complexity by making rules.mk behave in the expected manner (generic to specific, keyboard→userspace→keymap), consistent with the rest of the files. In other words, it would reduce the astonishment factor of this particular part of the build system.

That being said, I believe those changes can coexist with the <FEATURE>_SUPPORTED flags.

@mtei
Copy link
Contributor

mtei commented May 12, 2020

Don't forget about #8422 (keyboard-level post-rules.mk)

Currently, the QMK Configurator is not able to compile the Helix keyboard. I think we need a mechanism like this post-rules.mk on the core side to solve this.
(qmk/qmk_configurator#684) (qmk/qmk_configurator#714)

If you are rejecting #8422, please tell me another way to compile the Helix keyboard using the QMK Configurator.

@skullydazed
Copy link
Member Author

If you are rejecting #8422, please tell me another way to compile the Helix keyboard using the QMK Configurator.

We haven't rejected anything yet, we're still exploring the problem space. This is one of those topics where a lot of competing interests intersect.

@drashna
Copy link
Member

drashna commented May 13, 2020

It's also a very, very complicated issue/subject/etc.

The question is, which is best long term, that does everything we need, without making it unmanageable later on.

@stale
Copy link

stale bot commented Jun 27, 2020

Thank you for your contribution!
This pull request has been automatically marked as stale because it has not had activity in the last 45 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, or re-open when it's ready.
For maintainers: Please label with awaiting review, breaking_change, in progress, or on hold to prevent the issue from being re-flagged.

@skullydazed
Copy link
Member Author

I've rebased this to current master and have added a bunch of _SUPPORTED rules so that a large number of make all:all errors are fixed. I believe this to be ready to go in.

This still leaves an open question around #8422 but I don't think merging this actually helps or hinders the issue #1 there. @mtei please correct me if I'm wrong.

@skullydazed skullydazed requested a review from a team January 16, 2021 00:58
@vomindoraan
Copy link
Contributor

vomindoraan commented Jan 16, 2021

Has the team decided on what the best way to handle use cases described above by @mtei and myself should be moving forward? (Specifically, I'm referring to this, this and this; the latter is exemplified in vomindoraan@deb080b.)

Has a decision been made regarding the addition of post_keymap.mk (or similar) files to the build system, as proposed in #9070?

@skullydazed
Copy link
Member Author

Has the team decided on what the best way to handle use cases described above by @mtei and myself should be moving forward? (Specifically, I'm referring to this, this and this; the latter is exemplified in vomindoraan/qmk_firmware@deb080b.)

No, but I'm increasingly coming around to the opinion that the proposed solutions are overly complex for the problem at hand, and will hinder our data driven efforts. I think drashna is right- userspace should not be trying to enable hardware features. They are keyboard specific and that configuration belongs in the keyboard realm.

Further discussion on this is offtopic for this PR and should be taken to an appropriate issue or PR. I'd like to refocus this PR on the issue at hand- giving keyboards a way to declare what hardware they don't support- which should not conflict with the other goals described.

Copy link
Contributor

@mtei mtei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This still leaves an open question around #8422 but I don't think merging this actually helps or hinders the issue #1 there. @mtei please correct me if I'm wrong.

I agree that this is ready for a merge.

@skullydazed skullydazed merged commit d02c4c5 into master Jan 30, 2021
@skullydazed skullydazed deleted the feature_supported branch January 30, 2021 21:08
pull bot pushed a commit to kruton/qmk_firmware that referenced this pull request Jan 30, 2021
* Initial attempt at allowing keyboards to indicate what features they do not support

* try to use a for loop instead

* Update disable_features.mk

Co-authored-by: Drashna Jaelre <[email protected]>

* add a few more features

* remove my test fixture

* disable things that make all:all suggested"

Co-authored-by: Zach White <[email protected]>
Co-authored-by: Drashna Jaelre <[email protected]>
sowbug pushed a commit to sowbug/qmk_firmware that referenced this pull request Feb 10, 2021
* Initial attempt at allowing keyboards to indicate what features they do not support

* try to use a for loop instead

* Update disable_features.mk

Co-authored-by: Drashna Jaelre <[email protected]>

* add a few more features

* remove my test fixture

* disable things that make all:all suggested"

Co-authored-by: Zach White <[email protected]>
Co-authored-by: Drashna Jaelre <[email protected]>
Codetector1374 pushed a commit to OpenAnnePro/qmk_firmware that referenced this pull request Feb 26, 2021
* [Keyboard] Add Hub20 keyboard (#11497)

* add Hub20 support

* Keymap formatting cleanup

Co-authored-by: Ryan <[email protected]>

* Delete bootloader_defs.h as no longer required

* Correct make / flashing example

Co-authored-by: Ryan <[email protected]>

* Update rules.mk

Co-authored-by: Ryan <[email protected]>

Co-authored-by: Ryan <[email protected]>

* [Keyboard] Add new afternoonlabs/breeze/rev0 split keyboard (#11510)

* Adding new breeze keyboard under afternoonlabs

* Compiling only Rev0, moving readme there

* Apply suggestions from code review

Addressing review comments, removing legacy description config. Removing copy paste leftovers

Co-authored-by: Drashna Jaelre <[email protected]>

* Addressing review, remove empty rules.mk

* typos

* Apply suggestions from code review

Co-authored-by: Ryan <[email protected]>

Co-authored-by: Eithan Shavit <[email protected]>
Co-authored-by: Drashna Jaelre <[email protected]>
Co-authored-by: Ryan <[email protected]>

* [Keyboard] Add ISO Macro keyboard (#11517)

* -

* -

* -

* -

* -

Co-authored-by: online <[email protected]>

* [Keyboard] Add VIA support for CA66 (#11522)

* Add VIA support

made changes to add VIA support for the CA66

- added VIA keymap.c, readme.md, rules.mk
- changes made to main rules.mk to keep firmware size down (mousekey_enable = no; backlight_enable = no)
- changed VENDOR_ID in config.h from 0xFEED to 0x504B (PK)

* Minor changes to CA66 for VIA support

edited keymap info
enabled backlight

* Update vendorID

Change to vendorID to remove conflict with previously chosen vendorID already in use

* Update keyboards/playkbtw/ca66/rules.mk

Co-authored-by: Joel Challis <[email protected]>

* Update keyboards/playkbtw/ca66/keymaps/via/readme.md

Co-authored-by: Joel Challis <[email protected]>

* Update keyboards/playkbtw/ca66/keymaps/via/keymap.c

Co-authored-by: Joel Challis <[email protected]>

Co-authored-by: Joel Challis <[email protected]>

* [Keyboard] Added Ortho support to Program Yoink kb (#11534)

* Added Ortho support

* Updated JSON

* [Keyboard] eliminate nested layout warnings in kbd75 (#11540)

* Updated documentation for new BDN9 board revisions (#11380)

Co-authored-by: Ryan <[email protected]>
Co-authored-by: Danny <[email protected]>

* Remove `DESCRIPTION`, B-D (#11513)

* [Keymap] Add domnantas lily58 keymap (#10910)

* Initialize domnantas layout

* Update oled status display

* Layout and oled changes

* Updates to keymap

* Add F keys and page moves

* Add media keys, rearrange home and end

* Add instructions

* Swap backspace and enter

* Remove unnecesary Enter keymap

* - Change display timeout
- Update minus sign to work on both English and Lithuanian layouts

* Add copyright header

* Replace static strings with PSTR

* Update keyboards/lily58/keymaps/domnantas/keymap.c

Co-authored-by: Ryan <[email protected]>

* Update keyboards/lily58/keymaps/domnantas/keymap.c

Co-authored-by: Ryan <[email protected]>

* Update keyboards/lily58/keymaps/domnantas/keymap.c

Co-authored-by: Ryan <[email protected]>

* Update keyboards/lily58/keymaps/domnantas/keymap.c

Co-authored-by: Ryan <[email protected]>

* Update keyboards/lily58/keymaps/domnantas/rules.mk

Co-authored-by: Ryan <[email protected]>

Co-authored-by: Ryan <[email protected]>

* allow customizing decrease delay of rgb heatmap (#11322)

* allow customizing decrease delay of rgb heatmap

* rename rgb typing heatmap decrease delay variable

* address review comments

* nix-shell: add clang-tools required for formatting the C code

* heatmap: use real timer to track decrement rate

* heatmap: fix ifndef var name typo

* heatmap: add docs

* Update docs/feature_rgb_matrix.md

Co-authored-by: Drashna Jaelre <[email protected]>

Co-authored-by: Drashna Jaelre <[email protected]>

* [Keymap] Adds ymdk/ymd09 andys8 layout (#11320)

Custom layout for macropad. It shows the usage of macros with unicode,
and other layouts (ISO-DE) with unicode, emojis, and git commands.

* arm_atsam: temporarily lower raw HID endpoint/report size (#11554)

* Adafruit BLE cleanups (#11556)

* [Keyboard] Add cool836A 1_2 (#11467)

* 1st trial on 1_2

* remove keymaps/default/km_default.c

* fix cool836A.h

* fix keymap.c into 3x12

* rename to cool836a (not 'A')

* remove cool836A (not a)

* remove backslashes at keymap.c

Co-authored-by: Ryan <[email protected]>

* update keymap.c (add licence)

* Update keyboards/cool836a/keymaps/default/readme.md

removed "<br>" in line 2

Co-authored-by: Ryan <[email protected]>

* Update keyboards/cool836a/keymaps/default/readme.md

remove "<br>" in line 4

Co-authored-by: Ryan <[email protected]>

* Update keyboards/cool836a/keymaps/default/readme.md

remove "<br>" in line 8

Co-authored-by: Ryan <[email protected]>

* Update keyboards/cool836a/cool836a.h

remove cool836a.h line 30:36

Co-authored-by: Ryan <[email protected]>

Co-authored-by: Ryan <[email protected]>

* Cutie Club Borsdorf: Configurator key sequence fix (#11549)

* human-friendly formatting

* correct key order (ISO Enter)

* Afternoon Labs Breeze Rev0: Configurator key sequence fix (#11550)

* human-friendly formatting

* correct key order

* Adds VIA support for the KPRepublic's BM60 Poker (#11267)

* WIP working on new keymap

* tweaking keymap

* updated keymap

* cleaned up a little bit

* New preonic keymap

* my preonic keymap

* added mac layout

* preonic map update

* cleaning up old repo

* cleaning up to match upstream

* more cleanup

* removing old keymaps

* cleaned up commit history for bm60poker via support

* cleaned up via keymap

* fixed copywrite

Co-authored-by: Peter Peterson <[email protected]>

* Modify my keymap (#11407)

* Add BGR byte order for WS2812 drivers (#11562)

* add byte order bgr for ws2812

* update docs for driver change

* Update ws2812_driver.md

* Update docs/ws2812_driver.md

Co-authored-by: Ryan <[email protected]>

Co-authored-by: Ryan <[email protected]>

* New Keyboard: walletburner/cajal (#10458)

* adding alpha variants

* adding cajal layouts

* adding V2 PCB support

adding additional layouts for new PCB version, and correecting incorrect image in info file

* Cleanup master -- remove alpha9

* Cleanup master -- remove g4m3ralpha

* Cleanup master -- remove cajal & sl40

* Master cleanup -- re-add sl40

* Master cleanup -- correct SL40 image

* New Keyboard: walletburner/cajal

* Added license attribution to *.{c,h} files

* Update keyboards/walletburner/cajal/config.h

Co-authored-by: James Young <[email protected]>

* Update keyboards/walletburner/cajal/keymaps/ortho/keymap.c

Co-authored-by: Drashna Jaelre <[email protected]>

* Rename 'ortho' keymap to 'default_ortho'

* Update keyboards/walletburner/cajal/cajal.c

Co-authored-by: Drashna Jaelre <[email protected]>

* Update readme.md

Adding bootloader instructions.

Co-authored-by: worldspawn00 <[email protected]>
Co-authored-by: James Young <[email protected]>
Co-authored-by: Drashna Jaelre <[email protected]>

* Improve the compile and flash subcommands (#11334)

* add support for --clean to compile and flash

* compile standalone JSON keymaps without polluting the tree

* Add support for passing environment vars to make

* make flake8 happy

* document changes to qmk compile and flash

* add -e support to json export compiling

* Fix python 3.6

* honor $MAKE

* add support for parallel builds

* [Keyboard] add Stream15 keyboard  (#11515)

* add keyboard Stream15

* committted changes as suggested by drashna

* committed further changes as suggested

* Update info.json

removed excessive comma

* Update keyboards/nibiria/stream15/rules.mk

Co-authored-by: Ryan <[email protected]>

* Update keyboards/nibiria/stream15/keymaps/via/rules.mk

Co-authored-by: Ryan <[email protected]>

* Update keyboards/nibiria/stream15/readme.md

Co-authored-by: Ryan <[email protected]>

* resolved 2 more issues

Co-authored-by: Ryan <[email protected]>

* Generate version.h when compiling json files (#11581)

* generate version.h when compiling json files

* make flake8 happy

* fix formatting and verbose

* quiet up the compile output

* Add syscall fallbacks to ChibiOS builds (#11573)

* Add fallback syscalls to ChibiOS builds that are present but able to be overridden as appropriate.

* Modified location to be ChibiOS-specific.

* Remove `DESCRIPTION`, E-G (#11574)

* Naked64 Configurator update and rework (#11568)

* [Keyboard] Monstargear XO87 RGB Hot-Swap PCB (#11555)

* Support for Monstargear XO87 Hot-Swap PCB

* Remove manufacturer from product line

* Removed alternate bootloaders

* Updated info.json

* Missed RGB_DISABLE_WHEN_USB_SUSPENDED in config.h

* Delete kb.h

* Update rgb.h

* Update rules.mk

* Add files via upload

* Delete kb.h

* Update keymap.c

* Update config.h

* Update rgb.c

* Add via RGB support

* Update info.json

* Update readme.md

* Update readme.md

* Update config.h

* Update rgb.h

* Update config.h

* Mirror factory layout

* Mirror factory layout

* Update rgb.h

* Update keyboards/xo87/rgb/rgb.c

* Update rgb.c

* Update keyboards/xo87/rgb/config.h

* Update keyboards/xo87/rgb/rules.mk

* Update keyboards/xo87/rgb/rules.mk

* Update keyboards/xo87/rgb/keymaps/via/keymap.c

* Update keyboards/xo87/rgb/rules.mk

* Update keyboards/xo87/rgb/rules.mk

* Update keyboards/xo87/rgb/keymaps/via/keymap.c

* Update config.h

* Update keyboards/xo87/rgb/readme.md

* Update keyboards/xo87/rgb/readme.md

* Update keyboards/xo87/rgb/readme.md

* Update keyboards/xo87/rgb/rules.mk

* Update keyboards/xo87/rgb/rules.mk

* Update keyboards/xo87/rgb/rules.mk

* Update keyboards/xo87/rgb/rules.mk

* Update keyboards/xo87/rgb/rules.mk

* remove deprecated action_get_macro()

* rearrange layout per request

* rearrange layout per request

* Update keyboards/xo87/rgb/rgb.h

* Update keyboards/xo87/rgb/keymaps/default/readme.md

* Update keyboards/xo87/rgb/readme.md

* Bugfix for RGB Matrix

* Bugfix for RGB Matrix

* Moved to new subdirectory and updated build commands to reflect changes

* Remove old files

* Caps Unlocked CU65 layout macro fixes (#11606)

* Cannonkeys Onyx: Configurator/QMK CLI improvements (#11603)

* info.json: human-friendly formatting

* info.json: correct key object order

* info.json: replace Unicode characters

They don't play nice with `qmk info -l`.

* info.json: correct keyboard dimensions

* [Keymap] Add peej userspace and keymaps (#11332)

* New keymaps with KC_LGUI on another key and scroll with encoder (#11479)

* feat(kyria): new keymaps with KC_LGUI on another key

add also possibility to scroll with encoder and finally play with olded
screen to replace default kyria logo by Magic the Gathering mana color
icon.

* Update keyboards/kyria/keymaps/benji/keymap.c

Co-authored-by: Drashna Jaelre <[email protected]>

* add magic logo

* add mouse button

Co-authored-by: Drashna Jaelre <[email protected]>

* change to cmm.studio saka68 folder. split to solder and hotswap, add hotswap fimware (#11443)

* new repo: create cmm.studio folder, add saka qmk firmware

new folder for cmm.studio line up keyboard
added saka68 keyboard qmk and via firmware support

* Update keyboards/cmm.studio/saka68/config.h

Co-authored-by: Ryan <[email protected]>

* Update keyboards/cmm.studio/saka68/rules.mk

Co-authored-by: Ryan <[email protected]>

* Update keyboards/cmm.studio/saka68/keymaps/via/rules.mk

Co-authored-by: Ryan <[email protected]>

* Update keyboards/cmm.studio/saka68/config.h

Co-authored-by: Ryan <[email protected]>

* fix on keymap, readme

fix on keymap, readme

* Update keyboards/cmm.studio/saka68/readme.md

Co-authored-by: Ryan <[email protected]>

* Update keyboards/cmm.studio/saka68/keymaps/default/keymap.c

Co-authored-by: Ryan <[email protected]>

* update vendor name with _ instead of .

update vendor name with _ instead of .

* Update readme.md

change the make format

* Update keyboards/cmm_studio/saka68/keymaps/default/keymap.c

Co-authored-by: Ryan <[email protected]>

* deleted some files from cmm.studio, changes to cmm_studio

deleted some files from cmm.studio, changes to cmm_studio

* Update readme.md

make command changed

* Update keyboards/cmm_studio/saka68/readme.md

Co-authored-by: Ryan <[email protected]>

* Update readme.md

added pic for pcb

* Update readme.md

* Update readme.md

* Update readme.md

* Update readme.md

* Update readme.md

* Update keyboards/cmm_studio/saka68/config.h

tested and does work now. deleting these lines

Co-authored-by: Ryan <[email protected]>

* Update readme.md

* Update readme.md

* Update readme.md

* Update readme.md

* Update readme.md

* Update readme.md

* Update readme.md

* Update keyboards/cmm_studio/saka68/readme.md

Co-authored-by: Ryan <[email protected]>

* Update readme.md

added use physical reset button instruction

* change to the cmm saka folder

making the changes to cmm saka firmware

seperated solder version firmware and hotswap version firmware

* Update readme.md

* Update readme.md

* Update readme.md

* Update readme.md

* Update readme.md

* Update readme.md

* Update readme.md

* Update readme.md

* Update readme.md

* Update readme.md

* change to the cmm saka hotswap folder

Co-authored-by: Ryan <[email protected]>

* GCC 10 compatibility for Ploopy optical encoder (#11586)

* Remove `DESCRIPTION`, H-J (#11616)

* Fixup declaration for _kill, add other missing syscalls, populate errno. (#11608)

* Remove `DESCRIPTION`, K-M (#11619)

* Remove `DESCRIPTION`, N-Q (#11631)

* Remove `DESCRIPTION`, R-V (#11632)

* Remove `DESCRIPTION`, W-Z (#11633)

* Update info.json - Program Yoink (#11558)

* Update info.json

Fix ortho_split

* [Keyboard] Add Mesa TKL (#11294)

* Add keyboard: Mesa TKL

* Fix image link in readme

* Update keyboards/mesa/mesa_tkl/mesa_tkl.c

Co-authored-by: Joel Challis <[email protected]>

* Update keyboards/mesa/mesa_tkl/rules.mk

White space changes

Co-authored-by: Ryan <[email protected]>

* Replace tabs with spaces per C coding conventions.

* Update keyboards/mesa/mesa_tkl/readme.md

Co-authored-by: Ryan <[email protected]>

Co-authored-by: Joel Challis <[email protected]>
Co-authored-by: Ryan <[email protected]>

* Fix wrong key when "Music Map" is used with MAJOR_MODE. (#11234)

With MAJOR_MODE (= major scale), keys in one octave is not 12 but 7.
To solve this problem, change divisor number from 12 to 7 at %(Modulo) and /(Division).

NOTE:
The last 12 represents half step keys in one octave for pitch calculation.

* Improve the Lighting Layers example in RGB Lighting docs (#11454)

* Improve the keymap layer state -> lighting layers example

* A few more improvements

* [Keyboard] Leafcutterlabs (#11464)

* add support for bigknob

Add support for bigknob macropad

* corrected files

* Apply suggestions from code review

Co-authored-by: Joel Challis <[email protected]>

* corrected tap dance

* Update config.h

* correct image link

* Apply suggestions from code review

Co-authored-by: Ryan <[email protected]>

* added GPL headers

* Update readme.md

* update rules to disable tap dance

* remove tap dance

* Update rules.mk

trying to get to pass travis test

* Update rules.mk

remove tap dance

Co-authored-by: Joel Challis <[email protected]>
Co-authored-by: Ryan <[email protected]>

* Add stm32-dfu and apm32-dfu to bootloader.mk (#11019)

* Add stm32-dfu and apm32-dfu to bootloader.mk

* Update flashing docs

* Update comment

* Further wordsmithing

* [Keymap] Mac-friendly KBD 75% layouts (#11507)

* Add Aaron's KBD75 v2 for Macbook

* Add Colemak & Dvorak layers

* Update keymap to adhere to style guide and add license

* Rename README.md to readme.md

* [Keymap] add happysalada (#11535)

* add keymap: happysalada

* use enum instead of define

* remove uneeded config file

* [Keyboard] Update X-Bows Nature Keyboard (#11538)

* Update config.h

* Update nature.c

* Update rules.mk

* Update keymap.c

* [Keyboard] Add indicator LED support to playkbtw/helen80 (#11560)

* add indicator led support

* use LED config instead

* Handwired ASkeyboard Sono1: Configurator fixes (#11625)

* info.json: human-friendly formatting

* info.json: correct key order

* Correct LED physical mapping on monstargear xo87 rgb pcb (#11629)

* corrected LED physical mapping

* Corrected issue that made VIA display layer 1 incorrectly

Co-authored-by: datafx <[email protected]>

* Small tweaks to docs to make them more user friendly (#11518)

* first pass

* firmware firmware?

* Split out debug + testing docs

* tidy up duplicate css

* Add extra info to debug example

Co-authored-by: Drashna Jaelre <[email protected]>

Co-authored-by: Drashna Jaelre <[email protected]>

* Fix QMK_BUILDDATE (#11641)

* update CI list about helix keyboards

* exclude 'helix/rev3_4rows' from CI
  Since helix/rev3_4rows is almost the same as helix/rev3_5rows, there is no point in checking with travis-ci.

* include 'helix/pico/back' to CI
  helix pico and helix rev2 are still available. I would like to check both by travis-ci, but here I will add a check only for helix pico.

* Remove rules.mk in leafcutterlabs/bigknob:default (#11652)

* Add 3rd encoder to VIA keymap (#11580)

* Isometria 75: Configurator/CLI fixes (#11612)

* info.json: human-friendly formatting

* info.json: update key object labels

Some of the characters in the original file don't play nicely with `qmk info -l` on Windows.

* info.json: correct key object order

* [Keymap] Cleanup and updating of drashna keymap code (#11516)

* Update other keyboards for rgb matrix changes

* Remove customized bootmagic code

* Fix corne layout compilation error

* Fix compiler errors with all keymaps

* Add Simple Visualizer for ergodox infinity

* Fix compile issue with Corne

* Fix keymap stuff

* Add alias for mouse layer

* Add Halmak Keyboard layout

* Updates for Kyria

* Add support for oled interval

* Change RGB stuff

[CHANGE] Fix coexistence issues

* Fix rgb_stuff

* Add custom ploopyco mouse keymap

* Decrease default dwell time

* Updates based on last breaking changes update

* Disable command on dactyl

* Update ergodox to use proper commands for rgb matrix indicators

* Update all rgb matrix indicator functions

* Update rules for dactyl-manuform

* Reduce wait time for mouse layer off event

* Add more info to logger

* Add wrappers for get_tapping term

* Move version.h include into only file that actually needs it

* Update rgb sleep stuff

* Update key print function

* Change DM keymap settings

* Change pin for DM Manuform

* Add Proton C stuff for Corne keymap

* more arm corne tinkering

* Even more arm stuff for corne

* Cleanup corne stuff

* redirect default keymap to drashna

because I am a very bad man

* change corne rgb priority

* Update tractyl manuform to not conflict

* Add more secret stuff

* more dactyl tweaks

* Add more options to split transport

* Changes of oled support

* Change split settings

* Improve keylogger formatting more

* tweak oled stuff

* Oled and such tweaks

* Reduce brightness due to leds

* Decrease brightness more

* Only run layer code if master

* [Keymap] Breeze keymap eithanshavit (#11640)

Co-authored-by: Eithan Shavit <[email protected]>

* [Keyboard] Pinky refactor (#11643)

* QMK Configurator layout support for Pinky

3-row and 4-row versions

* refactor default keymaps

- use an enum for layer names
- remove redundant definitions
- qmk cformat pass
- modify pinky/4 via keymap to mirror pinky/4 default functionality

* remove LAYOUT_kc macros

This usage is not endorsed by QMK as it has been found to be confusing to novice users.

* add VIA support to pinky/3

* update config.h files

Removes unnecessary definitions for Backlight, RGB Underglow, Magic config and MIDI.

* update main rules.mk file

Updates the rules.mk file to match the formatting of the current QMK-provided template. Removes sample bootloader comments, feature rules that are no longer included in the template, and updates the in-line comments.

* update and split keyboard readme

Updates the main readme file's formatting, adds instructions to access bootloader mode, and adds more specific readmes for each version.

* add line breaks between rows in the info.json files

* rename layout macros for Community Layout forward compatibility

The layouts of the Pinky3 and Pinky4 aren't currently Community Layouts, but support for them could be added with a rules.mk edit should the layouts be added to QMK.

* Woodpad refactor (#11651)

* Move Backslash/ISO Hash key to home row for Uni660 rev2 ISO (#11657)

* Move Backslash/ISO Hash key to home row for Uni660 rev2 ISO

* update readme formatting

* Program Yoink! refactor (#11636)

* split config.h for each variant

* split rules.mk for each variant

* split source and header files for each variant

* move keymaps to the appropriate variant

* update keyboard readme

* update keymap readmes

* differentiate Staggered and Ortho USB Device Strings

* clean up formatting in info.json

* split info.json files for each variant

* break up the info.json for readability

* correct key positioning and board dimensions

* correct key object sequences

* add weak encoder function to keyboard level

Allows Configurator-compiled firmware to have encoder functionality.

* add variant-specific readme files and bootloader instructions

* Infinity60 refactor (#11650)

* [Keymap] Adding Fancy and Bongocat Keymap to Mercutio Keyboard (#11520)

* Initial commit on new clean branch. Testing out functionality of oled and encoder for default features.

* Cleaned up the initial push and removed the fancy keymap until the extra features and functionality can be tested and made more user friendly.

* Cleaned up the readme some more, compiled and tested both default and via keymaps, and did another round of checks to prepare for starting the PR.

* Cleaning up the keymap to meet expected formatting in a couple places and also adding in the TAP_CODE_DELAY after newly encoutnered encoder issues and inconsistencies.

* Initial commit of branch specifically for implementing the more complicated fancy keymap as I expect the main PR to be approved first.

* testing bongo cat out

* Progress with intended OLED behavior. Needs to be cleaned up still.

* Cleaned up bongocat and added WPM display on it.

* Almost there. Need to rethink the layer checking in encoder.

* Fixing all the merge issues I didn't check before doing the last commit. Learn from my mistakes, check your commits.

* Fixed and updated fancy firmware and bongocat firmware.

* Updating license year since I will be doing a PR anyway.

* Update keyboards/mechwild/mercutio/keymaps/fancy/keymap.c

Co-authored-by: Ryan <[email protected]>

Co-authored-by: Ryan <[email protected]>

* Fix typos and reword some sentences in FAQs (#11546)

* Fix minor typo in "General FAQ"

"want to do brand it with QMK" -> "want to brand it with QMK"

* Reword some of "Debugging FAQ" & "Miscellaneous FAQ".

Mostly grammatical wording of some parts and missing capitalization

* [Keyboard] adding support for new keyboard Dawn (#11564)

* initial commit Dawn keyboard

* fixing some matrix

* final tweaks to keymaps and info.json layout

* fix info.json missing delimiter

* missing elements in info.json layout, resolved through lint

* fixed missing link image in readme

* Update keyboards/mechstudio/dawn/readme.md

Co-authored-by: Ryan <[email protected]>

Co-authored-by: David <[email protected]>
Co-authored-by: Ryan <[email protected]>

* Fix number RGB RART4x4 dan matrix pin RART45 (#11582)

* Update config.h

* Update config.h

* Update docs/getting_started_make_guide.md (#11373)

* update docs/getting_started_make_guide.md

Added description of some targets, including those added with #11338.

* Added description of options added by #11324.

* update docs/getting_started_make_guide.md

* Added description of  target.

* Update docs/getting_started_make_guide.md

Co-authored-by: Drashna Jaelre <[email protected]>

* Update docs/getting_started_make_guide.md

Co-authored-by: Ryan <[email protected]>

* Update docs/getting_started_make_guide.md

Co-authored-by: Drashna Jaelre <[email protected]>

* add ':id=linux-udev-rules' to docs/faq_build.md

Co-authored-by: Drashna Jaelre <[email protected]>
Co-authored-by: Ryan <[email protected]>

* fix(feature_ps2_mouse): fix Scroll Button example (#11669)

Corrected macro in Scroll Button example so it compiles.

* Add VIA support for dm9records/tartan (#11666)

* Fix preonic layout documentation (#11655)

* [Apple M5120] First iteration

* Cleaned apple_m5120 files

* Changes requested by PR

* Update keyboards/apple_m5120/iso/rules.mk

Co-authored-by: Ryan <[email protected]>

* Update keyboards/apple_m5120/iso/keymaps/default/keymap.c

Co-authored-by: Ryan <[email protected]>

* Updated Preonic default layout doc

* Removed non related files

Co-authored-by: dbroqua <[email protected]>
Co-authored-by: Ryan <[email protected]>

* Increased dynamic keymap layers in via keymap (#11575)

* [Keymap] addition for mjuma in keyboards/planck/keymaps (#10885)

* Add planck layout

* switch gaming toggle to TG

* rename readme

* Add jones v.0.3 and v.0.3.1 keyboard (#11130)

* Update LEDの物理的接続とQMKのソフト的接続を調整し、左→アンダーグロー→右と繋がるようにした。

* Update レイヤーインジケータ関連変数を、#ifdefブロック内へ移動。

* Update コード整形

* Revert "Update コード整形"

This reverts commit c98483d9a0b41f8939a01b677cdcd18a8af34f78.

* Update 未使用のキーコード、S_SLSHに関連するコードを削除。

* Update コード整形

* Update キーごとのTappingTerm設定を使用しなくなったため、削除。

* Update 未使用コード削除。

* Update コメント追加

* Update レイヤーとIMEのON/OFFを同じキーに割り当てるのをやめたため、関連コードを削除。

* Update コメント追加

* Update コメント

* Update 誤読を避けるため、ifブロックの表記を括弧を使用したものへ変更。動作に変化なし。

* Update 未使用のため削除。

* Update LED関連でデフォルトレイヤーを格納して使用しないため、削除。

* Update コメント

* Update レイヤーによってロータリーエンコーダの動作を変える機能を追加。

* Update comment

* Update 実態に合わせて修正。

* Update JP用キーコードへの書き換え忘れを修正。

* New v.0.3.1 JP style

* Update v.0.3のJPスタイルではオーディオサポートなし。

* Update to latest information

* New

* New keyboard "stmeishi"

* Update layout name

* Update move common settings from keymap's "rules.mk" to keyboard's "rules.mk".

* Update: Move common settings from keymap's "rules.mk" to keyboard's "rules.mk".

* Update: Add "LAYOUT_all" for multiple layout.

* Update target to latest "v.0.3.1".

* Remove unused item.

* Update comments.

* Update Rotary Encoder pins to actual used count.

* Update increase value to maximum.

* Update comments.

* Change default Effects.

* Remove unused items.

* Update comment.

* Change: Use define and function insted of real value for wait.

* Update copyrght.

* Update Update: Add "LAYOUT_all" for multiple layout.

* New: Place info.json copied from v.0.3.1.

* Remove unused items.

* Update: Add comma at last element.

* Update comments.

* Update: change if block style.

* Update: Change Japanese comments to English.

* Update: Change layout name.

* Update: Change layout name.

* Update: Fix miss numbering for ANSI layout.

* Update: Move "Tap Dance" rule to keymap's rule.

* New: Add default keymap.

* Delete: Moving files to branch.

* Initial: Add files from local.

* Remove local only unused keymaps.

* Update: Remove unused, comment outed codes.

* Add default keymap for v.0.3.

* Update: Add custom keycodes.

* Update: Change layer handling from process_record_user to layer_state_set_user.

* Update comment.

* Update: Remove unused function.

* Add my ErgoDash settings.

* Add my NumAtreus_Plus8 settings.

* Add my test_k15r2 settings.

* New Colice片手分動作確認済み

* Update スプリットキーボード対応

* Update 反応が悪くずっと二度押ししているので、ESCキーをレイヤーキーとの共用から、単独機能に変更。

* Update 右手スイッチ配置変更。インジケータLED対応。

* Change インジケータLEDが眩しいので、明るさを下げた。

* Change 右手親指のキーマップ変更。

* Change NumLockの誤爆防止のため、二度押しでレイヤートグルするようにした。

* Change 左手側、Bの右側のキーを誤爆することが多く日本語入力が途切れるため、レイヤーキーの機能左右で入れ替え。

* Update 右手側、画像ソフトなどで使うため、矢印キーの左をレイヤーキーからCTRLへ変更。

* New add new keyboard

* Update Duplex-Matrixが動作した初版

* New Duplex-Matrixのサンプルコード by e3w2q を最新のQMKファームウェアで動作するよう一部修正したもの。

* update Comment-out debug print code.

* Update Colice V0.2 キープレートで矢印キー付近の物理配列が変わったことへ対応

* Update キーレイアウト

* New Initial commit

* Update Fix migrate errors from test_duplex_dp to test_col2col

* Remove unnecessary files

* Testing

* Update IKeJIさんの方法(とりあえずCOL2COLと呼ぶ)の動作テストOK

* New 2乗マトリクス配線のキーボードを追加

* Update キーレイアウト調整

* New colice_rr 初回コミット。基本動作確認OK。LED不調。

* Update Eable LED, Reduce firmwre size

* Update colice_rr キーマップ調整。

* Update colice_rr ロータリーエンコーダ機能追加。

* Move colice_rr を colice_rr_split へ移動。

* Update colice_rr_splitフォルダへ移動したことに対応。

* New colice_rr_splitの初回コミット。

* Update キーマップ調整

* Update キーマップ調整

* New initial comit

* Update 意図せずカッコを入力することがるため、LSPO、RSPCの使用を中止。

* Change Fnキー押下時の日本語入力ONを、長押し時にキャンセルするように変更。

* Change LED点灯方法変更。

* Change 基板バージョンごとにサブフォルダを作成するようにした。

* Update Windows用レイヤーを追加

* Update LED設定を調整

* New Jones v.0.2を新規追加

* Update Numレイヤー追加。キーマップ調整。レイヤーインジケータLED調整。

* Update 左手Yをやめる

* Update ESCによるNumレイヤートグルを、ESC連打でトグルするのを防止するため、ダブルタップからトリプルタップへ変更。

* Update readme

* Update QMKの標準に従うよう各ファイルの内容を変更。

* Update 長音(ー)を入力しやすくするため、レイヤー上でホームポジションに近い位置に配置。

* Update タップダンスの状態判別を、Single,Double,Triple,Holdの4つのステータスにまとめた。

* Update キーボードの電源が切れてもデフォルトレイヤーの状態を保存しておくため、MACとWINレイヤーへの変更はEEPROMへ書き込むようにした。

* Update 不要箇所削除

* Update キーマップをNarrowとWideで書き換えるのが不便なので、分割した。

* Update 最新のPCBに合わせ、デフォルトをv.0.2に変更。

* New v.0.3を新規追加

* Update キーマトリクスに後からJPを追加するため、ANSI用に表記変更。

* Update ANSI用のキーマップであることを明記。

* New JP用キーマップを新規追加。

* Update スイッチの物理的存在、Enter右側はキー1個、に合わせて、ANSIレイアウトを修正。

* New FA (Full Armor)用レイアウトを新規追加

* Update 物理的ロック付きのCAPSは使用しないため、無効化。

* Update ハードウェアのサポート対象にキープレートを追加。

* Update FAで使用するAudio、RotaryEncoderの機能追加。機能削減でファームウェアサイズ縮小。

* Update オーディオ機能にキークリックを追加。

* update FA用設定

* Update 右シフトにキー追加

* Update 変換キー調整

* New オーディを有効化。マウスキーはサイズ削減のため無効化。

* Update スイッチ配置ミス修正。

* Update ピン定義を、ロータリーエンコーダの回転方向に合わせた

* Update 2音同時発音用にピン定義を追加。

* Update ファームサイズに空きがあるので、クリッキー音をデフォルトで利用できるようにした。

* Update LED設定変更

* New 物理配列がJPで、中身はUS配列のキーマップを追加。

* Update 行と列が入り乱れたレイアウトのため、音階が正しくなるように、Music-Mode用のキーマップを定義。

* Change マイナーバージョンの表記に対応できるよう、DEVICE_VERの桁を1つ上げた。

* Update オルソ+ロースタガであることがわかるように、キーボードの簡単な説明を変更。

* New v.0.3.1の初期コミット

* Update 左右で回転方向の判定が逆になるので、右手側を左手に合わせた。

* Update キーマップ調整

* Update LEDインジケータを、v.0.3系と同じ点灯方法(2個をベースレイヤ、1個をRAISEなど)に変更。

* Update RGBLIGHT明るさ調整、エフェクト追加。

* Update 未使用キー設定を削除。

* Update Shiftと組み合わせた/?キーの反応を良くするため、キーごとにTAPPING_TERMを指定できるようにした。

* Update LEDエフェクト追加

* Update keymap

* Update 未使用のものを削除

* Update LEDの物理的接続とQMKのソフト的接続を調整し、左→アンダーグロー→右と繋がるようにした。

* Update レイヤーインジケータ関連変数を、#ifdefブロック内へ移動。

* Update コード整形

* Revert "Update コード整形"

This reverts commit c98483d9a0b41f8939a01b677cdcd18a8af34f78.

* Update 未使用のキーコード、S_SLSHに関連するコードを削除。

* Update コード整形

* Update キーごとのTappingTerm設定を使用しなくなったため、削除。

* Update 未使用コード削除。

* Update コメント追加

* Update レイヤーとIMEのON/OFFを同じキーに割り当てるのをやめたため、関連コードを削除。

* Update コメント追加

* Update コメント

* Update 誤読を避けるため、ifブロックの表記を括弧を使用したものへ変更。動作に変化なし。

* Update 未使用のため削除。

* Update LED関連でデフォルトレイヤーを格納して使用しないため、削除。

* Update コメント

* Update レイヤーによってロータリーエンコーダの動作を変える機能を追加。

* Update comment

* Update 実態に合わせて修正。

* Update JP用キーコードへの書き換え忘れを修正。

* New v.0.3.1 JP style

* Update v.0.3のJPスタイルではオーディオサポートなし。

* Update to latest information

* New

* New keyboard "stmeishi"

* Update layout name

* Update move common settings from keymap's "rules.mk" to keyboard's "rules.mk".

* Update: Move common settings from keymap's "rules.mk" to keyboard's "rules.mk".

* Update: Add "LAYOUT_all" for multiple layout.

* Update target to latest "v.0.3.1".

* Remove unused item.

* Update comments.

* Update Rotary Encoder pins to actual used count.

* Update increase value to maximum.

* Update comments.

* Change default Effects.

* Remove unused items.

* Update comment.

* Change: Use define and function insted of real value for wait.

* Update copyrght.

* Update Update: Add "LAYOUT_all" for multiple layout.

* New: Place info.json copied from v.0.3.1.

* Remove unused items.

* Update: Add comma at last element.

* Update comments.

* Update: change if block style.

* Update: Change Japanese comments to English.

* Update: Change layout name.

* Update: Change layout name.

* Update: Fix miss numbering for ANSI layout.

* Update: Move "Tap Dance" rule to keymap's rule.

* New: Add default keymap.

* Delete: Moving files to branch.

* Initial: Add files from local.

* Remove local only unused keymaps.

* Update: Remove unused, comment outed codes.

* Add default keymap for v.0.3.

* Update: Add custom keycodes.

* Update: Change layer handling from process_record_user to layer_state_set_user.

* Update comment.

* Update: Remove unused function.

* Revert "Remove: Non related files."

This reverts commit 82306568fad408427c757de832025dee91ca5a7f.

* Update: To resolve "submodule path not found" message.

* RemoRemove: Non related files.

* Revert file before miss comit.

* Update: Remove unused keycode.

* Update: レイアウト設定内のNUMレイヤへのトグルを、カスタムキーコード表記に変更。

* Update: Comment

* Update: Remove unused items.

* Update layout settings.

* Update: For simplicity, change toggle ADJUST layer method from process_record_user() to layer_state_set_user().

* Update: comment and styling.

* Update: Remove unused custom keycodes.

* Update: For simplicity, change toggle layer method from process_record_user() to layer_state_set_user().

* Update: Remove unused items.

* Update: comment and styling.

* Update: Correct comment.

* Update description and flashing example.

* Update: Remove comment-outed bootloaders.

* Update comments.

* Update: Correct LED count, without under-glow.

* Update: Chenged to common values with v.0.3.1.

* Update: Changed to common values with v.0.3.

* Updarte: Remove unused layout.

* Update: Change default layout to "ALL".

* Update comment.

* Update comment.

* Add missing file.

* Update: Change build option definition style.

* Update: Change build option definition style.

* Update: Change CUSTOM_MATRIX to "lite" and convert "matrix.c" to "lite" version.

* Update: Move "music_map" to keyboard's c file.

To provide common definition for other keymap creator.

* Update: Change keyboard name "v.0.3.1" ---> "v03_1".

For human readability, version name "v.0.3.1" remains at title on "readme.md".

* Update: Change keyboard name "v.0.3" ---> "v03".

For human readability, version name "v.0.3" remains at title on "readme.md".

* Update: Correct matrix definition at "k92".

* Apply suggestions from code review

Remove unnecessary comment block.

* Apply suggestions from code review

Remove "Optional" deprecated items.

* Apply suggestions from code review

Change "make" target keymap to standard default.

* Apply suggestions from code review

Remove rules for MIDI_ENABLE, FAUXCLICKY_ENABLE and HD44780_ENABLE.
These features are not enabled.

* Apply suggestions from code review

Convert tabs to spaces.

* Update: Change #define ROW_SHIFTER to keyboard specific.

* Fix midi for CRKBD (#11644)

Co-authored-by: BuildTools <[email protected]>

* Change VID/PID for Zinc (#11681)

* [Keyboard] Add layout to torn keyboard (#11684)

* Remove redundant I2C config defines from keyboards (#11661)

* [Keyboard] Add RGB Matrix support for The Mark:65 (#11676)

* Add RGB Matrix support for Mark 65 keyboard

* Update drive LED count

* Removed unnecessary define line

* Corrected typo

Co-authored-by: filterpaper <filterpaper@localhost>

* [Keymap] Update Program Yoink Ortho Split Layout (#11675)

* [Keyboard] Fix for LEDs on PocketType (#11671)

The LED anodes of the pockettype are connected to the bus voltage when a
pro micro is used, but other controllers like the Elite-C (v4) connect this
pin to GPIO B0. This means that LEDs do not work by default for those
controllers.

This commit implements a fix for that by setting the B0 pin high.

* [Keyboard] Knobgoblin keyboard initial commit (#11664)

* Knobgoblin keyboard initial commit

New macropad initial commit. Keyboard and keymap

* corrected bracket and layout name

* attempting info file fix again

* info file line 33 hanging comma fix

* Update keyboards/knobgoblin/config.h

per fauxpark review

Co-authored-by: Ryan <[email protected]>

* Update keyboards/knobgoblin/readme.md

per fauxpark review

Co-authored-by: Ryan <[email protected]>

* Update keyboards/knobgoblin/readme.md

per fauxpark review

Co-authored-by: Ryan <[email protected]>

Co-authored-by: Ryan <[email protected]>

* [Keyboard] Add Quefrency Rev. 3 (#11578)

* Update default VIA layout option

* Add Quefrency Rev. 3

* Update readme

* Add GPL2 headers

* Update keyboards/keebio/quefrency/rev3/config.h

Co-authored-by: Ryan <[email protected]>

Co-authored-by: Ryan <[email protected]>

* Add support for the DURGOD Taurus K320 keyboard (#11399)

* Initial support for Durgod K320 with BootMagic Lite

- Adding missing files
- Add Unicode Map Support & new user keymap
- Remove personalized features from Default keymap
- Added Unicode Map to both Default and kuenhlee keymap.c
- Updated readme.md
- Added additional Fn Shortcut keys

* Additional support for Durgod K320

- Simplifying default keymap
- Renaming durgod_k320 => durgod/k320
- Removing copy of ST_NUCLEO64_F070RB from K320. Replacing with local board.h
- Adding Mac keyboard layout for K320 as alternative via Fn+F12
- Implementing Windows Key lock on K320
- Cleaning up duplicated core functionality
- Adding default_toggle_mac_windows keymap with:
  - Ability to toggle between Windows and MacOS layout
  - Mac Media Lock functionality.

* Updating K320 keymap readme

Co-authored-by: kuenhlee <[email protected]>

* [Keymap] tk planck keymap (#11400)

* tushark54 base layers

* init summer keymap

* drafted new keymap layers

* added new keymap

* v2.0 mvp

* added bracket modes

* added oneshot left modifiers

* added HYPER layer

* added audio

* added audio and more

* changed layer order

* swapped SUPER and LCTL keys

* added more tunes

* added more audio

* added tunes

* major layer modifications

* major changes to keymaps

* minor changes

* added venv macro

* merge conflict

* v3 mvp

* moved DEL to hyper layer and PANIC+ALT

* fn keys on hyper, macros on lower ii

* dynamic macros and audio options

* minor audio improvements

* osl timeouts

* manually added .vscode directory

* fixed upstream file

* fixed upstream file

* base and hyper layer changes

* modified tapping term

* added more macros

* added GPL2+ compatible license headers

* removed songs

* updated licenses

* added chmod macro

* [Keymap] Add 'mattir' keymap for the Kyria keyboard (#11428)

* First version of keymap

* cleaned up code, made some tweaks, added readme

* extended oled timeout

* resolved final issues, all features functional

* added some leader-key combos

* added missing RGB keys to layout diagram

* removed lines for older elite-c v3

* make filename lowercase

* add old update interval

* fix spacing

* pull retropad out of handwired and update readme.md (#11545)

Co-authored-by: Swiftrax <[email protected]>

* Remove `MIDI_ENABLE_STRICT` from keyboards' config.h (#11679)

* add get_matrix_scan_rate() to tmk_core/common/keyboard.c (#11489)

* [Docs] add qmk setup home parameter (#11451)

* Add rgblight_reload_from_eeprom() (#11411)

* Add rgblight_reset_from_eeprom()

* reset->reload

* Update feature_debounce_type.md of Japanese document. (#10596)

* Update Japanese document.

* fix table format.

* fix heading

* Update translation

* Apply suggestions from code review

Co-authored-by: Takeshi ISHII <[email protected]>

* Apply suggestions from code review

Co-authored-by: Takeshi ISHII <[email protected]>

* Update docs/ja/feature_debounce_type.md

Co-authored-by: Takeshi ISHII <[email protected]>

* Bump up comment tag

Co-authored-by: Takeshi ISHII <[email protected]>

* [Keyboard] A symmetric stagger keyboard: Angel (#11501)

* New symmetric stagger keyboard: Angel

* mac layout

* layout simplify

* Update keyboards/angel/info.json

Co-authored-by: Ryan <[email protected]>

* Update keyboards/angel/keymaps/default/keymap.c

Co-authored-by: Ryan <[email protected]>

* Update keyboards/angel/config.h

Co-authored-by: Ryan <[email protected]>

* Update keyboards/angel/readme.md

Co-authored-by: Ryan <[email protected]>

* Update keyboards/angel/rules.mk

Co-authored-by: Ryan <[email protected]>

* tab lang switch

* move to handwired and fix build instructions.

Co-authored-by: Ryan <[email protected]>

* [Keyboard] Adding Rev1 to afternoonlabs/breeze (#11611)

* Breeze Rev1

* Better bootmagic and reset

* typo

Co-authored-by: Eithan Shavit <[email protected]>

* [Keyboard] Adding Gust Macro Board (#11610)

* Adding Gust Macro Board

* Removing some rules

* Changing some rules

Co-authored-by: Eithan Shavit <[email protected]>

* [Keyboard] add sam's sg81m keyboard (#11624)

* new repo: create cmm.studio folder, add saka qmk firmware

new folder for cmm.studio line up keyboard
added saka68 keyboard qmk and via firmware support

* Update keyboards/cmm.studio/saka68/config.h

Co-authored-by: Ryan <[email protected]>

* Update keyboards/cmm.studio/saka68/rules.mk

Co-authored-by: Ryan <[email protected]>

* Update keyboards/cmm.studio/saka68/keymaps/via/rules.mk

Co-authored-by: Ryan <[email protected]>

* Update keyboards/cmm.studio/saka68/config.h

Co-authored-by: Ryan <[email protected]>

* fix on keymap, readme

fix on keymap, readme

* Update keyboards/cmm.studio/saka68/readme.md

Co-authored-by: Ryan <[email protected]>

* Update keyboards/cmm.studio/saka68/keymaps/default/keymap.c

Co-authored-by: Ryan <[email protected]>

* update vendor name with _ instead of .

update vendor name with _ instead of .

* Update readme.md

change the make format

* Update keyboards/cmm_studio/saka68/keymaps/default/keymap.c

Co-authored-by: Ryan <[email protected]>

* deleted some files from cmm.studio, changes to cmm_studio

deleted some files from cmm.studio, changes to cmm_studio

* Update readme.md

make command changed

* Update keyboards/cmm_studio/saka68/readme.md

Co-authored-by: Ryan <[email protected]>

* Update readme.md

added pic for pcb

* Update readme.md

* Update readme.md

* Update readme.md

* Update readme.md

* Update readme.md

* Update keyboards/cmm_studio/saka68/config.h

tested and does work now. deleting these lines

Co-authored-by: Ryan <[email protected]>

* Update readme.md

* Update readme.md

* Update readme.md

* Update readme.md

* Update readme.md

* Update readme.md

* Update readme.md

* Update keyboards/cmm_studio/saka68/readme.md

Co-authored-by: Ryan <[email protected]>

* Update readme.md

added use physical reset button instruction

* change to the cmm saka folder

making the changes to cmm saka firmware

seperated solder version firmware and hotswap version firmware

* Update readme.md

* Update readme.md

* Update readme.md

* Update readme.md

* Update readme.md

* Update readme.md

* Update readme.md

* Update readme.md

* Update readme.md

* Update readme.md

* change to the cmm saka hotswap folder

* add sam's sg81m keyboard

add sam's sg81m keyboard firmware

* Update keymap.c

* Update keymap.c

* update keymap

update default keymap and via keymap

* Update keymap.c

* Update keymap.c

* Update keymap.c

* Update keyboards/sam/sg81m/sg81m.c

Co-authored-by: Joel Challis <[email protected]>

* Update config.h

* Update config.h

Co-authored-by: Ryan <[email protected]>
Co-authored-by: Joel Challis <[email protected]>

* [Docs] Use HTTPS for images and links where possible (#11695)

* Add a <FEATURE>_SUPPORTED flag  (#9058)

* Initial attempt at allowing keyboards to indicate what features they do not support

* try to use a for loop instead

* Update disable_features.mk

Co-authored-by: Drashna Jaelre <[email protected]>

* add a few more features

* remove my test fixture

* disable things that make all:all suggested"

Co-authored-by: Zach White <[email protected]>
Co-authored-by: Drashna Jaelre <[email protected]>

* Fix missing F2 in top row in AoS TKL maps (#11735)

* [Keyboard] SplitKB's Zima (#11577)

Co-authored-by: Thomas Baart <[email protected]>
Co-authored-by: Joel Challis <[email protected]>

* quantum.c send char cleanups (#11743)

* [Docs] Japanese translation of internals_*.md (#10316)

* add git checkout internals_related.md translation

* update based on comment

* unify the end of sentence

* added limit to RGB brightness (#11759)

* [Keyboard] Add nullbitsco SCRAMBLE (#11078)

* Add SCRAMBLE

* Make requested changes to PR

* Add all layers to VIA keymap

Implement drashna's PR feedback in order to avoid random data within the layers in VIA.

* Make requested changes to PR

Implement fauxpark's PR feedback to clean up readme.md and rules.mk.

* Make changes based on PR feedback

-Changed VIA layers to enum
-Added info on how to enter the bootloader to readme

* Fix Ergosaurus default RGB_DI_PIN (#11634)

* Update RGB_DI_PIN to match breakout on pcb

* Wrap in safer define check

* CLI: Fix json flashing (#11765)

* add orthodeluxe keymap for Planck keyboard (#11077)

* add orthodeluxe keymap for Planck keyboard

* add licence header to config.h

* fix indentation

* add bootmagic lite and simplify code

* Knobgoblin info file fix (#11697)

Co-authored-by: Ryan <[email protected]>
Co-authored-by: Drashna Jaelre <[email protected]>

* Clean up KBD8X keyboard (#11565)

* Clean up KBD8X keyboard

* remove unneeded rules

* Fix DEBUG_MATRIX_SCAN_RATE on chibiOS when console is enabled (#11776)

* Fix DEBUG_MATRIX_SCAN_RATE on chibiOS when console is enabled

* update type in dprintf

Co-authored-by: Ryan <[email protected]>

Co-authored-by: Ryan <[email protected]>

* Fixing layer order for Breeze default keymap (#11779)

* [Keyboard] add koalafications (#11628)

* add koalafications

* fix keymap

* add oled

* oled stuff

* fix oled stuff

* add animation

* more oled stuff

* update rules.mk

* oled annimation

* change PID

* Update keyboards/handwired/swiftrax/koalafications/info.json

* Update keyboards/handwired/swiftrax/koalafications/readme.md

* Update iNETT Studio Square.X RGB Light (#11723)

* Add Caps Lock indicators support
* Fix 'a' flag error for RGB Light Mode

* Use num lock instead of caps lock for KBDPAD MKII LED (#11781)

* [Keyboard] Add LCK75 keyboard (#11493)

* Add lck75 keyboard

A 75% THT keyboard with an OLED and rotary encoder

* added info.json

* fixed rules.mk

* changed vendor id

* Update keyboards/lck75/config.h

Co-authored-by: Drashna Jaelre <[email protected]>

* Update keyboards/lck75/config.h

Co-authored-by: Drashna Jaelre <[email protected]>

* Update keyboards/lck75/keymaps/default/keymap.c

Co-authored-by: Drashna Jaelre <[email protected]>

* Update keyboards/lck75/keymaps/default/keymap.c

moved code to the rules.mk folder

Co-authored-by: Drashna Jaelre <[email protected]>

* Update rules.mk

moved oled driver enable to rules.mk code

* Update keyboards/lck75/config.h

Co-authored-by: Drashna Jaelre <[email protected]>

* Update oled.c

id like to keep the copyright there as it's my friend that helped me with the OLED specifically.  also updated the old_task_user

* Update keyboards/lck75/oled.c

Co-authored-by: Ryan <[email protected]>

* Update keyboards/lck75/rules.mk

Co-authored-by: Ryan <[email protected]>

* Update keyboards/lck75/rules.mk

Co-authored-by: Ryan <[email protected]>

* Update keyboards/lck75/rules.mk

Co-authored-by: Ryan <[email protected]>

* Update rules.mk

* merged oled.c code into keymap.c file

tested and works correctly on my board

* merged code from this file into the keymap.c file

this file is no longer needed

Co-authored-by: Drashna Jaelre <[email protected]>
Co-authored-by: Ryan <[email protected]>

* Improve Pointing Device report sending (#11064)

* Improve Pointing Device report sending

* Hide old report behind preprocessors too

* put host_mouse_send() in curly brackets

* Remove POINTING_DEVICE_ALWAYS_SEND_REPORT functionality

* Fix typo

* fix function ref in docs

Co-authored-by: James Young <[email protected]>

Co-authored-by: James Young <[email protected]>

* Fix line endings for LCK75 kb files (#11784)

* Xyverz bastyl (#11662)

Co-authored-by: Ian Sterling <[email protected]>

* [Keyboard] add primus75 keyboard (#11440)

* add primus75 keyboard

* Update keyboards/iLumkb/primus75/info.json

Co-authored-by: Drashna Jaelre <[email protected]>

* Update keyboards/iLumkb/primus75/keymaps/default/keymap.c

Co-authored-by: Drashna Jaelre <[email protected]>

* Update keyboards/iLumkb/primus75/keymaps/via/keymap.c

Co-authored-by: Drashna Jaelre <[email protected]>

* Update keyboards/iLumkb/primus75/keymaps/default/keymap.c

Co-authored-by: Drashna Jaelre <[email protected]>

* Update keyboards/iLumkb/primus75/keymaps/via/keymap.c

Co-authored-by: Drashna Jaelre <[email protected]>

* Update keyboards/iLumkb/primus75/primus75.h

Co-authored-by: Drashna Jaelre <[email protected]>

* Update keymap.c

* Update keyboards/iLumkb/primus75/rules.mk

Co-authored-by: Ryan <[email protected]>

* Update keyboards/iLumkb/primus75/rules.mk

Co-authored-by: Ryan <[email protected]>

* Update keyboards/iLumkb/primus75/readme.md

Co-authored-by: Ryan <[email protected]>

* Update keyboards/iLumkb/primus75/config.h

Co-authored-by: Ryan <[email protected]>

* Update keymap.c

* Update keymap.c

* Update keyboards/iLumkb/primus75/keymaps/default/keymap.c

Co-authored-by: Ryan <[email protected]>

* Update keyboards/iLumkb/primus75/readme.md

Co-authored-by: James Young <[email protected]>

* Rename keyboards/iLumkb/primus75/config.h to keyboards/ilumkbprimus75config.h

* Rename keyboards/ilumkbprimus75config.h to keyboards/ilumkbprimus75/config.h

* Rename keyboards/ilumkbprimus75/config.h to keyboards/ilumkb/primus75/config.h

* Rename keyboards/iLumkb/primus75/info.json to keyboards/ilumkb/primus75/info.json

* Rename keyboards/iLumkb/primus75/primus75.c to keyboards/ilumkb/primus75/primus75.c

* Rename keyboards/iLumkb/primus75/primus75.h to keyboards/ilumkb/primus75/primus75.h

* Rename keyboards/iLumkb/primus75/readme.md to keyboards/ilumkb/primus75/readme.md

* Rename keyboards/iLumkb/primus75/rules.mk to keyboards/ilumkb/primus75/rules.mk

* Rename keyboards/iLumkb/primus75/keymaps/default/keymap.c to keyboards/ilumkb/primus75/keymaps/default/keymap.c

* Rename keyboards/iLumkb/primus75/keymaps/via/rules.mk to keyboards/ilumkb/primus75/keymaps/via/rules.mk

* Rename keyboards/iLumkb/primus75/keymaps/via/keymap.c to keyboards/ilumkb/primus75/keymaps/via/keymap.c

* Update keyboards/ilumkb/primus75/keymaps/default/keymap.c

Co-authored-by: James Young <[email protected]>

* Update keyboards/ilumkb/primus75/info.json

Co-authored-by: James Young <[email protected]>

* Update keyboards/ilumkb/primus75/keymaps/via/keymap.c

Co-authored-by: James Young <[email protected]>

* Update keyboards/ilumkb/primus75/info.json

Co-authored-by: James Young <[email protected]>

Co-authored-by: Drashna Jaelre <[email protected]>
Co-authored-by: Ryan <[email protected]>
Co-authored-by: James Young <[email protected]>

* [Keyboard] Add KL-90 (#11494)

* add kikoslab kl90

* fix info.json

* Update keyboards/kikoslab/kl90/rules.mk

Co-authored-by: Joel Challis <[email protected]>

* Update keyboards/kikoslab/kl90/info.json

Co-authored-by: Joel Challis <[email protected]>

* update info.json

* fix layout macro

* add support for hotswap space

Co-authored-by: Swiftrax <[email protected]>
Co-authored-by: Joel Challis <[email protected]>

* [Keyboard] KBDfans Bella RGB ANSI and Bella RGB ISO (#11438)

* add bella rgb keyboards

* Update rgb_iso.c

* fix error

* Update rgb_iso.h

* Update keyboards/kbdfans/bella/rgb/rules.mk

* Update keyboards/kbdfans/bella/rgb_iso/rules.mk

* Update keymap.c

* Update keyboards/kbdfans/bella/rgb/info.json

* Update keyboards/kbdfans/bella/rgb_iso/info.json

* Update keyboards/kbdfans/bella/rgb_iso/config.h

* Update keyboards/kbdfans/bella/rgb/config.h

* Update keyboards/kbdfans/bella/rgb_iso/rules.mk

* Update keyboards/kbdfans/bella/rgb_iso/rules.mk

* Update keyboards/kbdfans/bella/rgb_iso/rules.mk

* Update keyboards/kbdfans/bella/rgb/rules.mk

* Update keyboards/kbdfans/bella/rgb/rules.mk

* Update keyboards/kbdfans/bella/rgb/rules.mk

* Update rgb_iso.c

* Update rgb.c

* Update rgb_iso.c

* Update rgb_iso.h

* Update keyboards/kbdfans/bella/rgb/config.h

* Update keyboards/kbdfans/bella/rgb/rgb.h

* Update keyboards/kbdfans/bella/rgb/info.json

* Update keyboards/kbdfans/bella/rgb/info.json

* Update keyboards/kbdfans/bella/rgb/keymaps/default/keymap.c

* Update keyboards/kbdfans/bella/rgb_iso/keymaps/via/keymap.c

* Update keyboards/kbdfans/bella/rgb_iso/keymaps/via/keymap.c

* Update keyboards/kbdfans/bella/rgb_iso/readme.md

* Update keyboards/kbdfans/bella/rgb_iso/readme.md

* Update keyboards/kbdfans/bella/rgb_iso/readme.md

* Apply suggestions from code review

kbdfans/bella/rgb: Change remaining instances of LAYOUT_all to LAYOUT

* Apply suggestions from code review

kbdfans/bella/rgb: update readme

- update keyboard name
- include flashing and bootloader instructions

* Apply suggestions from code review

kbdfans/bella/rgb_iso: update keyboard name

Changes remaining instances of "BELLA_RGB_ISO" to "BELLA RGB ISO".

* Apply suggestions from code review

kbdfans/bella/rgb_iso: Change LAYOUT_all to LAYOUT

* Apply suggestions from code review

kbdfans/bella/rgb_iso: Move ISO Enter's keycode to home row per QMK standard

* [Keymap] add ghidalgo93 for kyria (#11663)

* adding kyria/rev1 keymap

* adding both hand config

* Apply suggestions from code review

* Apply suggestions from code review

* Add VIA support for claw44 (#11677)

* add via keymaps for claw44

* Update keyboards/claw44/keymaps/via/config.h

* Update keyboards/claw44/keymaps/via-oled/config.h

* Update keyboards/claw44/keymaps/via-oled/keymap.c

* Update keyboards/claw44/keymaps/via/keymap.c

* Update keyboards/claw44/keymaps/via-oled/keymap.c

* Update keyboards/claw44/keymaps/via/keymap.c

* Applied the review to other keymaps.

* Update keyboards/claw44/keymaps/oled/keymap.c

* Update keyboards/claw44/keymaps/default/keymap.c

* Update keyboards/claw44/keymaps/via-oled/keymap.c

* Update keyboards/claw44/keymaps/default/keymap.c

* Update keyboards/claw44/keymaps/via-oled/keymap.c

* Update keyboards/claw44/keymaps/via-oled/keymap.c

* Update keyboards/claw44/keymaps/via/keymap.c

* Update keyboards/claw44/keymaps/via/keymap.c

* Update keyboards/claw44/keymaps/via/keymap.c

* Update keyboards/claw44/keymaps/via/keymap.c

* remove via-oled

* change vendor ID for yfuku

* add readme.md for rev1

* Update keyboards/claw44/rev1/readme.md

* Update keyboards/claw44/rev1/readme.md

* Update keyboards/claw44/rev1/readme.md

* [Keyboard] add The Galleon by swiftrax (#11700)

* initial addition

* fix keymap / keyboard.h

* add animation

* change pid

* fix layout macro

* Apply suggestions from code review

* Update keyboards/handwired/swiftrax/the_galleon/info.json

* move wpm enable

* [Keyboard] add Pursuit40 PCB for Panc40 (#11683)

* added Pursuit40 PCB for Panc40

Pursuit40 is another PCB option for the Panc40 that was sold on Panc.co/store

* added via support

* Apply suggestions from code review

* Apply suggestions from code review

* deleted extra row in VIA keymap

sorry about that - extra row was a holdover from a copy-paste

* deleted commented extra row

extra row was a holdover from a copy-paste

* updated VIA keymap

empty layer added

* fixed bug

* Apply suggestions from code review

committed

* [Keyboard] Adding YMDK Wings Keyboard (#11693)

* Add files via upload

* Add files via upload

* Update rules.mk

* Update rules.mk

* Update info.json

* Update wings.h

* Update info.json

* Update info.json

* Update info.json

* Update info.json

* Update keyboards/ymdk/wings/info.json

Co-authored-by: Joel Challis <[email protected]>

* Update keyboards/ymdk/wings/keymaps/via/keymap.c

Co-authored-by: Drashna Jaelre <[email protected]>

* Update keyboards/ymdk/wings/keymaps/via/keymap.c

Co-authored-by: James Young <[email protected]>

* Update keyboards/ymdk/wings/keymaps/via/keymap.c

Co-authored-by: James Young <[email protected]>

* Update keyboards/ymdk/wings/keymaps/via/keymap.c

Co-authored-by: James Young <[email protected]>

* Update keyboards/ymdk/wings/keymaps/via/keymap.c

Co-authored-by: James Young <[email protected]>

* Update keyboards/ymdk/wings/keymaps/default/keymap.c

Co-authored-by: James Young <[email protected]>

* Update keyboards/ymdk/wings/info.json

Co-authored-by: James Young <[email protected]>

* Update keyboards/ymdk/wings/wings.h

Co-authored-by: James Young <[email protected]>

* Update keyboards/ymdk/wings/readme.md

Co-authored-by: James Young <[email protected]>

* Update keyboards/ymdk/wings/readme.md

Co-authored-by: James Young <[email protected]>

* Update keyboards/ymdk/wings/info.json

Co-authored-by: James Young <[email protected]>

* Update keyboards/ymdk/wings/keymaps/default/keymap.c

Co-authored-by: James Young <[email protected]>

Co-authored-by: Joel Challis <[email protected]>
Co-authored-by: Drashna Jaelre <[email protected]>
Co-authored-by: James Young <[email protected]>

* [Keyboard] add latin17rgb (#11680)

* Create readme.md

* Add files via upload

* Create keymap.c

* Create keymap.c

* Create rules.mk

* Update config.h

* Update rules.mk

* Update keyboards/latin17rgb/keymaps/default/keymap.c

* Update keyboards/latin17rgb/keymaps/via/keymap.c

* Update keyboards/latin17rgb/latin17rgb.h

* Update keyboards/latin17rgb/keymaps/default/keymap.c

* Update keyboards/latin17rgb/keymaps/via/keymap.c

* Update keyboards/latin17rgb/rules.mk

* Update keyboards/latin17rgb/info.json

* Delete latin17RGB.json

* Update info.json

* Update keymap.c

* Update keymap.c

* Update info.json

* Update latin17rgb.h

* Update latin17rgb.h

* Update keymap.c

* Update keymap.c

* Update latin17rgb.h

* Update keyboards/latin17rgb/readme.md

* Update keyboards/latin17rgb/readme.md

* Update keyboards/latin17rgb/rules.mk

* Update keyboards/latin17rgb/rules.mk

* Update keyboards/latin17rgb/info.json

* Update keyboards/latin17rgb/rules.mk

* Update keyboards/latin17rgb/latin17rgb.h

* Update keyboards/latin17rgb/rules.mk

* Update keyboards/latin17rgb/readme.md

* Update keyboards/latin17rgb/keymaps/default/keymap.c

* Update keyboards/latin17rgb/keymaps/via/keymap.c

* Update latin17rgb.c

* Update latin17rgb.c

* Update keyboards/latin17rgb/latin17rgb.c

* [Keyboard] Add VIA support to v60 Type R (#11758)

* Add support VIA support to v60 Type R

* Update keyboards/v60_type_r/config.h

Revert combining product and manufacturer

Co-authored-by: Ryan <[email protected]>

* Update keyboards/v60_type_r/keymaps/via/keymap.c

Remove empty `led_set_user` function

Co-authored-by: Ryan <[email protected]>

* Update keyboards/v60_type_r/rules.mk

Don't enable bootmagic lite

Co-authored-by: Ryan <[email protected]>

* Add missing empty layers for VIA

* Update keyboards/v60_type_r/rules.mk

Fix comment formatting

Co-authored-by: Ryan <[email protected]>

* Update the VENDOR_ID

Co-authored-by: Ryan <[email protected]>

* [Keyboard] Fix the LED's ID of ISSI for MJ64 REV2 (#11760)

* Add Z70Ultra which is a Hotsawp RGB 65% keyboard

* Update keyboards/melgeek/z70ultra/z70ultra.h

Co-authored-by: Ryan <[email protected]>

* Update keyboards/melgeek/z70ultra/keymaps/default/keymap.c

Co-authored-by: Ryan <[email protected]>

* Update keyboards/melgeek/z70ultra/keymaps/via/keymap.c

Co-authored-by: Ryan <[email protected]>

* Update keyboards/melgeek/z70ultra/z70ultra.c

Co-authored-by: Ryan <[email protected]>

* Update keyboards/melgeek/z70ultra/readme.md

Co-authored-by: Ryan <[email protected]>

* Update keyboards/melgeek/z70ultra/rev1/rules.mk

Co-authored-by: Ryan <[email protected]>

* Update keyboards/melgeek/z70ultra/z70ultra.c

Co-authored-by: Ryan <[email protected]>

* Update keyboards/melgeek/z70ultra/z70ultra.c

Co-authored-by: Ryan <[email protected]>

* Update keyboards/melgeek/z70ultra/z70ultra.c

Co-authored-by: Ryan <[email protected]>

* Update keyboards/melgeek/z70ultra/z70ultra.h

Co-authored-by: Ryan <[email protected]>

* Update readme.md

* Update info.json

update the name of layout to consistent the keyboard.

* Update keyboards/melgeek/z70ultra/z70ultra.c

Co-authored-by: Ryan <[email protected]>

* Update keyboards/melgeek/z70ultra/z70ultra.c

Co-authored-by: Ryan <[email protected]>

* Update keyboards/melgeek/z70ultra/info.json

Co-authored-by: Ryan <[email protected]>

* Update keyboards/melgeek/z70ultra/keymaps/default/keymap.c

Co-authored-by: Ryan <[email protected]>

* Update keyboards/melgeek/z70ultra/keymaps/via/keymap.c

Co-authored-by: Ryan <[email protected]>

* Add Z70Ultra

* Support Z70Ultra
  [Modified] info.json to support two different layouts
  [Add]      rules.mk to support default folder

* Update keyboards/melgeek/z70ultra/rev1/rules.mk

Co-authored-by: Ryan <[email protected]>

* Update keyboards/melgeek/z70ultra/config.h

Co-authored-by: Ryan <[email protected]>

* remove excessive arguments from LAYOUT_split_space

* Update keyboards/melgeek/z70ultra/info.json

Co-authored-by: James Young <[email protected]>

* Update keyboards/melgeek/z70ultra/info.json

Co-authored-by: James Young <[email protected]>

* Update keyboards/melgeek/z70ultra/keymaps/default/keymap.c

Co-authored-by: James Young <[email protected]>

* Update keyboards/melgeek/z70ultra/z70ultra.h

Co-authored-by: James Young <[email protected]>

* Update keyboards/melgeek/z70ultra/z70ultra.h

Co-authored-by: Jame…
BorisTestov pushed a commit to BorisTestov/qmk_firmware that referenced this pull request May 23, 2024
* Initial attempt at allowing keyboards to indicate what features they do not support

* try to use a for loop instead

* Update disable_features.mk

Co-authored-by: Drashna Jaelre <[email protected]>

* add a few more features

* remove my test fixture

* disable things that make all:all suggested"

Co-authored-by: Zach White <[email protected]>
Co-authored-by: Drashna Jaelre <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants