Don't compile outputselect.c if Bluetooth is disabled #9356
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zvecr
approved these changes
Jun 10, 2020
drashna
approved these changes
Jun 15, 2020
noroadsleft
pushed a commit
that referenced
this pull request
Jul 18, 2020
noroadsleft
pushed a commit
that referenced
this pull request
Jul 26, 2020
noroadsleft
pushed a commit
that referenced
this pull request
Jul 31, 2020
noroadsleft
pushed a commit
that referenced
this pull request
Aug 11, 2020
noroadsleft
pushed a commit
that referenced
this pull request
Aug 27, 2020
noroadsleft
pushed a commit
that referenced
this pull request
Aug 29, 2020
nicocesar
pushed a commit
to nicocesar/qmk_firmware
that referenced
this pull request
Sep 6, 2020
drashna
pushed a commit
to zsa/qmk_firmware
that referenced
this pull request
Sep 30, 2020
kjganz
pushed a commit
to kjganz/qmk_firmware
that referenced
this pull request
Oct 28, 2020
BorisTestov
pushed a commit
to BorisTestov/qmk_firmware
that referenced
this pull request
May 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If Bluetooth is disabled we should always output over USB, so the
where_to_send()call and early return can safely be placed behind theBLUETOOTH_ENABLEifdef.Saves about 90 bytes on avr-gcc 8.4.0 with
gh60/satan:default, should be no change for boards with Bluetooth enabled.Types of Changes
Issues Fixed or Closed by This PR
Checklist