Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Haptic and solenoid cleanup #9700

Merged
merged 14 commits into from
Oct 17, 2020
Merged

Haptic and solenoid cleanup #9700

merged 14 commits into from
Oct 17, 2020

Commits on Sep 13, 2020

  1. solenoid: remove two functions that do nothing. 

    These functions modify the argument, and so they do nothing.

Note: versions of these functions exist in mtdjr's user folder,
however to core solenoid support and mtdjr user-specific solenoid
support are exclusive (only one can be used at a time).

So removing these confusing functions does no harm.
    @purdeaandrei
    purdeaandrei committed Sep 13, 2020
    Configuration menu
    Copy the full SHA
    f8505aa View commit details
    Browse the repository at this point in the history

  2. solenoid: bugfix: don't allow dwell time to go 1ms below minimum time. 

    The previous code allowed dwell time to go 1ms below the configured minimum.
This change corrects it.
    @purdeaandrei
    purdeaandrei committed Sep 13, 2020
    Configuration menu
    Copy the full SHA
    9fe10b6 View commit details
    Browse the repository at this point in the history

  3. solenoid: bugfix: when incrementing above maximum dwell time, jump ba… 

    …ck to minimum, not to 1

The previous code used to jump back to 1, which might be way under the configured minimum setting.
    @purdeaandrei
    purdeaandrei committed Sep 13, 2020
    Configuration menu
    Copy the full SHA
    5d4796e View commit details
    Browse the repository at this point in the history

  4. solenoid: bugfix: on startup actually use the eeprom-stored dwell-time 

    This is because the dwell time is stored in two variables.
    @purdeaandrei
    purdeaandrei committed Sep 13, 2020
    Configuration menu
    Copy the full SHA
    f106ce5 View commit details
    Browse the repository at this point in the history

  5. solenoid: bugfix: on haptic_reset, actually use the newly set default… 

    … dwell time.

This is needed because dwell time is configured in two variables.
    @purdeaandrei
    purdeaandrei committed Sep 13, 2020
    Configuration menu
    Copy the full SHA
    6055e03 View commit details
    Browse the repository at this point in the history

  6. solenoid: on HPT_RST set buzz to a default value

    @purdeaandrei
    purdeaandrei committed Sep 13, 2020
    Configuration menu
    Copy the full SHA
    afeef88 View commit details
    Browse the repository at this point in the history

  7. solenoid: buzz: reworked to make more configurable. Previous behaviou… 

    …r maintained.
    @purdeaandrei
    purdeaandrei committed Sep 13, 2020
    Configuration menu
    Copy the full SHA
    36833b2 View commit details
    Browse the repository at this point in the history

  8. solenoid: documentation: clarify meaning of dwell time

    @purdeaandrei
    purdeaandrei committed Sep 13, 2020
    Configuration menu
    Copy the full SHA
    fffefab View commit details
    Browse the repository at this point in the history

  9. solenoid: add feature SOLENOID_DWELL_STEP_SIZE

    @purdeaandrei
    purdeaandrei committed Sep 13, 2020
    Configuration menu
    Copy the full SHA
    0f87c94 View commit details
    Browse the repository at this point in the history

  10. solenoid: documentation: added note about the precision of the soleno… 

    …id time settings
    @purdeaandrei
    purdeaandrei committed Sep 13, 2020
    Configuration menu
    Copy the full SHA
    84354e8 View commit details
    Browse the repository at this point in the history

  11. haptic: Correctly call haptic_reset when eeprom is corrupt.

    @purdeaandrei
    purdeaandrei committed Sep 13, 2020
    Configuration menu
    Copy the full SHA
    e8d5b11 View commit details
    Browse the repository at this point in the history

  12. haptic: improve what happens if haptic is enabled without erasing eeprom

    @purdeaandrei
    purdeaandrei committed Sep 13, 2020
    Configuration menu
    Copy the full SHA
    56b2a32 View commit details
    Browse the repository at this point in the history

  13. haptic: improve what happens if solenoid is enabled without erasing e… 

    …eprom
    @purdeaandrei
    purdeaandrei committed Sep 13, 2020
    Configuration menu
    Copy the full SHA
    8043609 View commit details
    Browse the repository at this point in the history

  14. drivers/haptic: fix compilation issue, when haptic is enabled, but so… 

    …lenoid isn't
    @purdeaandrei
    purdeaandrei committed Sep 13, 2020
    Configuration menu
    Copy the full SHA
    d5c748e View commit details
    Browse the repository at this point in the history