Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Autoflash improvements #257

Merged
merged 3 commits into from
Apr 29, 2021
Merged

Autoflash improvements #257

merged 3 commits into from
Apr 29, 2021

Conversation

fauxpark
Copy link
Member

Description

  • Fixes some UI inconsistencies surrounding enabling/disabling of the Flash, Exit DFU and Clear EEPROM buttons.
  • Auto-flash now works again on macOS.
  • Removed "Flash when ready" button on Windows. Seems to be a one-time autoflash? The remaining checkbox could potentially do double duty here, using the indeterminate state and clearing once a single flash is complete.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Documentation

Issues Fixed or Closed by This PR

@fauxpark fauxpark requested a review from a team April 13, 2021 07:46
@fauxpark fauxpark requested review from nooges and a team April 29, 2021 04:09
@fauxpark fauxpark merged commit 102881c into qmk:master Apr 29, 2021
@fauxpark fauxpark deleted the autoflash-improvements branch April 29, 2021 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nooges nooges nooges approved these changes

Assignees
No one assigned
Labels
bug enhancement macos windows
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Auto-Flash to Elite-C not working on Mac OSX Catalina
2 participants
@fauxpark @nooges