Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[macOS] Bump deployment target to 10.14 #275

Merged
merged 1 commit into from
Jul 7, 2021
Merged

[macOS] Bump deployment target to 10.14 #275

merged 1 commit into from
Jul 7, 2021

Conversation

fauxpark
Copy link
Member

@fauxpark fauxpark commented Jul 6, 2021

Description

  • Bump deployment target to 10.14 as Homebrew only supports Mojave and higher now (the binaries may still be from High Sierra bottles but that can be fixed later)
  • Turn off annoying Metal API validation logging, we don't use it
  • Set CFBundleVersion to the same value as CFBundleShortVersionString; Sparkle will need this

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Documentation

Issues Fixed or Closed by This PR

@fauxpark fauxpark requested a review from a team July 6, 2021 10:24
@fauxpark fauxpark merged commit d891941 into qmk:master Jul 7, 2021
@fauxpark fauxpark deleted the macos-bump-deployment-target branch July 7, 2021 01:02
@fauxpark fauxpark mentioned this pull request Aug 1, 2021
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drashna drashna drashna approved these changes

Assignees
No one assigned
Labels
enhancement macos
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fauxpark @drashna