Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[macOS] Logging refactor #340

Merged
merged 6 commits into from
Apr 15, 2022
Merged

[macOS] Logging refactor #340

merged 6 commits into from
Apr 15, 2022

Conversation

fauxpark
Copy link
Member

@fauxpark fauxpark commented Apr 11, 2022 •
edited
Loading

Description

Sister PR #339

  • Replaced Printing class with new subclass of NSTextView which handles all the logging internally
  • Defined light and dark colour schemes for log box
  • Added some new MessageTypes for more fine-grained display
  • Improved HID report callback to only fire the delegate when a complete line has been received
  • Slight cleanups of pbxproj file

image
image

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Documentation

Issues Fixed or Closed by This PR

@fauxpark fauxpark requested a review from a team April 11, 2022 13:05
@fauxpark fauxpark merged commit 0f62767 into qmk:master Apr 15, 2022
@fauxpark fauxpark deleted the log-box-refactor-macos branch April 15, 2022 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nooges nooges nooges approved these changes

Assignees
No one assigned
Labels
enhancement macos
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fauxpark @nooges