Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[macOS] LUFA-MS: return early on error #345

Merged
merged 1 commit into from
Apr 19, 2022
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion macos/QMK Toolbox/USB/Bootloader/LUFAMSDevice.m
Original file line number Diff line number Diff line change
Expand Up @@ -24,14 +24,16 @@ -(void)flashWithMCU:(NSString *)mcu file:(NSString *)file {
[self printMessage:[NSString stringWithFormat:@"Deleting %@...", destFile] withType:MessageType_Command];
if (![[NSFileManager defaultManager] removeItemAtPath:destFile error:&error]) {
[self printMessage:[NSString stringWithFormat:@"IO ERROR: %@", [error localizedDescription]] withType:MessageType_Error];
return;
}

[self printMessage:[NSString stringWithFormat:@"Copying %@ to %@...", file, destFile] withType:MessageType_Command];
if (![[NSFileManager defaultManager] copyItemAtPath:file toPath:destFile error:&error]) {
[self printMessage:[NSString stringWithFormat:@"IO ERROR: %@", [error localizedDescription]] withType:MessageType_Error];
return;
}

[self printMessage:@"Done, please eject drive now." withType:MessageType_Info];
[self printMessage:@"Done, please eject drive now." withType:MessageType_Bootloader];
} else {
[self printMessage:@"Only firmware files in .bin format can be flashed with this bootloader!" withType:MessageType_Error];
}
Expand Down