Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add squeezing operator #114

Merged
merged 3 commits into from
Jul 5, 2023
Merged

Add squeezing operator #114

merged 3 commits into from
Jul 5, 2023

Conversation

akirakyle
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Jun 30, 2023

Codecov Report

Merging #114 (2d9282a) into master (ab9995f) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #114      +/-   ##
==========================================
+ Coverage   93.60%   93.61%   +0.01%     
==========================================
  Files          25       25              
  Lines        3067     3072       +5     
==========================================
+ Hits         2871     2876       +5     
  Misses        196      196              
Impacted Files Coverage Δ
src/QuantumOpticsBase.jl 100.00% <ø> (ø)
src/fock.jl 98.75% <100.00%> (+0.08%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Krastanov
Copy link
Collaborator

@akirakyle, a couple of suggestions on this:

@akirakyle
Copy link
Contributor Author

akirakyle commented Jul 5, 2023

given the work you are doing in Use FastExpm.jl for matrix exponential of SparseSuperOperator #112, should this use a better non-dense exponentiation? Maybe we should wait on Use FastExpm.jl for matrix exponential of SparseSuperOperator #112 before deciding how to proceed here?

Like displace which is always nonzero everywhere, squeeze always nonzero in half the entries, so I think a dense representation will always be more efficient. However, it may be that using one of the other methods discussed in #112 would be faster than base.exp which is using an eigendecomposition according to its docstring. If I'm going to do some benchmarking, it would be worthwhile to include these two cases as they may warrant a different method than for exponentiation a typical lindbladian.

@Krastanov
Copy link
Collaborator

Yup, that is a good reason to merge as is. We can investigate improvements down the line after we know more from #112. This will be merged shortly.

@Krastanov Krastanov merged commit 138e019 into qojulia:master Jul 5, 2023
8 of 9 checks passed
@akirakyle akirakyle deleted the squeeze branch July 21, 2023 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants