Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Role is missing #8

Closed
brendon opened this issue Apr 3, 2013 · 4 comments · Fixed by #10
Closed

Role is missing #8

brendon opened this issue Apr 3, 2013 · 4 comments · Fixed by #10

Comments

@brendon
Copy link
Collaborator

brendon commented Apr 3, 2013

Hi there, for some reason the Role attribute is missing as something that can be set. Is this the place to request that it be added in?

@qoobaa
Copy link
Owner

qoobaa commented Apr 3, 2013

Sure. Give me a PR, I'll merge it.

@brendon
Copy link
Collaborator Author

brendon commented Apr 3, 2013

Cool. I managed to get around it by adding the field manually

maker.add_field ::Vcard::DirectoryInfo::Field.create('ROLE', ::Vcard.encode_text(@contact.role))

But if you'd still like the pull request let me know. Do you need tests with it also?

@qoobaa
Copy link
Owner

qoobaa commented Apr 3, 2013

Tests would be nice.

@brendon
Copy link
Collaborator Author

brendon commented Apr 5, 2013

Thanks I'll get on to this when I get some spare time :)

On Wed, Apr 3, 2013 at 9:48 PM, Kuba Kuźma [email protected] wrote:

Tests would be nice.


Reply to this email directly or view it on GitHubhttps://github.com//issues/8#issuecomment-15825268
.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants