Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eliminate carriage returns when encoding text #14

Merged
merged 3 commits into from
Jun 19, 2013
Merged

Eliminate carriage returns when encoding text #14

merged 3 commits into from
Jun 19, 2013

Conversation

m1foley
Copy link
Collaborator

@m1foley m1foley commented Jun 19, 2013

Fixes issues #9 and #13.

From RFC 6350 section 4.1 ("TEXT"):

A formatted text line break in a text value type MUST be represented as the character sequence backslash (U+005C) followed by a Latin small letter n (U+006E) or a Latin capital letter N (U+004E), that is, "\n" or "\N".

@brendon, can you review & make sure this solves the problem you first reported?

@qoobaa qoobaa merged commit 302dba1 into qoobaa:master Jun 19, 2013
@qoobaa
Copy link
Owner

qoobaa commented Jun 19, 2013

Merged. Thanks a lot.

@brendon
Copy link
Collaborator

brendon commented Jun 19, 2013

Hi @m1foley, that did the trick. Thanks heaps for looking into that for me. Your solution is a lot more succinct!

For some reason @qoobaa, my add_role change hasn't come through into the gem. Are you able to check this out?

@brendon
Copy link
Collaborator

brendon commented Jun 19, 2013

#15

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants