Allow to ignore invalid fields #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In some cases you do not want to loose all data if you have only one invalid field in encoded VCard (especially for multi-contact vcards). This change add two config parameters ::Vcard.configuration.raise_on_invalid_line (default true). When this parameter is set to true, decode will raise ::Vcard::InvalidEncodingError if found a field that encoded incorrectly (default behavior). When raise_on_invalid_line = false, exception will not be raised but field will be marked as invalid. With parameter ::Vcard.configuration.ignore_invalid_vcards you can define behavior for invalid fields. If ignore_invalid_vcards = true, then ::Vcard.decode will ignore a vcard that have at least one incorrect field. With ignore_invalid_vcards = false, vcard only invalid fields will be ignored, but vcard will be added to list, returned by .decode
brendon
requested changes
Nov 21, 2016
| @fields = [] | ||
|
|
||
| fields.each do |f| | ||
| raise ArgumentError, "fields must be an array of DirectoryInfo::Field objects" unless f.kind_of? DirectoryInfo::Field |
There was a problem hiding this comment.
Should there be a condition on this line regarding whether or not to raise?
There was a problem hiding this comment.
I didn't change behavior in this place. It looks for me like a strict type check and it's not clear for me why it needed here.
| @ignore_invalid_vcard = true | ||
| end | ||
|
|
||
| private |
There was a problem hiding this comment.
Can you remove this given there are no private methods?
brendon
approved these changes
Nov 22, 2016
|
Thanks again Anton :) This is all merged now. @qoobaa, I can release a new gem version if you like. You just need to grant me access to Rubygems. |
|
@brendon done |
|
@solenko, this has been released as |
|
Thanks @qoobaa :) |
|
@brendon thank you for fast reaction and especially for fixes of my English :) |
|
You're welcome :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some cases you do not want to loose all data if you have only one invalid field in encoded VCard (especially for multi-contact vcards).
This change add two config parameters
Vcard.configuration.raise_on_invalid_line (default true).When this parameter is set to true, decode will raise
Vcard::InvalidEncodingErrorif found a field that encoded incorrectly (default behavior).When
raise_on_invalid_line = false, exception will not be raised but field will be marked as invalid.With parameter
Vcard.configuration.ignore_invalid_vcardsyou can define behavior for invalid fields.If
ignore_invalid_vcards = true, thenVcard.decodewill ignore a vcard that have at least one incorrect field.With
ignore_invalid_vcards = false, vcard only invalid fields will be ignored, but vcard will be added to list, returned by.decode