Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

depthWrite as part of schema #25

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

arthurmougin
Copy link

When working on #20, I noticed that switching depthWrite from false to true would improve drastically Occlusion issues at the cost of some transparency spillage.
So it could be interesting to have it as an option when those spills are acceptable.

Example with depthWrite: false
image

Example with depthWrite: true
image

Please understand that it is not a proper #20 fix, just a workaround while a proper implementation is in progress

usefull for children that may have to much spill when combined with depthWrite:true
@arthurmougin
Copy link
Author

arthurmougin commented Dec 8, 2023

I extended the initial commit with a new one that fix the limitations encountered in self occlusion.

previously :
image

now :
image

With this fix, and some proper scene management and splatting cleaning (removing ghost blobs), you can get an almost perfect occlusion !

to be pushed as part of #20

encapsulating the fetch into an autoretry loop spaced by 1s delay
Parsing logic has been moved into new parseData function
@kfarr
Copy link
Contributor

kfarr commented Dec 20, 2023

Thanks @arthurmougin for your work on this! @quadjr I can confirm this works as expected and we have done our best to ensure that the default settings are not affected, so that a user has to explicitly choose to enable these sorting options.

@koktavy
Copy link

koktavy commented Jan 22, 2024

@quadjr have you had a chance to review here? Excited to work with this. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants