Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extend namedCodesToUnicode to allow own HTML character references #376

Open
dexster opened this issue Mar 5, 2021 · 2 comments
Open

Extend namedCodesToUnicode to allow own HTML character references #376

dexster opened this issue Mar 5, 2021 · 2 comments

Comments

@dexster
Copy link

dexster commented Mar 5, 2021

This would be an enhancement to #236 to allow chars like ' to be replaced as well.

I'm happy to submit a PR if you think this is a valid request.
@quantizor
Copy link
Owner

This is definitely something I'm open to adding if you'd like to make an RFC or open a PR!

dexster added a commit to dexster/markdown-to-jsx that referenced this issue Mar 9, 2021
@dexster
quantizor#376 - Allow more custom HTML character codes
674d7a8
@dexster dexster mentioned this issue Mar 9, 2021
Closed
@dexster
Copy link
Author

dexster commented Mar 9, 2021

PR submitted but I see that the generated file, markdown-to-jsx.js, is committed to the repo. Shouldn't this be ignored? I'm getting fails in the PR and it's difficult to pinpoint the source

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@quantizor @dexster