Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optionally disable HTML parsing #278

Merged
merged 4 commits into from
Feb 5, 2020

Conversation

tupton
Copy link
Contributor

@tupton tupton commented Dec 12, 2019

Taking my cue from #225, I went with a probably-too-naive approach but I figured it'd be a starting point.

@tupton
Copy link
Contributor Author

tupton commented Dec 12, 2019

Looks like the failing CI job is because the bundle size is too big by 26 B! Yikes. I'm not sure how to get that down when all I did was add conditional rules. Input is welcome.

EDIT: I bumped the size limit parameter to 5.28kB; I hope that is acceptable.

@codecov
Copy link

codecov bot commented Dec 12, 2019

Codecov Report

Merging #278 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #278      +/-   ##
==========================================
+ Coverage   99.21%   99.22%   +<.01%     
==========================================
  Files           1        1              
  Lines         383      386       +3     
  Branches       63       64       +1     
==========================================
+ Hits          380      383       +3     
  Misses          3        3
Impacted Files Coverage Δ
index.js 99.22% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3481d93...ed9e1b1. Read the comment docs.

Copy link
Owner

@quantizor quantizor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants