fixing notebook test errors when no tests collected #4196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viathor
approved these changes
Jun 12, 2021
balopat
added
the
automerge
CirqBot
added
the
front_of_queue_automerge
CirqBot
removed
automerge
rht
pushed a commit
to rht/Cirq
that referenced
this pull request
May 1, 2023
Fix broken notebook tests in master. It seems that when `pattern` does not match any tests in `pytest -k pattern`, pytest returns an exit code 5. This breaks the newly sharded notebook tests, which are leveraging the `-k partition-n` pattern for changed notebooks. This fix adds the fix as per the recommendations of pytest-dev/pytest#2393.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix broken notebook tests in master.
It seems that when
patterndoes not match any tests inpytest -k pattern, pytest returns an exit code 5. This breaks the newly sharded notebook tests, which are leveraging the-k partition-npattern for changed notebooks.This fix adds the fix as per the recommendations of pytest-dev/pytest#2393.