Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark QSD QFT5 with xfail #6767

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Conversation

NoureldinYosri
Copy link
Collaborator

@NoureldinYosri NoureldinYosri commented Oct 14, 2024

related to #6765

@NoureldinYosri NoureldinYosri requested review from vtomole and a team as code owners October 14, 2024 22:35
@CirqBot CirqBot added the Size: XS <10 lines changed label Oct 14, 2024
@CirqBot CirqBot added the size: S 10< lines changed <50 label Oct 14, 2024
Copy link

codecov bot commented Oct 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.83%. Comparing base (9ff9b6b) to head (8ffd549).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6767   +/-   ##
=======================================
  Coverage   97.83%   97.83%           
=======================================
  Files        1077     1077           
  Lines       92743    92745    +2     
=======================================
+ Hits        90739    90741    +2     
  Misses       2004     2004           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pavoljuhas
Copy link
Collaborator

There might be some real numerical instability in the code.

Can we mark the affected tests with xfail and investigate in detail later?

@NoureldinYosri NoureldinYosri changed the title lower atol in qsd Mark QSD QFT5 with xfail Oct 15, 2024
Copy link
Collaborator

@vtomole vtomole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size: S 10< lines changed <50 Size: XS <10 lines changed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants