Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhanced tutorial book for Issue #424 #435

Merged
merged 10 commits into from
Oct 7, 2021
Merged

Enhanced tutorial book for Issue #424 #435

merged 10 commits into from
Oct 7, 2021

Conversation

cognigami
Copy link
Contributor

  • Fix an error in _book.yaml
  • Split GCP tutorial into multiple parts to clarify CPU and GPU workflows
  • Added noise simulation tutorial to nav

@cognigami
Fix an error in _book.yaml; split GCP tutorial into multiple parts to…
2d24994 
… clarify CPU and GPU workflows; added noise simulation tutorial to nav. quantumlib#424
@google-cla google-cla bot added the cla: yes Override CLA status to unblock PR. label Sep 30, 2021
95-martin-orion
95-martin-orion requested changes Sep 30, 2021
View reviewed changes
Copy link
Collaborator

@95-martin-orion 95-martin-orion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment on the example pictures: your Google account icon, including your face, is visible in the corner. Are you OK with this?

docs/tutorials/gcp_before_you_begin.md Show resolved Hide resolved
docs/tutorials/gcp_cpu.md Show resolved Hide resolved
docs/tutorials/gcp_gpu.md Outdated Show resolved Hide resolved
docs/tutorials/gcp_gpu.md Show resolved Hide resolved
docs/tutorials/gcp_gpu.md Outdated Show resolved Hide resolved
docs/tutorials/gcp_cpu.md Outdated Show resolved Hide resolved
docs/tutorials/gcp_gpu.md Outdated Show resolved Hide resolved
docs/tutorials/gcp_gpu.md Outdated Show resolved Hide resolved
docs/tutorials/gcp_gpu.md Outdated Show resolved Hide resolved
docs/tutorials/gcp_gpu.md Outdated Show resolved Hide resolved
95-martin-orion
95-martin-orion approved these changes Oct 5, 2021
View reviewed changes
Copy link
Collaborator

@95-martin-orion 95-martin-orion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of remaining notes re: preventing accidental billing, but everything else LGTM.

docs/tutorials/gcp_cpu.md Outdated Show resolved Hide resolved
docs/tutorials/gcp_gpu.md Outdated Show resolved Hide resolved
@95-martin-orion 95-martin-orion added the kokoro:run Trigger Kokoro builds for this PR. label Oct 6, 2021
@qsim-qsimh-bot qsim-qsimh-bot removed the kokoro:run Trigger Kokoro builds for this PR. label Oct 6, 2021
95-martin-orion
95-martin-orion requested changes Oct 6, 2021
View reviewed changes
docs/_book.yaml Show resolved Hide resolved
docs/_book.yaml Show resolved Hide resolved
@95-martin-orion 95-martin-orion added the kokoro:run Trigger Kokoro builds for this PR. label Oct 6, 2021
@qsim-qsimh-bot qsim-qsimh-bot removed the kokoro:run Trigger Kokoro builds for this PR. label Oct 6, 2021
@95-martin-orion 95-martin-orion merged commit 9fcf489 into quantumlib:master Oct 7, 2021
@95-martin-orion 95-martin-orion mentioned this pull request Oct 12, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@95-martin-orion 95-martin-orion 95-martin-orion approved these changes

Assignees
No one assigned
Labels
cla: yes Override CLA status to unblock PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cognigami @95-martin-orion @qsim-qsimh-bot