Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #255: Switch to Quarkus Barcode ZXing #256

Merged
merged 1 commit into from
Nov 4, 2024
Merged

Fix #255: Switch to Quarkus Barcode ZXing #256

merged 1 commit into from
Nov 4, 2024

Conversation

melloware
Copy link
Contributor

Fix #255: Switch to Quarkus Barcode ZXing

@melloware melloware requested a review from a team as a code owner November 4, 2024 14:37
FroMage
FroMage approved these changes Nov 4, 2024
View reviewed changes
Copy link
Contributor

@FroMage FroMage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I do have tests for these anyways, I'm pretty sure, so we'll see :)

@gastaldi
Copy link
Member

gastaldi commented Nov 4, 2024

w00t, the tests passed. That's awesome! Good job @melloware !

@FroMage FroMage merged commit 8d0706c into quarkiverse:main Nov 4, 2024
1 check passed
@melloware melloware deleted the 255 branch November 4, 2024 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FroMage FroMage FroMage approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Switch to Quarkus Barcode ZXing
3 participants
@melloware @gastaldi @FroMage