Prevent concurrently running Jacoco ReportCreators to avoid report co…

…rruption
quarkusio · Dec 7, 2023 · 404ff07 · 404ff07
1 parent 7759deb
commit 404ff07
Showing 1 changed file with 10 additions and 0 deletions.
diff --git a/test-framework/jacoco/runtime/src/main/java/io/quarkus/jacoco/runtime/ReportCreator.java b/test-framework/jacoco/runtime/src/main/java/io/quarkus/jacoco/runtime/ReportCreator.java
@@ -37,6 +37,16 @@ public ReportCreator(ReportInfo reportInfo, JacocoConfig config) {
 
     @Override
     public void run() {
+        // Ugly workaround:
+        // Multiple ReportCreator shutdown hooks might run concurrently, possibly corrupting the report file(s) - e.g. when using @TestProfile.
+        // By locking on a class from the parent CL, all hooks are "serialized", one after another.
+        // In the long run there should only be as many hooks as there are different Jacoco configs...usually there will be only one config anyway!
+        synchronized (ExecFileLoader.class) {
+            doRun();
+        }
+    }
+
+    private void doRun() {
         File targetdir = new File(reportInfo.reportDir);
         targetdir.mkdirs();
         try {