Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Injection of BrowserContext stopped working on main/999-SNAPSHOT #43034

Closed
gbourant opened this issue Sep 5, 2024 · 11 comments · Fixed by #43035
Closed

Injection of BrowserContext stopped working on main/999-SNAPSHOT #43034

gbourant opened this issue Sep 5, 2024 · 11 comments · Fixed by #43035
Labels
area/testing kind/bug Something isn't working
Milestone

Comments

@gbourant
Copy link

gbourant commented Sep 5, 2024

Describe the bug

Injection of BrowserContext stopped working on main/999-SNAPSHOT branch but it works on 3.14.2 version

@QuarkusTest
@WithPlaywright
public class EmailTagTest {

    @InjectPlaywright
    BrowserContext context;

    @Test
    void test(){
        assertNotNull(context);
    }

}

Expected behavior

No response

Actual behavior

No response

How to Reproduce?

No response

Output of uname -a or ver

No response

Output of java -version

No response

Quarkus version or git rev

No response

Build tool (ie. output of mvnw --version or gradlew --version)

No response

Additional information

No response

@gbourant gbourant added the kind/bug Something isn't working label Sep 5, 2024
@quarkus-bot quarkus-bot bot added the area/arc Issue related to ARC (dependency injection) label Sep 5, 2024
Copy link

quarkus-bot bot commented Sep 5, 2024

/cc @Ladicek (arc), @manovotn (arc), @mkouba (arc)

@mkouba mkouba added area/testing and removed area/arc Issue related to ARC (dependency injection) labels Sep 5, 2024
@mkouba
Copy link
Contributor

mkouba commented Sep 5, 2024

CC @holly-cummins

@geoand
Copy link
Contributor

geoand commented Sep 5, 2024

@gbourant thanks a lot for reporting this issue so early!

Do you have a sample we can try to see the issue in action?

@geoand
Copy link
Contributor

geoand commented Sep 5, 2024

FWIW, it seems to be the same as reported here

@geoand
Copy link
Contributor

geoand commented Sep 5, 2024

This is definitely related to #42852, so I'll have a look

@gbourant
Copy link
Author

gbourant commented Sep 5, 2024

Do you have a sample we can try to see the issue in action?

Yes i will provide a reproducer soon.

This is definitely related to #42852, so I'll have a look

Yes, it seems that if you just run a single test with the injected BrowserContext it works. (no restarts)

@geoand
Copy link
Contributor

geoand commented Sep 5, 2024

Yes i will provide a reproducer soon.

Actually, you don't have to. Quarkus Super Heroes suffers from the same problem, so I am going to use it to see what's going on

@gbourant
Copy link
Author

gbourant commented Sep 5, 2024

Not prob, it's already done, in case you need it https://github.com/gbourant/qplay

@geoand
Copy link
Contributor

geoand commented Sep 5, 2024

🙏🏽

@geoand
Copy link
Contributor

geoand commented Sep 5, 2024

#43035 fixes the issue

@gbourant
Copy link
Author

gbourant commented Sep 5, 2024

I just tested with your branch and indeed it works as expected.

geoand added a commit to geoand/quarkus that referenced this issue Sep 5, 2024
geoand added a commit that referenced this issue Sep 5, 2024
Fix handling of `@WithTestResource` and Global resources
@quarkus-bot quarkus-bot bot added this to the 3.16 - main milestone Sep 5, 2024
danielsoro pushed a commit to danielsoro/quarkus that referenced this issue Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/testing kind/bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants