Substitute BouncyCastle self-tests which rely on SecureRandom #16105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sberyozkin
force-pushed
the
bc_fips_secure_random
branch
from
d918327
to
6339576
Compare
|
Can you please rebase onto Thanks |
|
Hmm, it affects other tests - looks like the introduction of bouncy castle specific extensions is the way to go... |
|
For now I've conditioned the substitutions code for it to apply only if the specific BC package is available. I feel adding the extensions would be the right thing to do soon (as @gastaldi and @stuartwdouglas proposed awhile back) - but we are talking about 4 extensions here (BC, BC TLS, BC FIPS, BC FIPS TLS) so I'd rather take care of it in a follow up step a bit later on. |
sberyozkin
force-pushed
the
bc_fips_secure_random
branch
from
6339576
to
bd681c2
Compare
sberyozkin
force-pushed
the
bc_fips_secure_random
branch
from
bd681c2
to
ecc9e4d
Compare
|
I did a minor optimization to the substitutions code to restrict the package check for the static set to contain only just about 15 Strings and added the re-init requests for a couple of classes which cause BC FIPS related |
zakkak
reviewed
Mar 31, 2021
| @@ -16,3 +16,6 @@ quarkus.log.category."org.bouncycastle.jsse".min-level=TRACE | |||
| quarkus.log.category."org.bouncycastle.jsse".level=TRACE | |||
| quarkus.log.file.enable=true | |||
| quarkus.log.file.format=%C - %s%n | |||
|
|
|||
| #quarkus.native.additional-build-args=--trace-object-instantiation=org.bouncycastle.crypto.fips.FipsSecureRandom | |||
| quarkus.native.additional-build-args=--trace-object-instantiation=java.security.SecureRandom | |||
There was a problem hiding this comment.
FYI you can do --trace-object-instantiation=java.security.SecureRandom\\,org.bouncycastle.crypto.fips.FipsSecureRandom to trace both (see second note in https://github.com/quarkusio/quarkus/blob/main/docs/src/main/asciidoc/writing-native-applications-tips.adoc#delaying-class-initialization)
There was a problem hiding this comment.
@zakkak Thanks, will keep it in mind :-), I left the SecureRandom tracing as it points out to JceSecurity; going forward I'll keep combining several classes when tracing - thanks
There was a problem hiding this comment.
Commented it out and collapsed into a single property configuration as suggested by @zakkak
gsmet
requested changes
Apr 8, 2021
| @@ -16,3 +16,6 @@ quarkus.log.category."org.bouncycastle.jsse".min-level=TRACE | |||
| quarkus.log.category."org.bouncycastle.jsse".level=TRACE | |||
| quarkus.log.file.enable=true | |||
| quarkus.log.file.format=%C - %s%n | |||
|
|
|||
| #quarkus.native.additional-build-args=--trace-object-instantiation=org.bouncycastle.crypto.fips.FipsSecureRandom | |||
| quarkus.native.additional-build-args=--trace-object-instantiation=java.security.SecureRandom | |||
sberyozkin
force-pushed
the
bc_fips_secure_random
branch
from
e93f04a
to
94aa129
Compare
Failing Jobs
Test Failures⚙️ JVM Tests - JDK 8 #📦 integration-tests/kafka# Tests: 10
+ Success: 8
- Failures: 0
- Errors: 2
! Skipped: 0❌
|
gsmet
approved these changes
Apr 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #15889
This PR adds self-tests substitutions as suggested by @galderz (except that they return
true) and a note has been added to the BC FIPS subsection about the affected classes as IMHO, given that FIPS implies a stricter crypto security, users who will work with this option will need to be aware of every affected algorithm