-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
In io.quarkus.jackson.ObjectMapperCustomizer, use JsonMapper.Builder instead of ObjectMapper #24256
Conversation
…uilder instead of ObjectMapper
Probably merge conflicts with #23995. (Are you ready to merge that?) |
Failing Jobs - Building 2ec31af
Full information is available in the Build summary check run. Failures⚙️ Devtools Tests - JDK 11 #- Failing: integration-tests/devtools
📦 integration-tests/devtools✖
⚙️ Devtools Tests - JDK 17 #- Failing: integration-tests/devtools
📦 integration-tests/devtools✖
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can't break compatibility because injecting ObjectMapper is used a lot.
I suggest maintaining the same behavior by deprecating it and introduce the new enhancement
Also how would that work for non-json content? |
Yeah, this is a good start but we need to think about the proper strategy to make that change as we don't want to break all the applications around. |
These changes should be backwards compatible. JsonMapper is an ObjectMapper. There is backwards compatibility for invoking the deprecated ObjectMapperCustomizer(s) provided by non-quarkus managed code. @gastaldi, what do you mean by non-json content? Is there current or future support for any other text mappers such as YamlMapper? Support for any binary mappers such as AvroMapper? |
@chonton I don't think we do that now, but an |
When XxxMapper is introduced, is it better to use a single Customizer interface, or specific XxxCustomizer per XxxMapper? |
IMHO a single Customizer interface would be easier, as it does not require any code changes when a new ObjectMapper implementation is introduced |
Closes #24019