Bump kubernetes-client-bom from 6.3 to 6.4

[manusa]

Kubernetes Client 6.4.0 6.4.1 was just released: https://github.com/fabric8io/kubernetes-client/releases/tag/v6.4.1

This release of the client includes the new Vert.x HttpClient implementation. This PR includes changes in the pom.xml files to make use of this client instead of the default OkHttp implementation. If everything goes well, this should fix #29520

• Added an enforcer rule to ensure OkHttp that the kubernetes-httpclient-okhttp module is not mistakenly propagated, however, I'm not sure this is the right place. I can't directly block OkHttp since it is also used (server-side) in the MockServer.
• Modified the kubernetes-extension (creates kubernetes et al manifests and deploys them) to create and close KubernetesClient instances and avoid the leakages mentioned in some of the PR comments
• Modified the kubernetes-client-extension to implement an HttpClient.Factory that reuses the global Vert.x instance (uses CDI to retrieve it, maybe doesn't work, waiting for tests)

/cc @metacosm @maxandersen @shawkins @gastaldi @geoand

Fix #30558

[gastaldi]

That's awesome! You can also add the exclusion to the bom/application pom.xml

[gastaldi]

That's awesome! You can also add the exclusion to the bom/application pom.xml

Ah but we only import the kubernetes-bom there, nevermind

[gsmet]

Awesome!

As a followup, I will try to remove okhttp from the BOM as it shouldn't be a dependency anymore.

[gastaldi]

I think it's safe to remove OkHttp from the list of managed dependencies too:
https://github.com/quarkusio/quarkus/blob/main/bom/application/pom.xml#L171-L172

and

https://github.com/quarkusio/quarkus/blob/main/bom/application/pom.xml#L4169-L4183

Guillaume will followup the Okhttp/Okio removal in a separate PR

[gsmet]

Yeah I think it's better to do it in a separate PR in case it breaks something and we have to revert it.

[geoand]

Very glad to see this!

[gsmet]

An example of the enforcer failures:

[INFO] --- maven-enforcer-plugin:3.0.0-M3:enforce (enforce) @ quarkus-kubernetes-client-internal ---
[18537](https://github.com/quarkusio/quarkus/actions/runs/3959243390/jobs/6781818473#step:10:18538)
Warning:  Rule 3: org.apache.maven.plugins.enforcer.ExternalRules failed with message:
[18538](https://github.com/quarkusio/quarkus/actions/runs/3959243390/jobs/6781818473#step:10:18539)
Found Banned Dependency: com.squareup.okhttp3:okhttp:jar:3.14.9
[18539](https://github.com/quarkusio/quarkus/actions/runs/3959243390/jobs/6781818473#step:10:18540)
Use 'mvn dependency:tree' to locate the source of the banned dependencies.

[manusa]

It seems that we might need to bump Dekorate along with the client.

dekorateio/dekorate#1131

[geoand]

Including @Sgitario for awareness

[Sgitario]

Including @Sgitario for awareness

PR to bump dekorate: #30533

[gsmet]

Don't worry about the Gradle tests failing, it's unrelated to your patch.

[manusa]

Don't worry about the Gradle tests failing, it's unrelated to your patch.

Thx. Yes, I discussed internally with Georgios. I've rebased after the merge of #30758.

Hoping this time we get a completely green report 🤞 .

[quarkus-bot]

✔️ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.