Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Hibernate Reactive 2.0.0.CR1 #32845

Merged
merged 2 commits into from
Apr 24, 2023
Merged

Upgrade to Hibernate Reactive 2.0.0.CR1 #32845

merged 2 commits into from
Apr 24, 2023

Conversation

Sanne
Copy link
Member

@Sanne Sanne commented Apr 23, 2023

Fixes #32533
Fixes #32602

@quarkus-bot

This comment has been minimized.

@Sanne
Copy link
Member Author

Sanne commented Apr 24, 2023

I'll check what's wrong with security-jpa-reactive ..

@Sanne
Copy link
Member Author

Sanne commented Apr 24, 2023

This should be fixed now, some signatures changes in Hibernate Reactive 2.0.0.CR1 and that broke bytecode generated code in the security-jpa-reactive module.

@gsmet N.B. while I'd love this to be backported to the 3.0 branch, the security-jpa-reactive module was introduced in main after the branch. So I've kept the second commit strictly separete, we only need to cherry pick the first one; I hope that's not too inconvenient, sorry for the mess.

@Sanne Sanne requested a review from yrodiere April 24, 2023 15:02
@quarkus-bot
Copy link

quarkus-bot bot commented Apr 24, 2023

Failing Jobs - Building 91bba01

Status Name Step Failures Logs Raw logs
Native Tests - Security1 Build ⚠️ Check → Logs Raw logs

@Sanne Sanne merged commit 74e98b4 into quarkusio:main Apr 24, 2023
@Sanne Sanne deleted the hr-latest branch April 24, 2023 21:12
@quarkus-bot quarkus-bot bot added this to the 3.1 - main milestone Apr 24, 2023
@gsmet gsmet modified the milestones: 3.1 - main, 3.0.1.Final Apr 25, 2023
@gsmet
Copy link
Member

gsmet commented Apr 25, 2023

Thanks for keeping the commits separate and pinging me!

@gsmet
Copy link
Member

gsmet commented Apr 25, 2023

Unfortunately we cannot backport it because of failures in native. I suspect it has to do with the fact that you upgraded Vert.x while we haven't backported the Vert.x upgrade to 3.0.

/cc @maxandersen @cescoffier the decision to not backport the Vert.x upgrade will probably cause us some headaches here.

@cescoffier
Copy link
Member

If it makes things simpler we can backport it. At least it will fix the false-positive snake yaml cve

@gsmet gsmet modified the milestones: 3.0.1.Final, 3.1 - main Apr 25, 2023
@gsmet
Copy link
Member

gsmet commented Apr 25, 2023

I think we will have to do it in the next micro if we want do backport it. It's a bit too late to do it now (I think).

@Sanne
Copy link
Member Author

Sanne commented Apr 25, 2023

bummer, yes I assumed since the vertx upgrade was merged we'd be clear to merge the upgrade as well.

It's unfortunate as this HR release solves a great deal of issues and also API was affected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/dependencies Pull requests that update a dependency file area/hibernate-reactive Hibernate Reactive area/panache area/persistence OBSOLETE, DO NOT USE kind/bugfix
Projects
None yet
5 participants