Fix File handling as a JAX-RS body parameter #35659
Conversation
|
At the least the first commit should be backported. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
@FroMage can you have a look at this? |
|
@FroMage ping :) |
|
@FroMage can you have a look at this please? |
|
✔️ The latest workflow run for the pull request has completed successfully. It should be safe to merge provided you have a look at the other checks in the summary. |
|
Ouch, I'm late again. Looking. |
| @@ -40,4 +42,8 @@ public Boolean call() { | |||
| } | |||
| }); | |||
| } | |||
|
|
|||
| protected String fileSizeAsStr(File file) throws IOException { | |||
| return "" + Files.readAllBytes(file.toPath()).length; | |||
| throws IOException, WebApplicationException { | ||
| // unfortunately we don't do much here to avoid the file leak | ||
| // however this should never be called in a real world scenario | ||
| return FileBodyHandler.doRead(httpHeaders, entityStream, Files.createTempFile(PREFIX, SUFFIX).toFile()).toPath(); |
There was a problem hiding this comment.
Is there really no way to obtain the current context in this case? Feels a bit dangerous and optimistic to assume this never gets called. Perhaps we should at least log an INFO message so that people get something in their logs to explain why their /tmp folder would keep growing and crash?
There was a problem hiding this comment.
We control the calling of the method, so it should indeed never be called
| @@ -21,8 +21,8 @@ | |||
| import org.jboss.resteasy.reactive.common.headers.HeaderUtil; | |||
|
|
|||
| public class FileBodyHandler implements MessageBodyReader<File>, MessageBodyWriter<File> { | |||
There was a problem hiding this comment.
Is this even used outside of the Quarkus version, which now overrides it? If not, I wonder if it wouldn't be less complex to ditch the reader overrides build items and pass the proper config and cleaner to the non-quarkus RR, no?
There was a problem hiding this comment.
IIRC, it was used in some tests in the independent project
No description provided.