-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow authentication mechanism selection for a REST endpoint with annotation #36504
Allow authentication mechanism selection for a REST endpoint with annotation #36504
Conversation
646d716
to
44a9bff
Compare
...tests/oidc-code-flow/src/main/java/io/quarkus/it/keycloak/MultipleAuthMechanismResource.java
Outdated
Show resolved
Hide resolved
Super effort @michalvavrik, thanks for keeping fixing high impact issues 👍 . Might be worth keeping in a Draft state for a bit of time |
🙈 The PR is closed and the preview is expired. |
Thank you Sergey.
Anyway, when we go through ^^^ and folk have time to suggest changes (cc @FroMage :-)), I don't see a reason to keep this in draft. You can see there is lot of file changes, though vast majority are tests. For example I won't touch issue on HTTP permissions runtime migration before this is merged in order to avoid merge conflicts. |
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's a nice feature. Not sure I'll use it, but it seems useful.
078308b
to
6b586ff
Compare
This comment has been minimized.
This comment has been minimized.
extensions/oidc/runtime/src/main/java/io/quarkus/oidc/CodeFlow.java
Outdated
Show resolved
Hide resolved
...rtx-http/runtime/src/main/java/io/quarkus/vertx/http/runtime/security/HttpAuthenticator.java
Outdated
Show resolved
Hide resolved
6b586ff
to
c1f7ffa
Compare
This comment has been minimized.
This comment has been minimized.
As far as failures go, you can see that only thing I changed was one line in documentation and previously we had different failures, so it's flaky. |
c1f7ffa
to
2226886
Compare
This comment has been minimized.
This comment has been minimized.
1f127d2
to
789e5cd
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
integration-tests/oidc-tenancy/src/main/java/io/quarkus/it/keycloak/TenantResource.java
Outdated
Show resolved
Hide resolved
789e5cd
to
24c41ae
Compare
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but please update the documentation
This comment has been minimized.
This comment has been minimized.
24c41ae
to
1373ed0
Compare
1373ed0
to
6745bf6
Compare
Status for workflow
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work, thanks @michalvavrik
Status for workflow
|
closes: #34664
Right now, the only way to combine authentication mechanism is per path using HTTP permission - https://quarkus.io/guides/security-authentication-mechanisms#path-specific-authentication-mechanisms. This PR allows to do same per REST endpoint using annotations. This, combining with RBAC annotations should complement annotation-based approach with same capabilities as configuration-based approach has. And greater, for one path depending on consumed content type etc. can match different endpoints.