Fixes stork path param resolution in REST Client #37757
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
aureamunoz
commented
Dec 14, 2023
•
aureamunoz
commented
- Fixes PathParam containing "/" character are not well encoded as "%2F" when using reactive rest client with Stork #37713
aureamunoz
force-pushed
the
issue-37713-fix-stork-path-resolution
branch
2 times, most recently
from
9b045e8
to
3d37c21
Compare
|
cc @cescoffier |
This comment has been minimized.
This comment has been minimized.
aureamunoz
force-pushed
the
issue-37713-fix-stork-path-resolution
branch
from
3d37c21
to
7de04b0
Compare
This comment has been minimized.
This comment has been minimized.
aureamunoz
changed the title
cescoffier
requested changes
Dec 20, 2023
...eactive/deployment/src/test/java/io/quarkus/rest/client/reactive/stork/StorkDevModeTest.java
Outdated
Show resolved
Hide resolved
...ive/deployment/src/test/java/io/quarkus/rest/client/reactive/stork/StorkIntegrationTest.java
Outdated
Show resolved
Hide resolved
.../runtime/src/main/java/org/jboss/resteasy/reactive/client/impl/StorkClientRequestFilter.java
Outdated
Show resolved
Hide resolved
aureamunoz
force-pushed
the
issue-37713-fix-stork-path-resolution
branch
from
7de04b0
to
4c52fbb
Compare
This comment has been minimized.
This comment has been minimized.
|
I managed to figure out where the encoding were being done. Now it should be ok! |
cescoffier
approved these changes
Jan 9, 2024
.../runtime/src/main/java/org/jboss/resteasy/reactive/client/impl/StorkClientRequestFilter.java
Show resolved
Hide resolved
|
@aureamunoz can you squash the commits? |
geoand
approved these changes
Jan 9, 2024
geoand
changed the title
…ng when creating new URI Related to quarkusio#37713 refactor: clean up a few commented lines fix: use raw path and avoid double encoding, adapt tests accordingly
aureamunoz
force-pushed
the
issue-37713-fix-stork-path-resolution
branch
from
4c52fbb
to
ce206d5
Compare
geoand
added
the
triage/waiting-for-ci
|
✔️ The latest workflow run for the pull request has completed successfully. It should be safe to merge provided you have a look at the other checks in the summary. You can consult the Develocity build scans. |
quarkus-bot
bot
removed
the
triage/waiting-for-ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.