Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump org.jboss.logmanager:log4j2-jboss-logmanager from 1.1.2.Final to 2.0.1.Final #42559

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Aug 14, 2024

Bumps org.jboss.logmanager:log4j2-jboss-logmanager from 1.1.2.Final to 2.0.1.Final.

Release notes

Sourced from org.jboss.logmanager:log4j2-jboss-logmanager's releases.

2.0.1.Final

What's Changed

Full Changelog: jboss-logging/log4j2-jboss-logmanager@2.0.0.Final...2.0.1.Final

2.0.0.Final

What's Changed

Full Changelog: jboss-logging/log4j2-jboss-logmanager@1.1.1.Final...2.0.0.Final

Commits
  • 6e3b9c9 Prepare for 2.0.1.Final release
  • 898b83d Merge pull request #95 from jamezp/issue94
  • 2169187 [94] Ensure the level is set in a privileged action if the security manager i...
  • 0c14d61 Next is 2.0.1.Final
  • a3787f9 Prepare for 2.0.0.Final release
  • 131f6d8 Fix the JavaDoc issue created by the module-info plugin. For whatever reason,...
  • f357ab2 Merge pull request #93 from jamezp/issue92
  • 3ab9ca6 [92] Allow the ThreadContextMDCMap to work with both the JBoss Log Manager 3....
  • 1a30abb Merge pull request #86 from jboss-logging/dependabot/maven/org.jboss.logmanag...
  • c9cc876 Merge pull request #91 from jboss-logging/dependabot/maven/org.junit-junit-bo...
  • Additional commits viewable in compare view

Dependabot compatibility score

You can trigger a rebase of this PR by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added the area/dependencies Pull requests that update a dependency file label Aug 14, 2024

This comment has been minimized.

@gsmet
Copy link
Member

gsmet commented Aug 19, 2024

@jamezp what's the strategy here? Are all the adapters compatible with this new version? Should we update to it or not?

(you can ignore CI for now, I think we ended up in the middle of a GitHub Action outage, I will rerun CI depending on what the plan is)

@jamezp
Copy link
Contributor

jamezp commented Aug 19, 2024

Hi @gsmet. I'll update the release notes and the README. The 2.0.x versions only work with log4j 2.23+ because of apache/logging-log4j2#2249. The StatusLogget.setLevel() was changed in a way that it didn't work. Changes were required that only wrk in 2.23.x+

jboss-logging/log4j2-jboss-logmanager#82 was the change in the log4j2-jboss-logmanager. I decided since it was a major bump, that requiring a minimum of 2.23 seemed okay.

Bumps [org.jboss.logmanager:log4j2-jboss-logmanager](https://github.com/jboss-logging/log4j2-jboss-logmanager) from 1.1.2.Final to 2.0.1.Final.
- [Release notes](https://github.com/jboss-logging/log4j2-jboss-logmanager/releases)
- [Commits](jboss-logging/log4j2-jboss-logmanager@1.1.2.Final...2.0.1.Final)

---
updated-dependencies:
- dependency-name: org.jboss.logmanager:log4j2-jboss-logmanager
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
@gsmet gsmet force-pushed the dependabot/maven/org.jboss.logmanager-log4j2-jboss-logmanager-2.0.1.Final branch from e6a1d3b to 5d02934 Compare August 21, 2024 08:06
Copy link

quarkus-bot bot commented Aug 21, 2024

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit 5d02934.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.


Flaky tests - Develocity

⚙️ Native Tests - HTTP

📦 integration-tests/rest-client-reactive

io.quarkus.it.rest.client.BasicTestIT.shouldCreateClientSpans - History

  • expected: <1> but was: <2> - org.opentest4j.AssertionFailedError
org.opentest4j.AssertionFailedError: expected: <1> but was: <2>
	at io.quarkus.it.rest.client.BasicTest.shouldCreateClientSpans(BasicTest.java:216)
	at java.base/java.lang.reflect.Method.invoke(Method.java:569)
	at io.quarkus.test.junit.QuarkusTestExtension.interceptTestMethod(QuarkusTestExtension.java:821)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)

@gsmet gsmet merged commit 601a2fa into main Aug 28, 2024
52 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.16 - main milestone Aug 28, 2024
@dependabot dependabot bot deleted the dependabot/maven/org.jboss.logmanager-log4j2-jboss-logmanager-2.0.1.Final branch August 28, 2024 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/dependencies Pull requests that update a dependency file kind/component-upgrade triage/flaky-test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants