-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GRPC pom: Adding operating system specific profiles #42993
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Welcome to the club!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! It looks good to me except I think I would drop the name
for macOS and Windows as it doesn't bring anything.
Apart from that, I'm not sure how other unixes should be handled but I suppose we will have to wait for feedback from the field.
Could you adjust and squash? Thanks!
extensions/grpc/codegen/pom.xml
Outdated
<id>osx-x86_64</id> | ||
<activation> | ||
<os> | ||
<name>Mac OS X</name> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would drop the name here.
extensions/grpc/codegen/pom.xml
Outdated
<id>osx-aarch64</id> | ||
<activation> | ||
<os> | ||
<name>Mac OS X</name> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same here.
extensions/grpc/codegen/pom.xml
Outdated
<id>windows-x86_32</id> | ||
<activation> | ||
<os> | ||
<name>Windows</name> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same here.
extensions/grpc/codegen/pom.xml
Outdated
<id>windows-x86_64</id> | ||
<activation> | ||
<os> | ||
<name>Windows</name> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same here.
…dencies that are pulled on each platform Removing name from os profiles since checking by arch should be enough for now
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For me, it's all good, thanks!
But I would also like the blessing of @cescoffier .
🎊 PR Preview ac5e735 has been successfully built and deployed to https://quarkus-pr-main-42993-preview.surge.sh/version/main/guides/
|
Status for workflow
|
Status for workflow
|
Nice improvement, thanks! |
When we did that, I thought "will it work with Gradle?" and I was pleasantly surprised. But actually it doesn't, see #43038 for all the gory details and the revert. |
Yuck. I guess I will keep my Gradle rant to myself... |
Fix #42931
In which this PR adds operating system specific profiles to pull only the dependencies needed for the machine being built.
This should help cut down on the pulling of extra files we don't need.
I've run the
./mvnw -Dquickly
from the root and all tests passed.I verified on MacOS that ONLY the mac .exe gets pulled during the test by deleting the
~/.m2/repository/io/grpc/protoc-gen-gprc-java
folder prior to running the tests.I've run the
/.mvnw -Dquickly
on my Fedora 39 Linux machine and all tests passed.I verified on
Fedora Linux
that ONLY thelinux-x86_64.exe
gets pulled during the test by deleting the~/.m2/repository/io/grpc/protoc-gen-gprc-java
folder prior to running the tests.I also tried to cut down the file even further by just using the
os.detected.classifier
in the two protoc dependencies rather than spelling out each arch/os but I got an error from maven saying theversion
was missing.I see the
os.detected.classifier
printed out at the beginning of the tests but it appears it's not available for the grpc tests?Anyway, this change should work better by eliminating pulling down files for other operatings systems that aren't needed.
I could NOT verify the
s390
orppc
archictectures since I don't have those around.. I just had Linux, Mac and windows.