-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add VertxContextSupport#executeBlocking() #43444
Merged
mkouba
merged 1 commit into
quarkusio:main
from
mkouba:ws-next-blocking-http-upgrade-check
Sep 24, 2024
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
82 changes: 82 additions & 0 deletions
82
...t/src/test/java/io/quarkus/websockets/next/test/upgrade/BlockingHttpUpgradeCheckTest.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,82 @@ | ||
package io.quarkus.websockets.next.test.upgrade; | ||
|
||
import static org.junit.jupiter.api.Assertions.assertEquals; | ||
import static org.junit.jupiter.api.Assertions.assertTrue; | ||
|
||
import java.net.URI; | ||
import java.util.concurrent.Callable; | ||
import java.util.concurrent.atomic.AtomicBoolean; | ||
|
||
import jakarta.inject.Inject; | ||
import jakarta.inject.Singleton; | ||
|
||
import org.junit.jupiter.api.Test; | ||
import org.junit.jupiter.api.extension.RegisterExtension; | ||
|
||
import io.quarkus.arc.Arc; | ||
import io.quarkus.runtime.BlockingOperationControl; | ||
import io.quarkus.test.QuarkusUnitTest; | ||
import io.quarkus.test.common.http.TestHTTPResource; | ||
import io.quarkus.vertx.VertxContextSupport; | ||
import io.quarkus.websockets.next.HttpUpgradeCheck; | ||
import io.quarkus.websockets.next.OnOpen; | ||
import io.quarkus.websockets.next.WebSocket; | ||
import io.quarkus.websockets.next.test.utils.WSClient; | ||
import io.smallrye.common.vertx.VertxContext; | ||
import io.smallrye.mutiny.Uni; | ||
import io.vertx.core.Vertx; | ||
|
||
public class BlockingHttpUpgradeCheckTest { | ||
|
||
@RegisterExtension | ||
public static final QuarkusUnitTest test = new QuarkusUnitTest() | ||
.withApplicationRoot(root -> root | ||
.addClasses(BlockingHttpUpgradeCheck.class, Endpoint.class, WSClient.class)); | ||
|
||
@TestHTTPResource("/end") | ||
URI endUri; | ||
|
||
@Inject | ||
Vertx vertx; | ||
|
||
@Test | ||
public void testBlockingCheck() { | ||
try (WSClient client = new WSClient(vertx)) { | ||
client.connect(endUri); | ||
client.waitForMessages(1); | ||
assertEquals("ok", client.getMessages().get(0).toString()); | ||
assertTrue(BlockingHttpUpgradeCheck.PERFORMED.get()); | ||
} | ||
} | ||
|
||
@WebSocket(path = "/end") | ||
public static class Endpoint { | ||
|
||
@OnOpen | ||
String open() { | ||
return "ok"; | ||
} | ||
|
||
} | ||
|
||
@Singleton | ||
public static class BlockingHttpUpgradeCheck implements HttpUpgradeCheck { | ||
|
||
static final AtomicBoolean PERFORMED = new AtomicBoolean(); | ||
|
||
@Override | ||
public Uni<CheckResult> perform(HttpUpgradeContext context) { | ||
return VertxContextSupport.executeBlocking(new Callable<CheckResult>() { | ||
|
||
@Override | ||
public CheckResult call() throws Exception { | ||
assertTrue(BlockingOperationControl.isBlockingAllowed()); | ||
assertTrue(VertxContext.isOnDuplicatedContext()); | ||
assertTrue(Arc.container().requestContext().isActive()); | ||
PERFORMED.set(true); | ||
return CheckResult.permitUpgradeSync(); | ||
} | ||
}); | ||
} | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
defer might be slightly better.
@jponge wdyt?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In what exactly? I mean, both suppliers are called at subscription time. And we would need to convert the
io.vertx.core.Future
to theUni
anyway.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was referring to https://javadoc.io/doc/io.smallrye.reactive/mutiny/latest/io.smallrye.mutiny/io/smallrye/mutiny/groups/UniCreate.html which avoid using completion stages and it's slightly more optimized. But, yes, then you need an emitter, so the cost would be almost equivalent.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you mean https://javadoc.io/doc/io.smallrye.reactive/mutiny/latest/io.smallrye.mutiny/io/smallrye/mutiny/groups/UniCreate.html#deferred(java.util.function.Supplier)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, sorry, missed the anchor.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Deferred with supplier is better, but a
CompletionStage
isn't incorrect per-se.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Better in terms of performance, or?
Hm, but how do I create a
Uni
fromio.vertx.core.Future
withoutUni.createFrom().completionStage()
? That's whatio.smallrye.mutiny.vertx.UniHelper.toUni(Future<T>)
does by the way.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes yes you are right