Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump smallrye-open-api to 3.13.0, MP OpenAPI to 3.1.2 #43616

Merged
merged 1 commit into from
Oct 1, 2024
Merged

Bump smallrye-open-api to 3.13.0, MP OpenAPI to 3.1.2 #43616

merged 1 commit into from
Oct 1, 2024

Conversation

MikeEdgar
Copy link
Contributor

@MikeEdgar MikeEdgar commented Sep 30, 2024 •
edited
Loading

Add custom OpenAPI builder to reduce native image size, noted to have increased in #41037

Fixes #43338

@quarkus-bot quarkus-bot bot added area/dependencies Pull requests that update a dependency file area/openapi area/smallrye labels Sep 30, 2024
@MikeEdgar
Copy link
Contributor Author

FYI @phillip-kruger , @zakkak

@MikeEdgar MikeEdgar changed the title Bump smallrye-open-api 3.13.0, MP OpenAPI to 3.1.2 Bump smallrye-open-api to 3.13.0, MP OpenAPI to 3.1.2 Sep 30, 2024
phillip-kruger
phillip-kruger approved these changes Sep 30, 2024
View reviewed changes
Copy link
Member

@phillip-kruger phillip-kruger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @MikeEdgar

@quarkus-bot quarkus-bot
Copy link

quarkus-bot bot commented Oct 1, 2024 •
edited by github-actions bot
Loading

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit dd7c80e.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.

@zakkak
Copy link
Contributor

zakkak commented Oct 1, 2024

Thank you @MikeEdgar, that's great.

The image size still doesn't go to pre-#41037 (comment) levels but it's still quite an improvement (~1.8% smaller).

@gsmet gsmet merged commit b073d4f into quarkusio:main Oct 1, 2024
52 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.16 - main milestone Oct 1, 2024
@MikeEdgar MikeEdgar deleted the smallrye-open-api-3.13.0-builder branch October 1, 2024 12:09
@zakkak zakkak mentioned this pull request Oct 24, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phillip-kruger phillip-kruger phillip-kruger approved these changes

@gsmet gsmet gsmet approved these changes

Assignees
No one assigned
Labels
area/dependencies Pull requests that update a dependency file area/openapi area/smallrye kind/bugfix
Projects
None yet
Milestone
3.16.0.CR1
Development

Successfully merging this pull request may close these issues.

OpenAPI lose Request Body Description if '@RequestBody' comes after another annotation
4 participants
@MikeEdgar @zakkak @gsmet @phillip-kruger