Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow RuntimeBeanBuildItem to pick static or runtime init #5938

Closed

Conversation

stuartwdouglas
Copy link
Member

No description provided.

@stuartwdouglas stuartwdouglas force-pushed the runtime-bean-init branch 2 times, most recently from 2c1c471 to bec381d Compare December 5, 2019 04:28
Copy link
Contributor

@mkouba mkouba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ideally, we should have a test for this. But I understand that QuarkusUnitTest is not quite ready for this kind of stuff.

Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some micro nitpicking. Feel free to ignore.

@gsmet gsmet modified the milestone: 1.1.0 Dec 5, 2019
@mkouba mkouba added this to the 1.2.0 milestone Dec 9, 2019
@mkouba
Copy link
Contributor

mkouba commented Dec 9, 2019

Hm, when I think about it there is one last issue with this PR that should be at least documented. If a RuntimeBean with staticInit=false is used during STATIC_INIT the client either receives null for @Dependent or IllegalProductException for any normal scope (because it's implemented as a producer method).

@stuartwdouglas
Copy link
Member Author

@gsmet this should be good to merge now.

@gsmet gsmet removed this from the 1.2.0 milestone Jan 20, 2020
@gsmet gsmet added the triage/out-of-date This issue/PR is no longer valid or relevant label Feb 14, 2020
mkouba added a commit to mkouba/quarkus that referenced this pull request Mar 19, 2020
stuartwdouglas pushed a commit to stuartwdouglas/quarkus that referenced this pull request Mar 20, 2020
stuartwdouglas pushed a commit to stuartwdouglas/quarkus that referenced this pull request Mar 26, 2020
gsmet pushed a commit to gsmet/quarkus that referenced this pull request Mar 26, 2020
gsmet pushed a commit to gsmet/quarkus that referenced this pull request Mar 26, 2020
viniciusfcf pushed a commit to viniciusfcf/quarkus-fork that referenced this pull request Sep 7, 2020
luca-digrazia pushed a commit to luca-digrazia/DatasetCommitsDiffSearch that referenced this pull request Sep 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
triage/out-of-date This issue/PR is no longer valid or relevant
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants