-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow RuntimeBeanBuildItem to pick static or runtime init #5938
Conversation
extensions/arc/deployment/src/main/java/io/quarkus/arc/deployment/RuntimeBeanProcessor.java
Outdated
Show resolved
Hide resolved
2c1c471
to
bec381d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ideally, we should have a test for this. But I understand that QuarkusUnitTest
is not quite ready for this kind of stuff.
extensions/arc/deployment/src/main/java/io/quarkus/arc/deployment/RuntimeBeanProcessor.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added some micro nitpicking. Feel free to ignore.
extensions/arc/deployment/src/main/java/io/quarkus/arc/deployment/RuntimeBeanProcessor.java
Outdated
Show resolved
Hide resolved
extensions/arc/deployment/src/main/java/io/quarkus/arc/deployment/RuntimeBeanProcessor.java
Outdated
Show resolved
Hide resolved
bec381d
to
6e579c6
Compare
Hm, when I think about it there is one last issue with this PR that should be at least documented. If a |
6e579c6
to
8399fad
Compare
@gsmet this should be good to merge now. |
No description provided.