Use JSON.parse(JSON.stringify(propertyData)) instead of toJS(propertyData) #103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quarrant
reviewed
Mar 23, 2023
|
|
||
| propertiesToWatch[property.key] = toJS(propertyData); | ||
| propertiesToWatch[property.key] = |
There was a problem hiding this comment.
What's about Map/Set. Does it work correctly?
There was a problem hiding this comment.
🤷 I am not sure. I won't be able to test this out for a few weeks. When using Map/Set should you always use serialize and deserialize?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves this issue: #101
I have tested in my application and I didn't see any issues with this change. I don't know how to test if this change is a improves performance over
toJS()but I can see how it would be more performant.