-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
derive support for enums with newtype/unit variants #233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit d43f0ab. Using the same Tree again emits earlier constraints again in later impls.
@MathiasKoch does this help you? There are some examples in |
jordens
changed the title
derive newtype/unit enum support
derive support for enums with newtypes/unit variants
Sep 24, 2024
This looks amazing! |
jordens
changed the title
derive support for enums with newtypes/unit variants
derive support for enums with newtype/unit variants
Sep 24, 2024
This reverts commit 2ef2f19.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
skip
fields. Both record structs and non-newtype tuple structs would require creating proxy structs on the fly to implementKeyLookup
andTreeKey
on them..0
newtype hierarchy level is flattened intrinsically.skip
. They would only become relevant once there is some instrinsic support for switching variants.Default
per variant.depth = 1
, there is no intrinsic support for variant switching.flatten
ing. This is the only thing that would be missing to supportOption
-style behavior through the derive macros.