Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

expose derivative control #71

Closed
jordens opened this issue Dec 3, 2019 · 3 comments
Closed

expose derivative control #71

jordens opened this issue Dec 3, 2019 · 3 comments
Labels
enhancement New feature or request

Comments

@jordens
Copy link
Member

jordens commented Dec 3, 2019 •
edited
Loading

The current biquad IIR filter can represent a derivative part. It's just not exposed in the PID representation.

  • Derive the equations
  • Check whether adding a D part to the math has an impact on dynamic range
  • Expose, implement, map to network interface
@jordens jordens added the enhancement New feature or request label Dec 3, 2019
@jordens jordens mentioned this issue Oct 13, 2020
Open
@jordens
Copy link
Member Author

jordens commented Oct 14, 2020

Some tests and work on this at master...nkuh:master

@ryan-summers
Copy link
Member

@jordens Is this issue still relevant now that the IIRs have been moved to idsp and the dual_iir_configuration.py script exposes derivative control on the filters? I could be missing something here, but this seems stale to me.

@jordens
Copy link
Member Author

jordens commented Oct 13, 2021

Right. This is closed by #451 etc

@jordens jordens closed this as completed Oct 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jordens @ryan-summers