Feature/dual iir config script #451
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryan-summers
commented
Oct 8, 2021
github-actions
bot
added
the
changes-hitl
jordens
requested changes
Oct 8, 2021
jordens
requested changes
Oct 12, 2021
|
Looks very good, BTW! |
|
bors merge |
jordens
approved these changes
Oct 13, 2021
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses #339 by adding a CLI for configuring dual-iir's filter channels.
Currently, the following filters have been added:
The following controllers are also supported:
It may also be desired to generate a bode plot of the generated filter for the user upon request.
TODO:
scripts/directory