MQTT settings and telemetry #242
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bumps [smoltcp](https://github.com/smoltcp-rs/smoltcp) from 0.6.0 to 0.7.0. - [Release notes](https://github.com/smoltcp-rs/smoltcp/releases) - [Changelog](https://github.com/smoltcp-rs/smoltcp/blob/master/CHANGELOG.md) - [Commits](smoltcp-rs/smoltcp@v0.6.0...v0.7.0) Signed-off-by: dependabot[bot] <[email protected]>
Bumps [stm32h7xx-hal](https://github.com/stm32-rs/stm32h7xx-hal) from `3da22d4` to `2b8a04c`. - [Release notes](https://github.com/stm32-rs/stm32h7xx-hal/releases) - [Commits](stm32-rs/stm32h7xx-hal@3da22d4...2b8a04c) Signed-off-by: dependabot[bot] <[email protected]>
|
There will be items where committing them should not be unconditional. E.g. the state of an IIR filter: it makes sense to set them (to do a bumpless transfer you set the coefficients to "hold" the output, then manually change the output state, then set the coefficients to start steering the output) but it makes no sense to set it on each commit() even if it hasn't been dirtied. One option would be to encode that in the settings, i.e. have a setting that explicitly marks other settings as dirty and to be committed. |
…into rj/bump-hal-smoltcp * origin/dependabot/cargo/smoltcp-0.7.0: build(deps): bump smoltcp from 0.6.0 to 0.7.0
…b8a04c' into rj/bump-hal-smoltcp * origin/dependabot/cargo/stm32h7xx-hal-2b8a04c: build(deps): bump stm32h7xx-hal from `3da22d4` to `2b8a04c`
8 tasks
|
Closing in favor of #261 |
bors bot
added a commit
that referenced
this pull request
Feb 19, 2021
261: MQTT settings and telemetry r=ryan-summers a=ryan-summers This PR replaces #242 This PR addresses #149 by exposing a simple MQTT-based settings interface **TODO**: - [x] Resolve mutable ownership issues in the `MqttInterface` - [x] Expand settings interface to `lockin.rs` - [x] Add all settings (not yet supported by `miniconf`) - [x] ~~Finalize and publish the `miniconf` package~~ Deferred to the future. - [x] Move `MqttInterface`-like behaviors over to `miniconf` - [x] Move smoltcp-nal to a separate crate - [x] Test on hardware - [x] ~~Implement stabilizer telemetry~~: Deferred to future Co-authored-by: Ryan Summers <[email protected]> Co-authored-by: Robert Jördens <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses #149 by exposing a simple MQTT-based settings interface
TODO:
MqttInterfacelockin.rsminiconf)miniconfpackageMqttInterface-like behaviors over tominiconf