Adding check wait for HITL #332
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jordens
reviewed
Apr 9, 2021
jordens
requested changes
Apr 9, 2021
.github/workflows/hitl.yml
Outdated
| - uses: fountainhead/[email protected] | ||
| with: | ||
| token: ${{ secrets.GITHUB_TOKEN }} | ||
| checkName: HITL |
There was a problem hiding this comment.
Suggested change
| checkName: HITL | |
| checkName: HITL Run Status |
- Can we move the
cargo flashstep intohitl/run.sh? - Where is the
details_urlending up? It would be nice to have that link from the commit checks onstabilizerto the hitl run onhitl(for those who can access it). The check status stdout omits the commands that were executed (set -x goes to stderr). So the link to the actual run would be nice.
There was a problem hiding this comment.
Re: details_url - this appears to be a broken portion of the GHA API: LouisBrunner/checks-action#18
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR integrates the HITL into the PR check process - specifically, the HITL now posts a check onto the PR that we can require to pass.
This required the following: