-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding check wait for HITL #332
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool!
.github/workflows/hitl.yml
Outdated
- uses: fountainhead/[email protected] | ||
with: | ||
token: ${{ secrets.GITHUB_TOKEN }} | ||
checkName: HITL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
checkName: HITL | |
checkName: HITL Run Status |
- Can we move the
cargo flash
step intohitl/run.sh
? - Where is the
details_url
ending up? It would be nice to have that link from the commit checks onstabilizer
to the hitl run onhitl
(for those who can access it). The check status stdout omits the commands that were executed (set -x goes to stderr). So the link to the actual run would be nice.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Re: details_url
- this appears to be a broken portion of the GHA API: LouisBrunner/checks-action#18
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice
This PR integrates the HITL into the PR check process - specifically, the HITL now posts a check onto the PR that we can require to pass.
This required the following: