-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding Stabilizer User Manual #401
Conversation
A few items:
|
I originally investigated putting all of the docs into There are definite downsides to this though, such as the docs living in separate files from the source code. This risks the docs becoming outdated when source code is updated. That being said, there's also a fair number of docs that are totally unrelated to code, such as setting up MQTT, toolchains, flashing, debugging, etc. This is why I originally went with the combined approach of cargo-doc + Github pages / Jekyll. Definitely open to feedback - it's easy to move things around and reorganize.
This is an oversight on my part. The docs are uploaded to
Agreed - just haven't gotten to this yet. |
Maybe use dummy #[doc = include_str!("my_doc.md")]
struct S; |
Also |
README.md
Outdated
@@ -17,7 +17,7 @@ Several applications are provides by default: | |||
|
|||
### Dual-IIR | |||
|
|||
![Flow diagram](stabilizer_pid.svg) | |||
![Flow diagram](docs/assets/stabilizer_pid.svg) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This diagram is outdated and inaccurate. Docs in this README should now point to the stabilizer user manual site.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@SingularitySurfer could you spin a new diagram (sample rate 781 kHz) ? The existing one's source is the SVG in the repo if you need it. I used draw.io back then.
Regarding including/showing images in cargo docs, it works just fine with relative links for all "local" crates (which is what we care about here) and with absolute links for everything else.
https://docs.rs/ndarray/0.11.2/ndarray/type.ArrayView.html#method.split_at
or
https://users.rust-lang.org/t/include-images-in-rustdoc-output/3487/4
@jordens It looks like we can't generate docs for |
971f81b
to
f1947db
Compare
Ah. The |
@jordens I've gotten |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple minor things. Let's land and then tweak the rest later.
Co-authored-by: Robert Jördens <[email protected]>
…to feature/pages-docs
Co-authored-by: Robert Jördens <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's roll.
…to feature/pages-docs
This PR adds a user manual to Stabilizer using Jekyll + Github Pages.
You can see a sample of this site on http://quartiq.de/stabilizer
The page is served from the
pages
branch and a workflow has been set up to automatically copy and release docs on that branch whenmaster
is updated.Existing docs include:
This is intended as an initial stroke. With the framework in place, we can now easily add further docs via markdown and have them easily served to the website.