-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Documentation updates #452
Conversation
I think this should fix most of the issues I pointed out in #339 regarding the getting started section. I think we also had some problems there, but @jordens could have to say more about it than me |
From what I can tell, the only deviation that was made was to use a python virtual environment, which is really a user consideration IMO. If we want to steer users down that path, we can do so. Curious to hear this either way (I don't typically use virtual environments, but I see their benefits for sure). |
IME python venvs are really easy to use, don't need much space and provide an excellent isolation. For example, as a developer you want something like venvs as soon as you are both developing python packages and using them elsewhere. Or if you ever need to isolate yourself from system python packages which may be of a different version etc. And if we use |
bors try |
tryBuild failed: |
bors try |
tryBuild succeeded: |
bors merge |
Build succeeded: |
This PR fixes a variety of issues noted in #339 (comment)
This PR also fixes #449 by adding a
.gitattributes
file that forces the mosquitto config file to be checked out with LF line endings. It appears more recent versions of mosquitto require this.