Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pagebreak feature that currently broke last quarto release for qmd with knitr #760

Merged
merged 1 commit into from
Apr 29, 2022

Conversation

cderv
Copy link
Collaborator

@cderv cderv commented Apr 29, 2022

This was first reported in https://community.rstudio.com/t/error-while-rendering-first-quarto-document/135656/6
I can reproduce this error by rendering hello.qmd with latest github release of quarto 0.9.324

Error running filter C:/Users/chris/scoop/apps/quarto/current/share/filters/rmarkdown/pagebreak.lua:
cannot open C:/Users/chris/scoop/apps/quarto/current/share/filters/rmarkdown/pagebreak.lua: No such file or directory

The distribution does not bundle anymore the lua filter, which breaks the Pandoc rendering.

I see this morning that there was some work yesterday on pagebreak by @cscheid, which was reverted at some point. (3f03dbc, 263380c, faeaf59, e47e54f which all follow #740). Except for the prepare-dist.ts change. This PR fixes this by putting back the rmarkdown pagebreak filter in the distribution.

I did not found PR for the pagebreak feature, so less easy to revert everything, but I think this is the last change missing to be revert.

@jjallaire I don't know yet how to build a new release so I am doing this PR for you to see and rebuild a working release.

Regarding pagebreak feature, I adapted the filter for rmarkdown, so you need help making it work more generally for all format, do not hesitate.

@cderv cderv linked an issue Apr 29, 2022 that may be closed by this pull request
@jjallaire jjallaire merged commit c180e97 into main Apr 29, 2022
@jjallaire
Copy link
Collaborator

Thanks! Glad you caught this! I'll ping you later on this morning about plans for pagebreak -- in short we want to make it work as a shortcode (e.g. {{< pagebreak >}}) but still keep the rmarkdown-style variant for compatibility. I'll be doing some work soon to make shortcodes more extensible which will open up this possibility.

@cderv cderv deleted the fix-pagebreak-revert branch April 29, 2022 10:37
@cderv
Copy link
Collaborator Author

cderv commented Apr 29, 2022

Ok great - shortcodes syntax is a nice one! I would probably have used that in rmarkdown in the first place if we had thought more about this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pagebreak.lua: No such file or directory
2 participants